From cbd05117759f7e2f3c3c74dbd7728e3e8ab86ab7 Mon Sep 17 00:00:00 2001 From: rongli Date: Fri, 8 Jun 2018 00:17:33 +0800 Subject: [PATCH] [network-diagnostic] fix Connectivity and Route TLV type issue when get (#2769) Type value of Connectivity and Route TLV are different under different namespaces. --- src/core/thread/mle_router.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/core/thread/mle_router.cpp b/src/core/thread/mle_router.cpp index 3e2d2f8dc..2588787e3 100644 --- a/src/core/thread/mle_router.cpp +++ b/src/core/thread/mle_router.cpp @@ -4064,8 +4064,6 @@ void MleRouter::FillConnectivityTlv(ConnectivityTlv &aTlv) uint8_t cost; int8_t parentPriority = kParentPriorityMedium; - aTlv.Init(); - if (mParentPriority != kParentPriorityUnspecified) { parentPriority = mParentPriority; @@ -4192,6 +4190,7 @@ otError MleRouter::AppendConnectivity(Message &aMessage) otError error; ConnectivityTlv tlv; + tlv.Init(); FillConnectivityTlv(tlv); SuccessOrExit(error = aMessage.Append(&tlv, sizeof(tlv))); @@ -4244,7 +4243,6 @@ void MleRouter::FillRouteTlv(RouteTlv &aTlv) { uint8_t routerCount = 0; - aTlv.Init(); aTlv.SetRouterIdSequence(mRouterTable.GetRouterIdSequence()); aTlv.ClearRouterIdMask(); @@ -4302,6 +4300,7 @@ otError MleRouter::AppendRoute(Message &aMessage) otError error; RouteTlv tlv; + tlv.Init(); FillRouteTlv(tlv); SuccessOrExit(error = aMessage.Append(&tlv, sizeof(Tlv) + tlv.GetLength()));