From dc69fb1aceab72e0b0d1550ec3ba8200bae0424a Mon Sep 17 00:00:00 2001
From: Abtin Keshavarzian <abtink@google.com>
Date: Tue, 25 Jun 2024 13:08:31 -0700
Subject: [PATCH] [tcat-agent] use `Dataset` directly when setting Active
 Dataset (#10433)

This commit updates `HandleSetActiveOperationalDataset()` by removing
the extra conversion from `Dataset` to `Dataset::Tlvs` and directly
using the `Dataset` when saving the Active Operational Dataset.
---
 src/core/meshcop/tcat_agent.cpp | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/src/core/meshcop/tcat_agent.cpp b/src/core/meshcop/tcat_agent.cpp
index 29ae911b0..48dcba714 100644
--- a/src/core/meshcop/tcat_agent.cpp
+++ b/src/core/meshcop/tcat_agent.cpp
@@ -460,9 +460,8 @@ exit:
 
 Error TcatAgent::HandleSetActiveOperationalDataset(const Message &aIncommingMessage, uint16_t aOffset, uint16_t aLength)
 {
-    Dataset       dataset;
-    Dataset::Tlvs datasetTlvs;
-    Error         error;
+    Dataset dataset;
+    Error   error;
 
     SuccessOrExit(error = dataset.SetFrom(aIncommingMessage, aOffset, aLength));
     SuccessOrExit(error = dataset.ValidateTlvs());
@@ -474,8 +473,7 @@ Error TcatAgent::HandleSetActiveOperationalDataset(const Message &aIncommingMess
         ExitNow();
     }
 
-    dataset.ConvertTo(datasetTlvs);
-    error = Get<ActiveDatasetManager>().SaveLocal(datasetTlvs);
+    Get<ActiveDatasetManager>().SaveLocal(dataset);
 
 exit:
     return error;