From eadf51408486fe85cf20e3bec58585542c4755ba Mon Sep 17 00:00:00 2001 From: Abtin Keshavarzian Date: Wed, 12 Feb 2025 10:29:21 -0800 Subject: [PATCH] [routing-manager] use FavoredOmrPrefix::IsInfrastructureDerived() in PdPrefixManager (#11239) This commit updates `PdPrefixManager::Evaluate()` to directly use the helper method `FavoredOmrPrefix::IsInfrastructureDerived()` when deciding to pause and change to `kDhcp6PdStateIdle`. This helps improve code readability. --- src/core/border_router/routing_manager.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/core/border_router/routing_manager.cpp b/src/core/border_router/routing_manager.cpp index 5c5c9713c..da6cba55f 100644 --- a/src/core/border_router/routing_manager.cpp +++ b/src/core/border_router/routing_manager.cpp @@ -4007,9 +4007,7 @@ RoutingManager::PdPrefixManager::State RoutingManager::PdPrefixManager::GetState void RoutingManager::PdPrefixManager::Evaluate(void) { const FavoredOmrPrefix &favoredPrefix = Get().mOmrPrefixManager.GetFavoredPrefix(); - - bool shouldPause = !favoredPrefix.IsEmpty() && favoredPrefix.GetPrefix() != mPrefix.GetPrefix() && - favoredPrefix.GetPreference() >= kPdRoutePreference; + bool shouldPause = favoredPrefix.IsInfrastructureDerived() && (favoredPrefix.GetPrefix() != mPrefix.GetPrefix()); PauseResume(/* aPause */ shouldPause); }