From f13e35d5f72b3399199352d5afa462d5a166bae4 Mon Sep 17 00:00:00 2001
From: Abtin Keshavarzian <abtink@google.com>
Date: Fri, 25 Jan 2019 08:36:30 -0800
Subject: [PATCH] [mesh-forwarder] change Start() and Stop() to be void (no
 error return) (#3509)

---
 src/core/thread/mesh_forwarder.cpp | 11 +++--------
 src/core/thread/mesh_forwarder.hpp |  8 ++------
 2 files changed, 5 insertions(+), 14 deletions(-)

diff --git a/src/core/thread/mesh_forwarder.cpp b/src/core/thread/mesh_forwarder.cpp
index 654897d8f..8c8d60506 100644
--- a/src/core/thread/mesh_forwarder.cpp
+++ b/src/core/thread/mesh_forwarder.cpp
@@ -97,23 +97,18 @@ MeshForwarder::MeshForwarder(Instance &aInstance)
 #endif
 }
 
-otError MeshForwarder::Start(void)
+void MeshForwarder::Start(void)
 {
-    otError error = OT_ERROR_NONE;
-
     if (mEnabled == false)
     {
         GetNetif().GetMac().SetRxOnWhenIdle(true);
         mEnabled = true;
     }
-
-    return error;
 }
 
-otError MeshForwarder::Stop(void)
+void MeshForwarder::Stop(void)
 {
     ThreadNetif &netif = GetNetif();
-    otError      error = OT_ERROR_NONE;
     Message *    message;
 
     VerifyOrExit(mEnabled == true);
@@ -147,7 +142,7 @@ otError MeshForwarder::Stop(void)
     netif.GetMac().SetRxOnWhenIdle(false);
 
 exit:
-    return error;
+    return;
 }
 
 void MeshForwarder::RemoveMessage(Message &aMessage)
diff --git a/src/core/thread/mesh_forwarder.hpp b/src/core/thread/mesh_forwarder.hpp
index 35eb38872..cb3d6b055 100644
--- a/src/core/thread/mesh_forwarder.hpp
+++ b/src/core/thread/mesh_forwarder.hpp
@@ -181,18 +181,14 @@ public:
     /**
      * This method enables mesh forwarding and the IEEE 802.15.4 MAC layer.
      *
-     * @retval OT_ERROR_NONE          Successfully enabled the mesh forwarder.
-     *
      */
-    otError Start(void);
+    void Start(void);
 
     /**
      * This method disables mesh forwarding and the IEEE 802.15.4 MAC layer.
      *
-     * @retval OT_ERROR_NONE          Successfully disabled the mesh forwarder.
-     *
      */
-    otError Stop(void);
+    void Stop(void);
 
     /**
      * This method submits a message to the mesh forwarder for forwarding.