From f6f76b74a38ff2f47bec760df1305fe1c145f382 Mon Sep 17 00:00:00 2001 From: Jing Ma Date: Thu, 5 Nov 2020 12:45:01 +0800 Subject: [PATCH] [thread-cert] refactor case 5.1.8 using pktverify (#5739) --- .../Cert_5_1_08_RouterAttachConnectivity.py | 162 ++++++++++++++---- 1 file changed, 125 insertions(+), 37 deletions(-) diff --git a/tests/scripts/thread-cert/Cert_5_1_08_RouterAttachConnectivity.py b/tests/scripts/thread-cert/Cert_5_1_08_RouterAttachConnectivity.py index 907eb53fd..7152918a1 100755 --- a/tests/scripts/thread-cert/Cert_5_1_08_RouterAttachConnectivity.py +++ b/tests/scripts/thread-cert/Cert_5_1_08_RouterAttachConnectivity.py @@ -32,6 +32,9 @@ import unittest import config import mle import thread_cert +from pktverify.consts import MLE_PARENT_REQUEST, MLE_PARENT_RESPONSE, MLE_CHILD_ID_REQUEST, SOURCE_ADDRESS_TLV, MODE_TLV, TIMEOUT_TLV, CHALLENGE_TLV, RESPONSE_TLV, LINK_LAYER_FRAME_COUNTER_TLV, ADDRESS16_TLV, LEADER_DATA_TLV, NETWORK_DATA_TLV, TLV_REQUEST_TLV, SCAN_MASK_TLV, CONNECTIVITY_TLV, LINK_MARGIN_TLV, VERSION_TLV, ADDRESS_REGISTRATION_TLV +from pktverify.packet_verifier import PacketVerifier +from pktverify.null_field import nullField LEADER = 1 ROUTER1 = 2 @@ -39,33 +42,57 @@ ROUTER2 = 3 ROUTER3 = 4 ROUTER4 = 5 +# Test Purpose and Description: +# ----------------------------- +# The purpose of this test case is to verify that the DUT chooses +# to attach to a router with better connectivity +# +# Test Topology: +# ------------- +# Leader--Router1 +# / \ / +# Router2 Router3 +# \ / +# Router4[DUT] +# +# DUT Types: +# ---------- +# Router + class Cert_5_1_08_RouterAttachConnectivity(thread_cert.TestCase): + USE_MESSAGE_FACTORY = False + TOPOLOGY = { LEADER: { + 'name': 'LEADER', 'mode': 'rdn', 'panid': 0xface, 'allowlist': [ROUTER1, ROUTER2, ROUTER3] }, ROUTER1: { + 'name': 'ROUTER_1', 'mode': 'rdn', 'panid': 0xface, 'router_selection_jitter': 1, 'allowlist': [LEADER, ROUTER3] }, ROUTER2: { + 'name': 'ROUTER_2', 'mode': 'rdn', 'panid': 0xface, 'router_selection_jitter': 1, 'allowlist': [LEADER, ROUTER4] }, ROUTER3: { + 'name': 'ROUTER_3', 'mode': 'rdn', 'panid': 0xface, 'router_selection_jitter': 1, 'allowlist': [LEADER, ROUTER1, ROUTER4] }, ROUTER4: { + 'name': 'ROUTER_4', 'mode': 'rdn', 'panid': 0xface, 'router_selection_jitter': 1, @@ -92,49 +119,110 @@ class Cert_5_1_08_RouterAttachConnectivity(thread_cert.TestCase): self.simulator.go(5) self.assertEqual(self.nodes[ROUTER4].get_state(), 'router') - leader_messages = self.simulator.get_messages_sent_by(LEADER) - router1_messages = self.simulator.get_messages_sent_by(ROUTER1) - router2_messages = self.simulator.get_messages_sent_by(ROUTER2) - router3_messages = self.simulator.get_messages_sent_by(ROUTER3) - router4_messages = self.simulator.get_messages_sent_by(ROUTER4) + def verify(self, pv): + pkts = pv.pkts + pv.summary.show() - # 1 - Leader, Router1, Router2, Router3 - leader_messages.next_mle_message(mle.CommandType.ADVERTISEMENT) - router1_messages.next_mle_message(mle.CommandType.ADVERTISEMENT) - router2_messages.next_mle_message(mle.CommandType.ADVERTISEMENT) - router3_messages.next_mle_message(mle.CommandType.ADVERTISEMENT) + ROUTER_2 = pv.vars['ROUTER_2'] + ROUTER_3 = pv.vars['ROUTER_3'] + ROUTER_4 = pv.vars['ROUTER_4'] - # 2 - Router4 - msg = router4_messages.next_mle_message(mle.CommandType.PARENT_REQUEST) - msg.assertSentWithHopLimit(255) - msg.assertSentToDestinationAddress("ff02::2") - msg.assertMleMessageContainsTlv(mle.Mode) - msg.assertMleMessageContainsTlv(mle.Challenge) - msg.assertMleMessageContainsTlv(mle.ScanMask) - msg.assertMleMessageContainsTlv(mle.Version) + # Step 1: Verify all routers and Leader are sending MLE advertisements. + for i in (1, 2, 3): + with pkts.save_index(): + pv.verify_attached('ROUTER_%d' % i) - scan_mask_tlv = msg.get_mle_message_tlv(mle.ScanMask) - self.assertEqual(1, scan_mask_tlv.router) - self.assertEqual(0, scan_mask_tlv.end_device) + # Step 3: DUT sends a MLE Parent Request with an IP hop limit of + # 255 to the Link-Local All Routers multicast address (FF02::2). + # The following TLVs MUST be present in the MLE Parent Request: + # - Challenge TLV + # - Mode TLV + # - Scan Mask TLV + # If the DUT sends multiple MLE Parent Requests + # - The first one MUST be sent only to all Routers + # - Subsequent ones MAY be sent to all Routers and REEDS + # - Version TLV + # If the first MLE Parent Request was sent to all Routers and + # REEDS, the test fails. - # 3 - Router2, Router3 - msg = router2_messages.next_mle_message(mle.CommandType.PARENT_RESPONSE) - msg.assertSentToNode(self.nodes[ROUTER4]) + pkts.filter_wpan_src64(ROUTER_4).\ + filter_LLARMA().\ + filter_mle_cmd(MLE_PARENT_REQUEST).\ + filter(lambda p: { + CHALLENGE_TLV, + MODE_TLV, + SCAN_MASK_TLV, + VERSION_TLV + } <= set(p.mle.tlv.type) and\ + p.ipv6.hlim == 255 and\ + p.mle.tlv.scan_mask.r == 1 and\ + p.mle.tlv.scan_mask.e == 0 + ).\ + must_next() - msg = router3_messages.next_mle_message(mle.CommandType.PARENT_RESPONSE) - msg.assertSentToNode(self.nodes[ROUTER4]) + # Step 4: Router2 and Router3 respond with a MLE Parent Response. + # The following TLVs MUST be present in the MLE Parent Response: + # - Challenge TLV + # - Connectivity TLV + # - Leader Data TLV + # - Link-layer Frame Counter TLV + # - Link Margin TLV + # - Response TLV + # - Source Address + # - Version TLV + # - MLE Frame Counter TLV (optional) - # 4 - Router4 - msg = router4_messages.next_mle_message(mle.CommandType.CHILD_ID_REQUEST) - msg.assertSentToNode(self.nodes[ROUTER3]) - msg.assertMleMessageContainsTlv(mle.Response) - msg.assertMleMessageContainsTlv(mle.LinkLayerFrameCounter) - msg.assertMleMessageContainsOptionalTlv(mle.MleFrameCounter) - msg.assertMleMessageContainsTlv(mle.Mode) - msg.assertMleMessageContainsTlv(mle.Timeout) - msg.assertMleMessageContainsTlv(mle.Version) - msg.assertMleMessageContainsTlv(mle.TlvRequest) - msg.assertMleMessageDoesNotContainTlv(mle.AddressRegistration) + for i in (2, 3): + with pkts.save_index(): + pkts.filter_wpan_src64(pv.vars['ROUTER_%d' % i]).\ + filter_wpan_dst64(ROUTER_4).\ + filter_mle_cmd(MLE_PARENT_RESPONSE).\ + filter(lambda p: { + CHALLENGE_TLV, + CONNECTIVITY_TLV, + LEADER_DATA_TLV, + LINK_LAYER_FRAME_COUNTER_TLV, + LINK_MARGIN_TLV, + RESPONSE_TLV, + SOURCE_ADDRESS_TLV, + VERSION_TLV + } <= set(p.mle.tlv.type) + ).\ + must_next() + + # Step 5: DUT sends a MLE Child ID Request to Router3. + # The following TLVs MUST be present in the MLE Child ID Request: + # - Link-layer Frame Counter TLV + # - Mode TLV + # - Response TLV + # - Timeout TLV + # - TLV Request TLV + # - Address16 TLV + # - Network Data TLV + # - Route64 TLV (optional) + # - Version TLV + # - MLE Frame Counter TLV (optional) + # The following TLV MUST NOT be present in the MLE Child ID Request: + # - Address Registration TLV + + _pkt = pkts.filter_wpan_src64(ROUTER_4).\ + filter_wpan_dst64(ROUTER_3).\ + filter_mle_cmd(MLE_CHILD_ID_REQUEST).\ + filter(lambda p: { + LINK_LAYER_FRAME_COUNTER_TLV, + MODE_TLV, + RESPONSE_TLV, + TIMEOUT_TLV, + TLV_REQUEST_TLV, + ADDRESS16_TLV, + NETWORK_DATA_TLV, + VERSION_TLV + } <= set(p.mle.tlv.type) and\ + p.mle.tlv.addr16 is nullField and\ + p.thread_nwd.tlv.type is nullField + ).\ + must_next() + _pkt.must_not_verify(lambda p: (ADDRESS_REGISTRATION_TLV) in p.mle.tlv.type) if __name__ == '__main__':