mirror of
https://github.com/espressif/openthread.git
synced 2026-09-26 19:07:32 +00:00
This commit introduces a structured state machine to `Mlr::Manager` to coordinate Multicast Listener Registration (MLR) activities more efficiently. The previous implementation relied on independent delay variables and the global `TimeTicker`, which could lead to redundant or premature registrations, especially when a Primary Backbone Router (PBBR) was newly discovered or updated. The new state machine (`kStateStopped`, `kStateIdle`, `kStateToRegisterAll`, `kStateRegistering`, `kStateRegistered`, `kStateNewAddrToRegister`) provides explicit transitions for the entire MLR lifecycle. This ensures that registrations are properly aggregated and that periodic renewals are correctly rescheduled after successful out-of-band registrations. Additionally, the manager now uses a dedicated `TimerMilli` instead of `TimeTicker`, reducing system-wide overhead and providing more precise timing control.
257 lines
9.2 KiB
C++
257 lines
9.2 KiB
C++
/*
|
|
* Copyright (c) 2026, The OpenThread Authors.
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions are met:
|
|
* 1. Redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer.
|
|
* 2. Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in the
|
|
* documentation and/or other materials provided with the distribution.
|
|
* 3. Neither the name of the copyright holder nor the
|
|
* names of its contributors may be used to endorse or promote products
|
|
* derived from this software without specific prior written permission.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
|
|
* AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
|
|
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
|
|
* ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE
|
|
* LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
|
|
* CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
|
|
* SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
|
|
* INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
|
|
* CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
|
|
* ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
|
|
* POSSIBILITY OF SUCH DAMAGE.
|
|
*/
|
|
|
|
#include <stdio.h>
|
|
|
|
#include "coap/coap.hpp"
|
|
#include "coap/coap_message.hpp"
|
|
#include "platform/nexus_core.hpp"
|
|
#include "platform/nexus_node.hpp"
|
|
|
|
namespace ot {
|
|
namespace Nexus {
|
|
|
|
static constexpr uint32_t kFormNetworkTime = 10 * 1000;
|
|
static constexpr uint32_t kAttachAsRouterTime = 200 * 1000;
|
|
static constexpr uint32_t kAttachAsSedTime = 10 * 1000;
|
|
static constexpr uint32_t kMlrRegistrationTime = 10 * 1000;
|
|
|
|
struct Context
|
|
{
|
|
Context(void) { mMlrReqCount = 0; }
|
|
|
|
uint32_t mMlrReqCount;
|
|
Ip6::Address mTargetAddress;
|
|
};
|
|
|
|
static Error BrCoapInterceptor(void *aContext, const Coap::Msg &aMsg)
|
|
{
|
|
Mlr::AddressArray addresses;
|
|
Context *context = static_cast<Context *>(aContext);
|
|
Coap::Message::UriPathStringBuffer uriPath;
|
|
|
|
VerifyOrQuit(context != nullptr);
|
|
|
|
VerifyOrExit(aMsg.IsPostRequest());
|
|
|
|
SuccessOrExit(aMsg.mMessage.ReadUriPathOptions(uriPath));
|
|
VerifyOrExit(UriFromPath(uriPath) == kUriMlr);
|
|
|
|
SuccessOrExit(Ip6AddressesTlv::FindIn(aMsg.mMessage, addresses));
|
|
|
|
Log(" Received MLR.req with %u addresses:", addresses.GetLength());
|
|
|
|
for (const Ip6::Address &address : addresses)
|
|
{
|
|
Log(" - %s", address.ToString().AsCString());
|
|
}
|
|
|
|
if (addresses.Contains(context->mTargetAddress))
|
|
{
|
|
context->mMlrReqCount++;
|
|
}
|
|
|
|
exit:
|
|
return kErrorNone;
|
|
}
|
|
|
|
void TestMlrRedundant(void)
|
|
{
|
|
/**
|
|
* This test verifies that the MLR manager does not send redundant registration
|
|
* requests when multiple entities (a parent router and its children) subscribe
|
|
* to the same multicast address. It sets up a scenario where the total number
|
|
* of subscribed addresses exceeds the capacity of a single MLR.req CoAP message,
|
|
* ensuring that the state is properly managed and shared addresses are registered
|
|
* exactly once with the Primary Backbone Router.
|
|
*/
|
|
|
|
Core nexus;
|
|
Node &br = nexus.CreateNode();
|
|
Node &router = nexus.CreateNode();
|
|
Node &sed1 = nexus.CreateNode();
|
|
Node &sed2 = nexus.CreateNode();
|
|
Node &sed3 = nexus.CreateNode();
|
|
Ip6::Address sharedAddress;
|
|
Context context;
|
|
|
|
nexus.AdvanceTime(0);
|
|
SuccessOrQuit(Instance::SetGlobalLogLevel(kLogLevelNote));
|
|
|
|
// - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
|
|
Log("Form topology");
|
|
|
|
AllowLinkBetween(br, router);
|
|
AllowLinkBetween(router, sed1);
|
|
AllowLinkBetween(router, sed2);
|
|
AllowLinkBetween(router, sed3);
|
|
|
|
br.Form();
|
|
nexus.AdvanceTime(kFormNetworkTime);
|
|
VerifyOrQuit(br.Get<Mle::Mle>().IsLeader());
|
|
|
|
router.Join(br, Node::kAsFtd);
|
|
nexus.AdvanceTime(kAttachAsRouterTime);
|
|
VerifyOrQuit(router.Get<Mle::Mle>().IsRouter());
|
|
|
|
sed1.Join(router, Node::kAsSed);
|
|
sed2.Join(router, Node::kAsSed);
|
|
sed3.Join(router, Node::kAsSed);
|
|
|
|
SuccessOrQuit(sed1.Get<DataPollSender>().SetExternalPollPeriod(5 * Time::kOneSecondInMsec));
|
|
SuccessOrQuit(sed2.Get<DataPollSender>().SetExternalPollPeriod(5 * Time::kOneSecondInMsec));
|
|
SuccessOrQuit(sed3.Get<DataPollSender>().SetExternalPollPeriod(5 * Time::kOneSecondInMsec));
|
|
|
|
nexus.AdvanceTime(kAttachAsSedTime);
|
|
|
|
VerifyOrQuit(sed1.Get<Mle::Mle>().IsChild());
|
|
VerifyOrQuit(sed2.Get<Mle::Mle>().IsChild());
|
|
VerifyOrQuit(sed3.Get<Mle::Mle>().IsChild());
|
|
|
|
SuccessOrQuit(sharedAddress.FromString("ff04::1"));
|
|
context.mTargetAddress = sharedAddress;
|
|
|
|
// - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
|
|
Log("Set an interceptor on leader to count incoming MLR.req messages");
|
|
br.Get<Tmf::Agent>().SetInterceptor(BrCoapInterceptor, &context);
|
|
|
|
Log("Router and SEDs subscribe to the same multicast address");
|
|
SuccessOrQuit(router.Get<Ip6::Netif>().SubscribeExternalMulticast(sharedAddress));
|
|
SuccessOrQuit(sed1.Get<Ip6::Netif>().SubscribeExternalMulticast(sharedAddress));
|
|
SuccessOrQuit(sed2.Get<Ip6::Netif>().SubscribeExternalMulticast(sharedAddress));
|
|
SuccessOrQuit(sed3.Get<Ip6::Netif>().SubscribeExternalMulticast(sharedAddress));
|
|
|
|
Log("Router subscribes to 14 more unique multicast addresses to trigger MLR IP6 Addresses TLV limits");
|
|
|
|
for (uint8_t i = 2; i <= 15; i++)
|
|
{
|
|
Ip6::Address ma;
|
|
|
|
ma = sharedAddress;
|
|
ma.mFields.m8[15] = i;
|
|
|
|
SuccessOrQuit(router.Get<Ip6::Netif>().SubscribeExternalMulticast(ma));
|
|
}
|
|
|
|
nexus.AdvanceTime(15 * Time::kOneSecondInMsec);
|
|
|
|
Log("Enable BBR on wait for MLR registrations");
|
|
br.Get<BackboneRouter::Local>().SetEnabled(true);
|
|
|
|
nexus.AdvanceTime(kMlrRegistrationTime);
|
|
|
|
Log("Verify the shared address was registered exactly once (no redundant registrations)");
|
|
|
|
VerifyOrQuit(context.mMlrReqCount == 1);
|
|
}
|
|
|
|
void TestMlrState(void)
|
|
{
|
|
/**
|
|
* This test verifies the state machine transitions and timing behavior of the MLR manager.
|
|
*/
|
|
|
|
Core nexus;
|
|
Node &br = nexus.CreateNode();
|
|
Node &router = nexus.CreateNode();
|
|
Ip6::Address firstAddress;
|
|
Ip6::Address newAddress;
|
|
BackboneRouter::Config config;
|
|
Context context;
|
|
|
|
nexus.AdvanceTime(0);
|
|
SuccessOrQuit(Instance::SetGlobalLogLevel(kLogLevelNote));
|
|
|
|
// - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
|
|
Log("Form topology");
|
|
|
|
AllowLinkBetween(br, router);
|
|
br.Form();
|
|
nexus.AdvanceTime(kFormNetworkTime);
|
|
router.Join(br, Node::kAsFtd);
|
|
nexus.AdvanceTime(kAttachAsRouterTime);
|
|
|
|
SuccessOrQuit(firstAddress.FromString("ff04::1"));
|
|
context.mTargetAddress = firstAddress;
|
|
br.Get<Tmf::Agent>().SetInterceptor(BrCoapInterceptor, &context);
|
|
|
|
Log("Enable BBR and verify initial registration");
|
|
br.Get<BackboneRouter::Local>().SetEnabled(true);
|
|
SuccessOrQuit(router.Get<Ip6::Netif>().SubscribeExternalMulticast(firstAddress));
|
|
|
|
nexus.AdvanceTime(kMlrRegistrationTime);
|
|
VerifyOrQuit(context.mMlrReqCount == 1);
|
|
|
|
// - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
|
|
Log("Add new address and verify quick registration");
|
|
|
|
SuccessOrQuit(newAddress.FromString("ff04::100"));
|
|
context.mTargetAddress = newAddress;
|
|
context.mMlrReqCount = 0;
|
|
|
|
SuccessOrQuit(router.Get<Ip6::Netif>().SubscribeExternalMulticast(newAddress));
|
|
|
|
// Verify it is registered quickly (within short aggregation window)
|
|
nexus.AdvanceTime(1000);
|
|
VerifyOrQuit(context.mMlrReqCount == 1);
|
|
|
|
// - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
|
|
Log("Update MLR Timeout and verify renewal time update");
|
|
|
|
config = br.Get<BackboneRouter::Leader>().GetConfig();
|
|
|
|
Log("Initial MLR timeout: %lu", ToUlong(br.Get<BackboneRouter::Leader>().GetConfig().GetMlrTimeout()));
|
|
|
|
// We set a short MLR timeout (300 seconds is the minimum).
|
|
config.mReregistrationDelay = 10;
|
|
config.mMlrTimeout = 300;
|
|
SuccessOrQuit(br.Get<BackboneRouter::Local>().SetConfig(config));
|
|
|
|
context.mTargetAddress = firstAddress;
|
|
context.mMlrReqCount = 0;
|
|
|
|
Log("Wait for renewal registration");
|
|
|
|
// Renewal happens between (0.5 * 300) = 150s and (300 - 9) = 291s.
|
|
nexus.AdvanceTime(300 * Time::kOneSecondInMsec);
|
|
|
|
VerifyOrQuit(context.mMlrReqCount >= 1);
|
|
Log("Renewal registration successful");
|
|
}
|
|
|
|
} // namespace Nexus
|
|
} // namespace ot
|
|
|
|
int main(void)
|
|
{
|
|
ot::Nexus::TestMlrRedundant();
|
|
ot::Nexus::TestMlrState();
|
|
printf("All tests passed\n");
|
|
return 0;
|
|
}
|