mirror of
https://github.com/espressif/openthread.git
synced 2026-06-06 05:24:51 +00:00
mohammadmseet-hue
675162556b
`PtrRecord::ReadPtrName()` reads a PTR target's first label with
`Name::ReadLabel()`, which performs no emptiness check. A response whose
first label is a single NUL byte (wire `01 00`) is stored as an empty
C-string and cached by the browse cache as a service instance. When the
cache later builds a known-answer question, it calls
`Name::AppendLabel("")`, which returns `kErrorInvalidArgs`; the
surrounding `SuccessOrAssert()` turns that into an abort. A single
unauthenticated link-local mDNS response thus crashes any node with an
active browser.
Reject an empty first label in `ReadPtrName()` so the record is dropped
on receive and never cached. This matches the `Name::ValidateLabel`
checks already applied on the registration and resolver paths, and makes
the "ReadPtrName() validates that PTR record is well-formed" comment at
the call site accurate.
Add a regression test that delivers a PTR response with a single
NUL-byte instance label and verifies no result is reported and the
browser keeps querying without the malformed entry.
OpenThread Unit Tests
This page describes how to build and run OpenThread unit tests. It will be helpful for developers to debug failed unit test cases if they got one in CI or to add some new test cases.
Build Simulation
The unit tests cannot be built solely without building the whole project. So first build OpenThread on the simulation platform, which will also build all unit tests:
# Go to the root directory of OpenThread
$ script/cmake-build simulation
List all tests
To see what tests are available in OpenThread:
# Make sure you are at the simulation build directory (build/simulation)
$ ctest -N
Run the Unit Tests
To run all the unit tests:
# Make sure you are at the simulation build directory (build/simulation)
$ ctest
To run a specific unit test, for example, ot-test-spinel:
# Make sure you are at the simulation build directory (build/simulation)
$ ctest -R ot-test-spinel
Update a Test Case
If you are developing a unit test case and have made some changes in the test source file, you will need rebuild the test before running it:
# Make sure you are at the simulation build directory (build/simulation)
$ ninja <test_name>
This will only build the test and take a short time.
If any changes or fixes were made to the OpenThread code, then you'll need to rebuild the entire project:
# Make sure you are at the simulation build directory (build/simulation)
$ ninja
This will build the updated OpenThread code as well as the test cases.