[https://nvbugs/5453827][fix] Fix RPATH of th_common shared library to find pip-installed NCCL (#6984)

Signed-off-by: Yuan Tong <13075180+tongyuantongyu@users.noreply.github.com>
This commit is contained in:
Yuan Tong 2025-08-21 17:58:30 +08:00 committed by GitHub
parent c7269ea93a
commit 90bfc8cc29
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 4 additions and 10 deletions

View File

@ -294,8 +294,7 @@ if(TARGET ${NIXL_WRAPPER_TARGET})
endif() endif()
if(NOT WIN32) if(NOT WIN32)
set_target_properties(${SHARED_TARGET} PROPERTIES LINK_FLAGS set_target_properties(${SHARED_TARGET} PROPERTIES BUILD_RPATH "$ORIGIN")
"-Wl,-rpath='$ORIGIN'")
endif() endif()
if(BUILD_PYT) if(BUILD_PYT)

View File

@ -119,9 +119,9 @@ endif()
if(NOT WIN32) if(NOT WIN32)
set_target_properties( set_target_properties(
th_common th_common PROPERTIES BUILD_RPATH "$ORIGIN;$ORIGIN/../../nvidia/nccl/lib")
PROPERTIES LINK_FLAGS set_target_properties(
"-Wl,-rpath='$ORIGIN' ${AS_NEEDED_FLAG} ${UNDEFINED_FLAG}") th_common PROPERTIES LINK_FLAGS "${AS_NEEDED_FLAG} ${UNDEFINED_FLAG}")
else() else()
target_link_libraries(th_common PRIVATE context_attention_src) target_link_libraries(th_common PRIVATE context_attention_src)
endif() endif()

View File

@ -2079,11 +2079,6 @@ def launchTestJobs(pipeline, testFilter, dockerNode=null)
checkPipStage = true checkPipStage = true
} }
if (cpu_arch == AARCH64_TRIPLE && values[5] != DLFW_IMAGE) {
checkPipStage = false
echo "Skip pip install sanity check due to https://nvbugs/5453827"
}
if (checkPipStage) { if (checkPipStage) {
stage("Run LLMAPI tests") { stage("Run LLMAPI tests") {
pipInstallSanitySpec = createKubernetesPodConfig(values[5], gpu_type, k8s_arch) pipInstallSanitySpec = createKubernetesPodConfig(values[5], gpu_type, k8s_arch)