From 65c24a2f4b457bbeaa0957ea053cbcf5a828841e Mon Sep 17 00:00:00 2001
From: fullex <0xfullex@gmail.com>
Date: Sat, 16 Aug 2025 18:52:46 +0800
Subject: [PATCH] fix(selection): disable sandbox mode in SelectionService and
 clean up imports in ActionTranslate component

- Changed sandbox mode from true to false in SelectionService to improve security and functionality.
- Removed unnecessary blank line in entryPoint.tsx for cleaner code.
- Updated ActionTranslate component to use the new SelectionActionItem type for better type safety.
---
 src/main/services/SelectionService.ts                       | 2 +-
 .../windows/selection/action/components/ActionTranslate.tsx | 6 +++---
 src/renderer/src/windows/selection/action/entryPoint.tsx    | 1 -
 3 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/src/main/services/SelectionService.ts b/src/main/services/SelectionService.ts
index 70c35e7add..78267991d3 100644
--- a/src/main/services/SelectionService.ts
+++ b/src/main/services/SelectionService.ts
@@ -1132,7 +1132,7 @@ export class SelectionService {
         preload: join(__dirname, '../preload/index.js'),
         contextIsolation: true,
         nodeIntegration: false,
-        sandbox: true,
+        sandbox: false,
         devTools: true
       }
     })
diff --git a/src/renderer/src/windows/selection/action/components/ActionTranslate.tsx b/src/renderer/src/windows/selection/action/components/ActionTranslate.tsx
index f342388f4b..2730a98775 100644
--- a/src/renderer/src/windows/selection/action/components/ActionTranslate.tsx
+++ b/src/renderer/src/windows/selection/action/components/ActionTranslate.tsx
@@ -10,10 +10,10 @@ import useTranslate from '@renderer/hooks/useTranslate'
 import MessageContent from '@renderer/pages/home/Messages/MessageContent'
 import { getDefaultTopic, getDefaultTranslateAssistant } from '@renderer/services/AssistantService'
 import { Assistant, Topic, TranslateLanguage } from '@renderer/types'
-import type { ActionItem } from '@renderer/types/selectionTypes'
 import { runAsyncFunction } from '@renderer/utils'
 import { abortCompletion } from '@renderer/utils/abortController'
 import { detectLanguage } from '@renderer/utils/translate'
+import type { SelectionActionItem } from '@shared/data/types'
 import { Tooltip } from 'antd'
 import { ArrowRightFromLine, ArrowRightToLine, ChevronDown, CircleHelp, Globe } from 'lucide-react'
 import { FC, useCallback, useEffect, useMemo, useRef, useState } from 'react'
@@ -23,11 +23,11 @@ import styled from 'styled-components'
 import { processMessages } from './ActionUtils'
 import WindowFooter from './WindowFooter'
 interface Props {
-  action: ActionItem
+  action: SelectionActionItem
   scrollToBottom: () => void
 }
 
-const logger = loggerService
+const logger = loggerService.withContext('ActionTranslate')
 
 const ActionTranslate: FC<Props> = ({ action, scrollToBottom }) => {
   const { t } = useTranslation()
diff --git a/src/renderer/src/windows/selection/action/entryPoint.tsx b/src/renderer/src/windows/selection/action/entryPoint.tsx
index bbbe2aff0f..4de3eab1b6 100644
--- a/src/renderer/src/windows/selection/action/entryPoint.tsx
+++ b/src/renderer/src/windows/selection/action/entryPoint.tsx
@@ -17,7 +17,6 @@ import { PersistGate } from 'redux-persist/integration/react'
 import SelectionActionApp from './SelectionActionApp'
 
 loggerService.initWindowSource('SelectionActionWindow')
-
 /**
  * fetchChatCompletion depends on this,
  * which is not a good design, but we have to add it for now