From ffc39b02352fa29f749fe9f05f6d3569f5139da3 Mon Sep 17 00:00:00 2001 From: yyh Date: Tue, 13 Jan 2026 15:07:04 +0800 Subject: [PATCH] refactor: rename ACCOUNT_SETTING_TAB.PROVIDER to MODEL_PROVIDER Rename the constant for clarity and consistency with the new sandbox-provider tab naming convention. Update all references across the codebase to use the new constant name. --- .../dataset-config/settings-modal/index.spec.tsx | 2 +- .../configuration/dataset-config/settings-modal/index.tsx | 2 +- web/app/components/app/configuration/index.tsx | 8 ++++---- .../app/overview/apikey-info-panel/cloud.spec.tsx | 2 +- .../app/overview/apikey-info-panel/index.spec.tsx | 2 +- .../components/app/overview/apikey-info-panel/index.tsx | 2 +- .../moderation/moderation-setting-modal.tsx | 4 ++-- web/app/components/datasets/create/index.tsx | 2 +- .../documents/detail/settings/document-settings.tsx | 3 ++- web/app/components/header/account-setting/constants.ts | 2 +- web/app/components/header/account-setting/index.tsx | 6 +++--- .../model-provider-page/model-selector/popup.tsx | 2 +- 12 files changed, 19 insertions(+), 18 deletions(-) diff --git a/web/app/components/app/configuration/dataset-config/settings-modal/index.spec.tsx b/web/app/components/app/configuration/dataset-config/settings-modal/index.spec.tsx index c4fdfb7553..b6273f66ff 100644 --- a/web/app/components/app/configuration/dataset-config/settings-modal/index.spec.tsx +++ b/web/app/components/app/configuration/dataset-config/settings-modal/index.spec.tsx @@ -360,7 +360,7 @@ describe('SettingsModal', () => { await user.click(screen.getByText('datasetSettings.form.embeddingModelTipLink')) // Assert - expect(mockSetShowAccountSettingModal).toHaveBeenCalledWith({ payload: ACCOUNT_SETTING_TAB.PROVIDER }) + expect(mockSetShowAccountSettingModal).toHaveBeenCalledWith({ payload: ACCOUNT_SETTING_TAB.MODEL_PROVIDER }) }) }) diff --git a/web/app/components/app/configuration/dataset-config/settings-modal/index.tsx b/web/app/components/app/configuration/dataset-config/settings-modal/index.tsx index 32ca4f99cd..d83fd93d1e 100644 --- a/web/app/components/app/configuration/dataset-config/settings-modal/index.tsx +++ b/web/app/components/app/configuration/dataset-config/settings-modal/index.tsx @@ -282,7 +282,7 @@ const SettingsModal: FC = ({
{t('form.embeddingModelTip', { ns: 'datasetSettings' })} - setShowAccountSettingModal({ payload: ACCOUNT_SETTING_TAB.PROVIDER })}>{t('form.embeddingModelTipLink', { ns: 'datasetSettings' })} + setShowAccountSettingModal({ payload: ACCOUNT_SETTING_TAB.MODEL_PROVIDER })}>{t('form.embeddingModelTipLink', { ns: 'datasetSettings' })}
diff --git a/web/app/components/app/configuration/index.tsx b/web/app/components/app/configuration/index.tsx index 919b7c355a..39f03855d8 100644 --- a/web/app/components/app/configuration/index.tsx +++ b/web/app/components/app/configuration/index.tsx @@ -577,7 +577,7 @@ const Configuration: FC = () => { // old dataset struct if (modelConfig.agent_mode?.tools?.find(({ dataset }: any) => dataset?.enabled)) datasets = modelConfig.agent_mode?.tools.filter(({ dataset }: any) => dataset?.enabled) - // new dataset struct + // new dataset struct else if (modelConfig.dataset_configs.datasets?.datasets?.length > 0) datasets = modelConfig.dataset_configs?.datasets?.datasets @@ -1033,7 +1033,7 @@ const Configuration: FC = () => {
setShowAccountSettingModal({ payload: ACCOUNT_SETTING_TAB.PROVIDER })} + onSetting={() => setShowAccountSettingModal({ payload: ACCOUNT_SETTING_TAB.MODEL_PROVIDER })} inputs={inputs} modelParameterParams={{ setModel: setModel as any, @@ -1054,7 +1054,7 @@ const Configuration: FC = () => { content={t('trailUseGPT4Info.description', { ns: 'appDebug' })} isShow={showUseGPT4Confirm} onConfirm={() => { - setShowAccountSettingModal({ payload: ACCOUNT_SETTING_TAB.PROVIDER }) + setShowAccountSettingModal({ payload: ACCOUNT_SETTING_TAB.MODEL_PROVIDER }) setShowUseGPT4Confirm(false) }} onCancel={() => setShowUseGPT4Confirm(false)} @@ -1086,7 +1086,7 @@ const Configuration: FC = () => { setShowAccountSettingModal({ payload: ACCOUNT_SETTING_TAB.PROVIDER })} + onSetting={() => setShowAccountSettingModal({ payload: ACCOUNT_SETTING_TAB.MODEL_PROVIDER })} inputs={inputs} modelParameterParams={{ setModel: setModel as any, diff --git a/web/app/components/app/overview/apikey-info-panel/cloud.spec.tsx b/web/app/components/app/overview/apikey-info-panel/cloud.spec.tsx index 06dc534cbb..98a9ddf30b 100644 --- a/web/app/components/app/overview/apikey-info-panel/cloud.spec.tsx +++ b/web/app/components/app/overview/apikey-info-panel/cloud.spec.tsx @@ -81,7 +81,7 @@ describe('APIKeyInfoPanel - Cloud Edition', () => { interactions.clickMainButton() expect(mockSetShowAccountSettingModal).toHaveBeenCalledWith({ - payload: ACCOUNT_SETTING_TAB.PROVIDER, + payload: ACCOUNT_SETTING_TAB.MODEL_PROVIDER, }) }) diff --git a/web/app/components/app/overview/apikey-info-panel/index.spec.tsx b/web/app/components/app/overview/apikey-info-panel/index.spec.tsx index 3f50f7283d..94d423e07c 100644 --- a/web/app/components/app/overview/apikey-info-panel/index.spec.tsx +++ b/web/app/components/app/overview/apikey-info-panel/index.spec.tsx @@ -94,7 +94,7 @@ describe('APIKeyInfoPanel - Community Edition', () => { interactions.clickMainButton() expect(mockSetShowAccountSettingModal).toHaveBeenCalledWith({ - payload: ACCOUNT_SETTING_TAB.PROVIDER, + payload: ACCOUNT_SETTING_TAB.MODEL_PROVIDER, }) }) diff --git a/web/app/components/app/overview/apikey-info-panel/index.tsx b/web/app/components/app/overview/apikey-info-panel/index.tsx index 078386d4a9..d3fabc2776 100644 --- a/web/app/components/app/overview/apikey-info-panel/index.tsx +++ b/web/app/components/app/overview/apikey-info-panel/index.tsx @@ -49,7 +49,7 @@ const APIKeyInfoPanel: FC = () => {
diff --git a/web/app/components/datasets/create/index.tsx b/web/app/components/datasets/create/index.tsx index a028bc0775..7ff260a56f 100644 --- a/web/app/components/datasets/create/index.tsx +++ b/web/app/components/datasets/create/index.tsx @@ -145,7 +145,7 @@ const DatasetUpdateForm = ({ datasetId }: DatasetUpdateFormProps) => { {(step === 2 && (!datasetId || (datasetId && !!datasetDetail))) && ( setShowAccountSettingModal({ payload: ACCOUNT_SETTING_TAB.PROVIDER })} + onSetting={() => setShowAccountSettingModal({ payload: ACCOUNT_SETTING_TAB.MODEL_PROVIDER })} indexingType={datasetDetail?.indexing_technique} datasetId={datasetId} dataSourceType={dataSourceType} diff --git a/web/app/components/datasets/documents/detail/settings/document-settings.tsx b/web/app/components/datasets/documents/detail/settings/document-settings.tsx index 0d10f8a51e..fd69140cb3 100644 --- a/web/app/components/datasets/documents/detail/settings/document-settings.tsx +++ b/web/app/components/datasets/documents/detail/settings/document-settings.tsx @@ -19,6 +19,7 @@ import AppUnavailable from '@/app/components/base/app-unavailable' import Loading from '@/app/components/base/loading' import StepTwo from '@/app/components/datasets/create/step-two' import AccountSetting from '@/app/components/header/account-setting' +import { ACCOUNT_SETTING_TAB } from '@/app/components/header/account-setting/constants' import { ModelTypeEnum } from '@/app/components/header/account-setting/model-provider-page/declarations' import { useDefaultModel } from '@/app/components/header/account-setting/model-provider-page/hooks' import DatasetDetailContext from '@/context/dataset-detail' @@ -155,7 +156,7 @@ const DocumentSettings = ({ datasetId, documentId }: DocumentSettingsProps) => { {isShowSetAPIKey && ( { hideSetAPIkey() }} diff --git a/web/app/components/header/account-setting/constants.ts b/web/app/components/header/account-setting/constants.ts index dbc0b97041..f9cff47aad 100644 --- a/web/app/components/header/account-setting/constants.ts +++ b/web/app/components/header/account-setting/constants.ts @@ -2,7 +2,7 @@ export const ACCOUNT_SETTING_MODAL_ACTION = 'showSettings' export const ACCOUNT_SETTING_TAB = { SANDBOX_PROVIDER: 'sandbox-provider', - PROVIDER: 'provider', + MODEL_PROVIDER: 'model-provider', MEMBERS: 'members', BILLING: 'billing', DATA_SOURCE: 'data-source', diff --git a/web/app/components/header/account-setting/index.tsx b/web/app/components/header/account-setting/index.tsx index 31973ef29b..379b20c67b 100644 --- a/web/app/components/header/account-setting/index.tsx +++ b/web/app/components/header/account-setting/index.tsx @@ -77,7 +77,7 @@ export default function AccountSetting({ const items: GroupItem[] = [ { - key: ACCOUNT_SETTING_TAB.PROVIDER, + key: ACCOUNT_SETTING_TAB.MODEL_PROVIDER, name: t('settings.provider', { ns: 'common' }), icon: , activeIcon: , @@ -234,7 +234,7 @@ export default function AccountSetting({
{activeItem?.description}
)} - {activeItem?.key === 'provider' && ( + {activeItem?.key === ACCOUNT_SETTING_TAB.MODEL_PROVIDER && (
- {activeMenu === 'provider' && } + {activeMenu === ACCOUNT_SETTING_TAB.MODEL_PROVIDER && } {activeMenu === 'sandbox-provider' && } {activeMenu === 'members' && } {activeMenu === 'billing' && } diff --git a/web/app/components/header/account-setting/model-provider-page/model-selector/popup.tsx b/web/app/components/header/account-setting/model-provider-page/model-selector/popup.tsx index 93446e1a36..b89b55bb03 100644 --- a/web/app/components/header/account-setting/model-provider-page/model-selector/popup.tsx +++ b/web/app/components/header/account-setting/model-provider-page/model-selector/popup.tsx @@ -134,7 +134,7 @@ const Popup: FC = ({ className="sticky bottom-0 flex cursor-pointer items-center rounded-b-lg border-t border-divider-subtle bg-components-panel-bg px-4 py-2 text-text-accent-light-mode-only" onClick={() => { onHide() - setShowAccountSettingModal({ payload: ACCOUNT_SETTING_TAB.PROVIDER }) + setShowAccountSettingModal({ payload: ACCOUNT_SETTING_TAB.MODEL_PROVIDER }) }} > {t('model.settingsLink', { ns: 'common' })}