mirror of
https://github.com/langgenius/dify.git
synced 2026-02-10 13:04:25 +08:00
4a9b74f86b
**Problem:**
The telemetry system had unnecessary abstraction layers and bad practices
from the last 3 commits introducing the gateway implementation:
- TelemetryFacade class wrapper around emit() function
- String literals instead of SignalType enum
- Dictionary mapping enum → string instead of enum → enum
- Unnecessary ENTERPRISE_TELEMETRY_GATEWAY_ENABLED feature flag
- Duplicate guard checks scattered across files
- Non-thread-safe TelemetryGateway singleton pattern
- Missing guard in ops_trace_task.py causing RuntimeError spam
**Solution:**
1. Deleted TelemetryFacade - replaced with thin emit() function in core/telemetry/__init__.py
2. Added SignalType enum ('trace' | 'metric_log') to enterprise/telemetry/contracts.py
3. Replaced CASE_TO_TRACE_TASK_NAME dict with CASE_TO_TRACE_TASK: dict[TelemetryCase, TraceTaskName]
4. Deleted is_gateway_enabled() and _emit_legacy() - using existing ENTERPRISE_ENABLED + ENTERPRISE_TELEMETRY_ENABLED instead
5. Extracted _should_drop_ee_only_event() helper to eliminate duplicate checks
6. Moved TelemetryGateway singleton to ext_enterprise_telemetry.py:
- Init once in init_app() for thread-safety
- Access via get_gateway() function
7. Re-added guard to ops_trace_task.py to prevent RuntimeError when EE=OFF but CE tracing enabled
8. Updated 11 caller files to import 'emit as telemetry_emit' instead of 'TelemetryFacade'
**Result:**
- 322 net lines deleted (533 removed, 211 added)
- All 91 tests pass
- Thread-safe singleton pattern
- Cleaner API surface: from TelemetryFacade.emit() to telemetry_emit()
- Proper enum usage throughout
- No RuntimeError spam in EE=OFF + CE=ON scenario
53 lines
1.7 KiB
Python
53 lines
1.7 KiB
Python
"""Celery worker for enterprise metric/log telemetry events.
|
|
|
|
This module defines the Celery task that processes telemetry envelopes
|
|
from the enterprise_telemetry queue. It deserializes envelopes and
|
|
dispatches them to the EnterpriseMetricHandler.
|
|
"""
|
|
|
|
import json
|
|
import logging
|
|
|
|
from celery import shared_task
|
|
|
|
from enterprise.telemetry.contracts import TelemetryEnvelope
|
|
from enterprise.telemetry.metric_handler import EnterpriseMetricHandler
|
|
|
|
logger = logging.getLogger(__name__)
|
|
|
|
|
|
@shared_task(queue="enterprise_telemetry")
|
|
def process_enterprise_telemetry(envelope_json: str) -> None:
|
|
"""Process enterprise metric/log telemetry envelope.
|
|
|
|
This task is enqueued by the TelemetryGateway for metric/log-only
|
|
events. It deserializes the envelope and dispatches to the handler.
|
|
|
|
Best-effort processing: logs errors but never raises, to avoid
|
|
failing user requests due to telemetry issues.
|
|
|
|
Args:
|
|
envelope_json: JSON-serialized TelemetryEnvelope.
|
|
"""
|
|
try:
|
|
# Deserialize envelope
|
|
envelope_dict = json.loads(envelope_json)
|
|
envelope = TelemetryEnvelope.model_validate(envelope_dict)
|
|
|
|
# Process through handler
|
|
handler = EnterpriseMetricHandler()
|
|
handler.handle(envelope)
|
|
|
|
logger.debug(
|
|
"Successfully processed telemetry envelope: tenant_id=%s, event_id=%s, case=%s",
|
|
envelope.tenant_id,
|
|
envelope.event_id,
|
|
envelope.case,
|
|
)
|
|
except Exception:
|
|
# Best-effort: log and drop on error, never fail user request
|
|
logger.warning(
|
|
"Failed to process enterprise telemetry envelope, dropping event",
|
|
exc_info=True,
|
|
)
|