mirror of
https://github.com/langgenius/dify.git
synced 2026-02-10 21:14:25 +08:00
adadf1ec5f
Changes: - Change TelemetryEvent.name from str to TraceTaskName enum for type safety - Remove hardcoded trace_task_name_map from facade (no mapping needed) - Add centralized enterprise-only filter in TelemetryFacade.emit() - Rename is_telemetry_enabled() to is_enterprise_telemetry_enabled() - Update all 11 call sites to pass TraceTaskName enum values - Remove redundant enterprise guard from draft_trace.py - Add unit tests for TelemetryFacade.emit() routing (6 tests) - Add unit tests for TraceQueueManager telemetry guard (5 tests) - Fix test fixture scoping issue for full test suite compatibility - Fix tenant_id handling in agent tool callback handler Benefits: - 100% type-safe: basedpyright catches errors at compile time - No string literals: eliminates entire class of typo bugs - Single point of control: centralized filtering in facade - All guards removed except facade - Zero regressions: 4887 tests passing Verification: - make lint: PASS - make type-check: PASS (0 errors, 0 warnings) - pytest: 4887 passed, 8 skipped
51 lines
1.4 KiB
Python
51 lines
1.4 KiB
Python
from __future__ import annotations
|
|
|
|
from typing import TYPE_CHECKING
|
|
|
|
from core.ops.entities.trace_entity import TraceTaskName
|
|
from core.telemetry.events import TelemetryEvent
|
|
|
|
if TYPE_CHECKING:
|
|
from core.ops.ops_trace_manager import TraceQueueManager
|
|
|
|
_ENTERPRISE_ONLY_TRACES: frozenset[TraceTaskName] = frozenset(
|
|
{
|
|
TraceTaskName.DRAFT_NODE_EXECUTION_TRACE,
|
|
TraceTaskName.NODE_EXECUTION_TRACE,
|
|
TraceTaskName.PROMPT_GENERATION_TRACE,
|
|
}
|
|
)
|
|
|
|
|
|
class TelemetryFacade:
|
|
@staticmethod
|
|
def emit(event: TelemetryEvent, trace_manager: TraceQueueManager | None = None) -> None:
|
|
from core.ops.ops_trace_manager import TraceQueueManager, TraceTask
|
|
|
|
if event.name not in _ENTERPRISE_ONLY_TRACES:
|
|
return
|
|
|
|
trace_queue_manager = trace_manager or TraceQueueManager(
|
|
app_id=event.context.app_id,
|
|
user_id=event.context.user_id,
|
|
)
|
|
trace_queue_manager.add_trace_task(
|
|
TraceTask(
|
|
event.name,
|
|
**event.payload,
|
|
)
|
|
)
|
|
|
|
|
|
def is_enterprise_telemetry_enabled() -> bool:
|
|
try:
|
|
from enterprise.telemetry.exporter import is_enterprise_telemetry_enabled
|
|
except Exception:
|
|
return False
|
|
|
|
return is_enterprise_telemetry_enabled()
|
|
|
|
|
|
def emit(event: TelemetryEvent, trace_manager: TraceQueueManager | None = None) -> None:
|
|
TelemetryFacade.emit(event, trace_manager=trace_manager)
|