From da46e59cbf899282a70eb48a3502f7811e9ede29 Mon Sep 17 00:00:00 2001 From: Georgi Gerganov Date: Wed, 8 Jul 2026 10:00:03 +0300 Subject: [PATCH] llama-eval : fix crash when answer is None in HTML dump (#25435) dict.get("key", default) returns None (not default) when the key exists but its value is explicitly None. This caused an AttributeError in _escape_html() when a task errored before grading and answer was set to None. Assisted-by: pi:llama.cpp/Qwen3.6-27B --- examples/llama-eval/llama-eval.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/llama-eval/llama-eval.py b/examples/llama-eval/llama-eval.py index 4bdd239c00..61bdbddd8b 100755 --- a/examples/llama-eval/llama-eval.py +++ b/examples/llama-eval/llama-eval.py @@ -362,7 +362,7 @@ class EvalState: case = cases.get(task_id, {}) status = case.get("status", "pending") expected = case.get("expected", "") - answer = case.get("answer", "") if status == "ok" else "" + answer = case.get("answer") or "" if status == "ok" else "" is_correct = case.get("correct", False) if status == "ok" else False response = case.get("response", "") or "" prompt = case.get("prompt", "") or "" @@ -647,7 +647,7 @@ class EvalState: question, prompt, expected = self.get_case(i) case = cases.get(task_id, {}) status = case.get("status", "pending") - answer = case.get("answer", "N/A") if status == "ok" else "N/A" + answer = case.get("answer") or "N/A" if status == "ok" else "N/A" tokens = case.get("tokens") tokens_str = str(tokens) if tokens is not None else "N/A" tps_gen = case.get("tps_gen")