From ae98985f5599617be94042f4aa3637d10014ce89 Mon Sep 17 00:00:00 2001 From: Marcin Malagowski Date: Mon, 9 Feb 2026 15:10:55 +0200 Subject: [PATCH 1/3] Fix Clang compilation errors with VLA initialization Signed-off-by: David Addison --- src/common.cu | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/common.cu b/src/common.cu index f7a3f28..c54684e 100644 --- a/src/common.cu +++ b/src/common.cu @@ -1344,8 +1344,10 @@ testResult_t run() { #if NCCL_VERSION_CODE >= NCCL_VERSION(2,28,0) ncclDevComm devComms[nThreads*nGpus]; #endif - int64_t initGpuMem[nThreads] = {0}; - int64_t bufferMemory[nThreads] = {0}; + int64_t initGpuMem[nThreads]; + int64_t bufferMemory[nThreads]; + memset(initGpuMem, 0, sizeof(initGpuMem)); + memset(bufferMemory, 0, sizeof(bufferMemory)); if (!parallel_init) { // Capture the memory used by the GPUs before initializing the NCCL communicators int64_t* initFreeGpuMem = (int64_t*)calloc(nGpus*3, sizeof(int64_t)); From db221defdb74de5becf90ac9809036d614500ccd Mon Sep 17 00:00:00 2001 From: Ahsan Pervaiz Date: Tue, 3 Mar 2026 14:05:52 -0800 Subject: [PATCH 2/3] Request GIN to be explicitly enabled in all to all test Based on the changes in NCCL v2.29.3, update the alltoall test to either provide a ginConnectionType or set ginForceEnable to true. Signed-off-by: Ahsan Pervaiz --- src/alltoall.cu | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/alltoall.cu b/src/alltoall.cu index f354e26..75aaf96 100644 --- a/src/alltoall.cu +++ b/src/alltoall.cu @@ -69,6 +69,11 @@ testResult_t AlltoAllGetDevCommRequirements(int deviceImpl, ncclDevCommRequireme } reqs->barrierCount = deviceCtaCount; reqs->ginSignalCount = deviceCtaCount; +#if NCCL_VERSION_CODE >= NCCL_VERSION(2, 29, 7) + reqs->ginConnectionType = NCCL_GIN_CONNECTION_FULL; +#else + reqs->ginForceEnable = true; +#endif return testSuccess; default: return testNotImplemented; From c379e19a711e011f2086b0001deb3d590e4b46f4 Mon Sep 17 00:00:00 2001 From: David Addison Date: Thu, 5 Mar 2026 15:35:13 -0800 Subject: [PATCH 3/3] NCCL_TESTS_VERSION 2.17.10 --- src/common.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/common.h b/src/common.h index 26b323e..21e33c4 100644 --- a/src/common.h +++ b/src/common.h @@ -6,7 +6,7 @@ #ifndef __COMMON_H__ #define __COMMON_H__ -#define NCCL_TESTS_VERSION "2.17.9" +#define NCCL_TESTS_VERSION "2.17.10" #include "nccl.h" #if NCCL_VERSION_CODE >= NCCL_VERSION(2,28,0)