Amaan UllahandBryan Beverly
4673a75b80
* upgrade golangci-lint * upgrade golangci-lint to v2 via go tool and align local/CI lint configuration * pinned version script for local/CI parity * resolve golangci-lint binary via GOPATH to avoid PATH shadowing * use golangci-lint-action@v7 in CI with prebuilt binary to avoid Go 1.25 toolchain fetch while restricting make lint command to same version as CI * incorporate feedback - extract exact semantic version - check system path first before GOPATH/bin to avoid potential duplication * Add cross-reference comments for lint version/args sync Made-with: Cursor --------- Co-authored-by: Bryan Beverly <[email protected]>
34 lines
1.4 KiB
Bash
Executable File
34 lines
1.4 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
set -euo pipefail
|
|
|
|
# NOTE: Version and args must match .github/workflows/lint.yml
|
|
GOLANGCI_LINT_VERSION="v2.11.4"
|
|
|
|
# TODO: Re-enable errcheck and staticcheck once pre-existing issues are resolved.
|
|
LINT_ARGS="--disable errcheck,staticcheck --enable bodyclose,copyloopvar,misspell --timeout 10m"
|
|
|
|
GOBIN="$(go env GOPATH)/bin"
|
|
GOLANGCI_LINT="${GOBIN}/golangci-lint"
|
|
|
|
# Extract and compare the exact version to avoid substring matches (e.g. 2.11.4 matching 2.11.40).
|
|
check_version() {
|
|
local bin="$1"
|
|
local installed
|
|
installed=$("${bin}" version 2>&1 | grep -oE '[0-9]+\.[0-9]+\.[0-9]+' | head -1)
|
|
[[ "${installed}" == "${GOLANGCI_LINT_VERSION#v}" ]]
|
|
}
|
|
|
|
# Check PATH first, then fall back to GOPATH/bin, otherwise install.
|
|
if command -v golangci-lint &>/dev/null && check_version "$(command -v golangci-lint)"; then
|
|
GOLANGCI_LINT="$(command -v golangci-lint)"
|
|
echo "golangci-lint ${GOLANGCI_LINT_VERSION} found at ${GOLANGCI_LINT}"
|
|
elif [[ -x "${GOLANGCI_LINT}" ]] && check_version "${GOLANGCI_LINT}"; then
|
|
echo "golangci-lint ${GOLANGCI_LINT_VERSION} found at ${GOLANGCI_LINT}"
|
|
else
|
|
echo "Installing golangci-lint ${GOLANGCI_LINT_VERSION}..."
|
|
curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/HEAD/install.sh | sh -s -- -b "${GOBIN}" "${GOLANGCI_LINT_VERSION}"
|
|
fi
|
|
|
|
# shellcheck disable=SC2086
|
|
"${GOLANGCI_LINT}" run ${LINT_ARGS}
|