Mbed-TLS/mbedtls
1
0
Fork 0
mirror of https://github.com/Mbed-TLS/mbedtls.git synced 2026-08-26 04:59:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

ssl_parse_signature_algorithm: match error codes

Browse Source 
The caller is returning MBEDTLS_ERR_SSL_ILLEGAL_PARAMETER if
ssl_parse_signature_algorithm() fails, but
ssl_parse_signature_algorithm() returns
MBEDTLS_ERR_SSL_HANDSHAKE_FAILURE upon failure. There is no good reason
for this mismatch and better to be aligned.

Signed-off-by: Janos Follath <[email protected]>
This commit is contained in:
Janos Follath
2026-03-16 12:28:36 +00:00
parent 862c191f4f
commit 7b255e3a12
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
library/ssl_tls12_client.c
+5 -5
View File
@@ -1749,7 +1749,7 @@ static int ssl_parse_signature_algorithm(mbedtls_ssl_context *ssl,
*/
if (*md_alg == MBEDTLS_MD_NONE) {
MBEDTLS_SSL_DEBUG_MSG(1, ("Server used unsupported HashAlgorithm %d", sig_alg >> 8));
return MBEDTLS_ERR_SSL_HANDSHAKE_FAILURE;
return MBEDTLS_SSL_ALERT_MSG_ILLEGAL_PARAMETER;
}
/*
@@ -1758,14 +1758,14 @@ static int ssl_parse_signature_algorithm(mbedtls_ssl_context *ssl,
if (*pk_alg == MBEDTLS_PK_SIGALG_NONE) {
MBEDTLS_SSL_DEBUG_MSG(1,
("Server used unsupported SignatureAlgorithm %d", sig_alg & 0x00FF));
return MBEDTLS_ERR_SSL_HANDSHAKE_FAILURE;
return MBEDTLS_SSL_ALERT_MSG_ILLEGAL_PARAMETER;
}
/*
* This shouldn't happen, but be robust.
*/
MBEDTLS_SSL_DEBUG_MSG(1, ("Server used unsupported value in SigAlg extension %d", sig_alg));
return MBEDTLS_ERR_SSL_HANDSHAKE_FAILURE;
return MBEDTLS_SSL_ALERT_MSG_ILLEGAL_PARAMETER;
}
/*
@@ -1774,7 +1774,7 @@ static int ssl_parse_signature_algorithm(mbedtls_ssl_context *ssl,
*/
if (!mbedtls_ssl_sig_alg_is_supported(ssl, sig_alg)) {
MBEDTLS_SSL_DEBUG_MSG(1, ("Server used unsupported value in SigAlg extension %d", sig_alg));
return MBEDTLS_ERR_SSL_HANDSHAKE_FAILURE;
return MBEDTLS_SSL_ALERT_MSG_ILLEGAL_PARAMETER;
}
/*
@@ -1782,7 +1782,7 @@ static int ssl_parse_signature_algorithm(mbedtls_ssl_context *ssl,
*/
if (!mbedtls_ssl_sig_alg_is_offered(ssl, sig_alg)) {
MBEDTLS_SSL_DEBUG_MSG(1, ("Server used SigAlg value %d that was not offered", sig_alg));
return MBEDTLS_ERR_SSL_HANDSHAKE_FAILURE;
return MBEDTLS_SSL_ALERT_MSG_ILLEGAL_PARAMETER;
}
MBEDTLS_SSL_DEBUG_MSG(2, ("Server used SignatureAlgorithm %d", sig_alg & 0x00FF));