espressif/esp-nimble
1
0
Fork 0
mirror of https://github.com/espressif/esp-nimble.git synced 2026-08-31 06:10:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

apps/btshell: fix build on 'native' bsp

Browse Source 
strl* methods are not always available, let's use snprintf()
for string copy/concat actions in parse_dev_addr, as it allows
us to keep buffer overflow control and NULL termination of string.
This commit is contained in:
Krzysztof Kopyściński
2022-01-18 08:02:37 +01:00
committed by Krzysztof Kopyściński
parent 7e368a9e16
commit 567855623b
1 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/btshell/src/cmd.c
+9 -4
View File
@@ -98,16 +98,19 @@ parse_dev_addr(const char *prefix, const struct kv_pair *addr_types,
{
char name[32];
int rc;
int written = 0;
if (!prefix) {
name[0] = '\0';
} else {
if (strlcpy(name, prefix, sizeof(name)) >= sizeof(name)) {
written = snprintf(name, sizeof(name) - 1, "%s", prefix);
if (written >= sizeof(name) || written < 0) {
return EINVAL;
}
}
if (strlcat(name, "addr", sizeof(name)) >= sizeof(name)) {
written = snprintf(name + written, sizeof(name) - written - 1, "%s", "addr");
if (written >= sizeof(name) || written < 0) {
return EINVAL;
}
rc = parse_arg_addr(name, addr);
@@ -116,7 +119,8 @@ parse_dev_addr(const char *prefix, const struct kv_pair *addr_types,
return rc;
} else if (rc == EAGAIN) {
/* address found, but no type provided */
if (strlcat(name, "_type", sizeof(name)) >= sizeof(name)) {
written = snprintf(name + written, sizeof(name) - written - 1, "%s", "_type");
if (written >= sizeof(name) || written < 0) {
return EINVAL;
}
addr->type = parse_arg_kv(name, addr_types, &rc);
@@ -130,7 +134,8 @@ parse_dev_addr(const char *prefix, const struct kv_pair *addr_types,
return rc;
} else {
/* full address found, but let's just make sure there is no type arg */
if (strlcat(name, "_type", sizeof(name)) >= sizeof(name)) {
written = snprintf(name + written, sizeof(name) - written, "%s", "_type");
if (written >= sizeof(name) || written < 0) {
return EINVAL;
}
if (parse_arg_extract(name)) {