espressif/esp-nimble
1
0
Fork 0
mirror of https://github.com/espressif/esp-nimble.git synced 2026-10-11 00:37:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

Removing use of undefined TASKS_START behavior

Browse Source 
Tested using the bleprph app. The problem was that the behavior of the RNG TASKS_START is defined to be write only. Reading from it is undefined and though it might have worked up until now doesn't mean it'll constantly work. I was only able to catch on to this using an emulator.

X-Original-Commit: fc0da53f8abedb1c7fce4e35ee565e310e971fdb
This commit is contained in:
Jonathan Seroussi
2017-10-19 17:04:48 +02:00
committed by Andrzej Kaczmarek
parent c4f80cc254
commit 6400747699
1 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
nimble/drivers/nrf52/src/ble_hw.c
+4 -6
View File
@@ -344,13 +344,11 @@ ble_hw_rng_start(void)
/* No need for interrupt if there is no callback */
OS_ENTER_CRITICAL(sr);
if (NRF_RNG->TASKS_START == 0) {
NRF_RNG->EVENTS_VALRDY = 0;
if (g_ble_rng_isr_cb) {
NRF_RNG->INTENSET = 1;
}
NRF_RNG->TASKS_START = 1;
NRF_RNG->EVENTS_VALRDY = 0;
if (g_ble_rng_isr_cb) {
NRF_RNG->INTENSET = 1;
}
NRF_RNG->TASKS_START = 1;
OS_EXIT_CRITICAL(sr);
return 0;