espressif/esp-nimble
1
0
Fork 0
mirror of https://github.com/espressif/esp-nimble.git synced 2026-07-28 21:57:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

nimble/iso: Fix potential memory leak

Browse Source 
This fixes potential BIG memory leak in case ble_hs_hci_cmd_tx returned
an error.
If the error is returned, the code will free the allocated BIG and
BISes.
This commit is contained in:
Mariusz Skamra
2024-03-06 13:41:51 +01:00
committed by Szymon Janc
parent f901dfa0c2
commit 75b35adb69
1 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
nimble/host/src/ble_iso.c
+10 -4
View File
@@ -233,6 +233,7 @@ ble_iso_create_big(const struct ble_iso_create_big_params *create_params,
{
struct ble_hci_le_create_big_cp cp = { 0 };
struct ble_iso_big *big;
int rc;
cp.adv_handle = create_params->adv_handle;
if (create_params->bis_cnt > MYNEWT_VAL(BLE_ISO_MAX_BISES)) {
@@ -272,11 +273,16 @@ ble_iso_create_big(const struct ble_iso_create_big_params *create_params,
memcpy(cp.broadcast_code, big_params->broadcast_code, 16);
}
*big_handle = big->handle;
rc = ble_hs_hci_cmd_tx(BLE_HCI_OP(BLE_HCI_OGF_LE,
BLE_HCI_OCF_LE_CREATE_BIG),
&cp, sizeof(cp),NULL, 0);
if (rc != 0) {
ble_iso_big_free(big);
} else {
*big_handle = big->handle;
}
return ble_hs_hci_cmd_tx(BLE_HCI_OP(BLE_HCI_OGF_LE,
BLE_HCI_OCF_LE_CREATE_BIG),
&cp, sizeof(cp),NULL, 0);
return rc;
}
int