espressif/esp-nimble
1
0
Fork 0
mirror of https://github.com/espressif/esp-nimble.git synced 2026-09-22 00:47:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

nimble/host: Remove spurious conn-update callback

Browse Source 
The GAP callback was incorrectly being called with an event type of
BLE_GAP_EVENT_CONN_UPDATE each time a connection was terminated.  For
example, a typical disconnect event might look like this in the log:

    023276 [ts=181843696us, mod=82 level=1] connection update; rc=531
    023277 [ts=181921816us, mod=82 level=1] disconnect; reason=531

In most cases, only the second line should be present.  The "connection
update" event should only be signaled on termination if an update
procedure for the connection happened to be in progress at the time.
In that case, the connection termination causes the update procedure to
fail.
This commit is contained in:
Christopher Collins
2018-08-14 15:29:28 -07:00
parent 019c7cf0d9
commit 774db595f9
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
nimble/host/src/ble_gap.c
+4 -2
View File
@@ -1004,8 +1004,10 @@ ble_gap_conn_broken(uint16_t conn_handle, int reason)
entry = ble_gap_update_entry_remove(conn_handle);
ble_hs_unlock();
ble_gap_update_notify(conn_handle, reason);
ble_gap_update_entry_free(entry);
if (entry != NULL) {
ble_gap_update_notify(conn_handle, reason);
ble_gap_update_entry_free(entry);
}
/* Indicate the connection termination to each module. The order matters
* here: gatts must come before gattc to ensure the application does not