espressif/esp-nimble
1
0
Fork 0
mirror of https://github.com/espressif/esp-nimble.git synced 2026-10-18 11:17:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

nimble/ll: Fix encryption start procedure

Browse Source 
We need to update rx packet counter and direction bit after sending
LL_START_ENC_RSP in central role as otherwise we will fail to decrypt
LL_START_ENC_RSP from peripheral and will drop connection due to MIC
failure.

This only happens if peripheral replies with LL_START_ENC_RSP in the
next slot after we send LL_START_ENC_RSP. If peripheral replies with an
empty PDU instead, we will update direction bit on continuation and
decryption on rx will be successful.
This commit is contained in:
Andrzej Kaczmarek
2023-05-23 17:00:41 +02:00
parent a38655bb4a
commit a60ee37b8f
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
nimble/controller/src/ble_ll_conn.c
+3
View File
@@ -1372,6 +1372,9 @@ conn_tx_pdu:
ble_phy_encrypt_iv_set(connsm->enc_data.iv);
ble_phy_encrypt_counter_set(connsm->enc_data.tx_pkt_cntr,
CONN_IS_CENTRAL(connsm));
if (txend_func == NULL) {
txend_func = ble_ll_conn_continue_rx_encrypt;
}
} else if (is_ctrl && (opcode == BLE_LL_CTRL_START_ENC_REQ)) {
/*
* Only the peripheral sends this and it gets sent unencrypted but