espressif/esp-nimble
1
0
Fork 0
mirror of https://github.com/espressif/esp-nimble.git synced 2026-10-23 21:09:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

nimble/ll: Fix enabling extended scan with no configuration

Browse Source 
Core Specification 5.3, Vol 4, Part E, 7.8.65:
"If Enable is set to 0x01 and the Host has not issued the
HCI_LE_Set_Extended_Scan_Parameters command, the Controller shall
either use vendor-specified parameters or return the error code
Command Disallowed (0x0C)"

To keep things simple we just reject in such case.

This was affecting HCI/DDI/BV-06-C qualification test case.
This commit is contained in:
Szymon Janc
2022-10-11 21:10:19 +02:00
parent bcd55dde82
commit b353ddc1a4
1 changed files with 21 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
nimble/controller/src/ble_ll_scan.c
+21
View File
@@ -2314,6 +2314,27 @@ ble_ll_scan_set_enable(uint8_t enable, uint8_t filter_dups, uint16_t period,
scansm = &g_ble_ll_scan_sm;
#if MYNEWT_VAL(BLE_LL_CFG_FEAT_LL_EXT_ADV)
if (ext) {
/*
* If Enable is set to 0x01 and the Host has not issued the
* HCI_LE_Set_Extended_Scan_Parameters command, the Controller shall
* either use vendor-specified parameters or return the error code
* Command Disallowed (0x0C)
*
* To keep things simple for devices without public address we
* reject in such case.
*/
for (i = 0; i < BLE_LL_SCAN_PHY_NUMBER; i++) {
if (g_ble_ll_scan_params.scan_phys[i].configured) {
break;
}
}
if (i == BLE_LL_SCAN_PHY_NUMBER) {
return BLE_ERR_CMD_DISALLOWED;
}
}
/* we can do that here since value will never change until reset */
scansm->ext_scanning = ext;