espressif/esp-nimble
1
0
Fork 0
mirror of https://github.com/espressif/esp-nimble.git synced 2026-08-31 22:30:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

nimble/ll: Update DID when enabling or disabling periodic advertising

Browse Source 
The Advertising DID is not required to change when a SyncInfo field is
added to or removed from an advertising set. However, if it does not
change, then scanners may fail to synchronize to periodic advertising
because entries in the Advertising DID cache (see Section 4.3.3) mean
they ignore the advertisements containing the SyncInfo field. Therefore,
advertisers should update the Advertising DID when a periodic advertising
train is enabled. Alternatively, the Host should enable periodic
advertising before enabling advertising.
This commit is contained in:
Szymon Janc
2019-06-18 09:41:46 +02:00
parent e46fdc90e0
commit d447bbc4b4
1 changed files with 23 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
nimble/controller/src/ble_ll_adv.c
+23
View File
@@ -2382,6 +2382,17 @@ ble_ll_adv_sm_start_periodic(struct ble_ll_adv_sm *advsm)
uint32_t usecs;
uint32_t ticks;
/*
* The Advertising DID is not required to change when a SyncInfo field is
* added to or removed from an advertising set. However, if it does not
* change, then scanners may fail to synchronize to periodic advertising
* because entries in the Advertising DID cache (see Section 4.3.3) mean
* they ignore the advertisements containing the SyncInfo field. Therefore,
* advertisers should update the Advertising DID when a periodic advertising
* train is enabled.
*/
ble_ll_adv_update_did(advsm);
advsm->periodic_adv_active = 1;
/* keep channel map since we cannot change it later on */
@@ -2425,6 +2436,18 @@ ble_ll_adv_sm_stop_periodic(struct ble_ll_adv_sm *advsm)
return;
}
/*
* The Advertising DID is not required to change when a SyncInfo field is
* added to or removed from an advertising set. However, if it does not
* change, then scanners may unnecessary try to synchronize to instance that
* no longer has periodic advertising enabled because entries in the
* Advertising DID cache (see Section 4.3.3) mean they ignore the
* advertisements no longer containing the SyncInfo field. Therefore,
* advertisers should update the Advertising DID when a periodic advertising
* train is disabled.
*/
ble_ll_adv_update_did(advsm);
/* Remove any scheduled advertising items */
advsm->periodic_adv_active = 0;
advsm->periodic_sync_active = 0;