[coverage] remove empty functions (#3179)

src/core/Makefile.am

@@ -333,7 +333,6 @@ HEADERS_COMMON                      = \
     thread/network_data.hpp           \
     thread/network_data_leader.hpp    \
     thread/network_data_leader_ftd.hpp \
-    thread/network_data_leader_mtd.hpp \
     thread/network_data_local.hpp     \
     thread/network_data_tlvs.hpp      \
     thread/network_diagnostic.hpp     \

src/core/meshcop/dataset_manager.cpp

@@ -168,15 +168,15 @@ otError DatasetManager::Set(const Dataset &aDataset)
 
     if (isMasterkeyUpdated || compare > 0)
     {
-        ThreadNetif &netif = GetNetif();
-
         mLocal.Set(aDataset);
 
-        if (netif.GetMle().GetRole() == OT_DEVICE_ROLE_LEADER)
+#if OPENTHREAD_FTD
+        if (GetNetif().GetMle().GetRole() == OT_DEVICE_ROLE_LEADER)
         {
-            netif.GetNetworkDataLeader().IncrementVersion();
-            netif.GetNetworkDataLeader().IncrementStableVersion();
+            GetNetif().GetNetworkDataLeader().IncrementVersion();
+            GetNetif().GetNetworkDataLeader().IncrementStableVersion();
         }
+#endif
     }
     else if (compare < 0)
     {

src/core/thread/mesh_forwarder.cpp

@@ -147,10 +147,12 @@ exit:
 
 void MeshForwarder::RemoveMessage(Message &aMessage)
 {
+#if OPENTHREAD_FTD
     for (ChildTable::Iterator iter(GetInstance(), ChildTable::kInStateAnyExceptInvalid); !iter.IsDone(); iter++)
     {
         IgnoreReturnValue(RemoveMessageFromSleepyChild(aMessage, *iter.GetChild()));
     }
+#endif
 
     if (mSendMessage == &aMessage)
     {
@@ -173,10 +175,12 @@ void MeshForwarder::ScheduleTransmissionTask(void)
 
     mSendMessageIsARetransmission = false;
 
+#if OPENTHREAD_FTD
     if (GetIndirectTransmission() == OT_ERROR_NONE)
     {
         ExitNow();
     }
+#endif // OPENTHREAD_FTD
 
     if ((mSendMessage = GetDirectTransmission()) != NULL)
     {
@@ -1045,7 +1049,9 @@ void MeshForwarder::HandleSentFrame(Mac::Frame &aFrame, otError aError)
         }
     }
 
+#if OPENTHREAD_FTD
     HandleSentFrameToChild(aFrame, aError, macDest);
+#endif
 
     VerifyOrExit(mSendMessage != NULL);
 
@@ -1250,7 +1256,9 @@ void MeshForwarder::HandleReceivedFrame(Mac::Frame &aFrame)
         if (payloadLength >= sizeof(Lowpan::MeshHeader) &&
             reinterpret_cast<Lowpan::MeshHeader *>(payload)->IsMeshHeader())
         {
+#if OPENTHREAD_FTD
             HandleMesh(payload, payloadLength, macSource, linkInfo);
+#endif
         }
         else if (payloadLength >= sizeof(Lowpan::FragmentHeader) &&
                  reinterpret_cast<Lowpan::FragmentHeader *>(payload)->IsFragmentHeader())

src/core/thread/mesh_forwarder_mtd.cpp

@@ -71,36 +71,6 @@ exit:
     return error;
 }
 
-otError MeshForwarder::GetIndirectTransmission(void)
-{
-    return OT_ERROR_NOT_FOUND;
-}
-
-otError MeshForwarder::RemoveMessageFromSleepyChild(Message &aMessage, Child &aChild)
-{
-    OT_UNUSED_VARIABLE(aMessage);
-    OT_UNUSED_VARIABLE(aChild);
-    return OT_ERROR_NOT_FOUND;
-}
-
-void MeshForwarder::HandleSentFrameToChild(const Mac::Frame &aFrame, otError aError, const Mac::Address &aMacDest)
-{
-    OT_UNUSED_VARIABLE(aFrame);
-    OT_UNUSED_VARIABLE(aError);
-    OT_UNUSED_VARIABLE(aMacDest);
-}
-
-void MeshForwarder::HandleMesh(uint8_t *               aFrame,
-                               uint8_t                 aFrameLength,
-                               const Mac::Address &    aMacSource,
-                               const otThreadLinkInfo &aLinkInfo)
-{
-    OT_UNUSED_VARIABLE(aFrame);
-    OT_UNUSED_VARIABLE(aFrameLength);
-    OT_UNUSED_VARIABLE(aMacSource);
-    OT_UNUSED_VARIABLE(aLinkInfo);
-}
-
 } // namespace ot
 
 #endif // OPENTHREAD_MTD

src/core/thread/network_data_leader.hpp

@@ -253,7 +253,11 @@ private:
 } // namespace ot
 
 #if OPENTHREAD_MTD
-#include "network_data_leader_mtd.hpp"
+namespace ot {
+namespace NetworkData {
+typedef class LeaderBase Leader;
+} // namespace NetworkData
+} // namespace ot
 #elif OPENTHREAD_FTD
 #include "network_data_leader_ftd.hpp"
 #else

src/core/thread/network_data_leader_mtd.hpp

@@ -1,65 +0,0 @@
-/*
- *  Copyright (c) 2016, The OpenThread Authors.
- *  All rights reserved.
- *
- *  Redistribution and use in source and binary forms, with or without
- *  modification, are permitted provided that the following conditions are met:
- *  1. Redistributions of source code must retain the above copyright
- *     notice, this list of conditions and the following disclaimer.
- *  2. Redistributions in binary form must reproduce the above copyright
- *     notice, this list of conditions and the following disclaimer in the
- *     documentation and/or other materials provided with the distribution.
- *  3. Neither the name of the copyright holder nor the
- *     names of its contributors may be used to endorse or promote products
- *     derived from this software without specific prior written permission.
- *
- *  THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
- *  AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
- *  IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
- *  ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE
- *  LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
- *  CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
- *  SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
- *  INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
- *  CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
- *  ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
- *  POSSIBILITY OF SUCH DAMAGE.
- */
-
-/**
- * @file
- *   This file includes definitions for manipulating Thread Network Data managed by the Thread Leader.
- */
-
-#ifndef NETWORK_DATA_LEADER_MTD_HPP_
-#define NETWORK_DATA_LEADER_MTD_HPP_
-
-#include "openthread-core-config.h"
-
-#include "utils/wrap_stdint.h"
-
-namespace ot {
-
-namespace NetworkData {
-
-class Leader : public LeaderBase
-{
-public:
-    explicit Leader(Instance &aInstance)
-        : LeaderBase(aInstance)
-    {
-    }
-
-    void Start(void) {}
-    void Stop(void) {}
-
-    void IncrementVersion(void) {}
-    void IncrementStableVersion(void) {}
-
-    otError SendServerDataNotification(uint16_t) { return OT_ERROR_NOT_IMPLEMENTED; }
-};
-
-} // namespace NetworkData
-} // namespace ot
-
-#endif // NETWORK_DATA_LEADER_MTD_HPP_