espressif/openthread
1
0
Fork 0
mirror of https://github.com/espressif/openthread.git synced 2026-08-19 00:49:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

[tcp][posix] ensure struct fields are initialized (#11552)

Browse Source 
This aims to fix some instances in core/tcp6 and posix/udp where the
complete struct was not initialized. In otPlatUdpJoinMulticastGroup
and otPlatUdpLeaveMulticastGroup an explicit redundant setting to '0'
is added just for clarity for people reading the code.
This commit is contained in:
Esko Dijk
2025-06-03 08:24:09 -07:00
committed by GitHub
parent 5050bec030
commit 151cf324bc
2 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/core/net/tcp6.cpp
+3
View File
@@ -163,6 +163,7 @@ Error Tcp::Endpoint::Connect(const SockAddr &aSockName, uint32_t aFlags)
struct sockaddr_in6 sin6p;
tp.t_flags &= ~TF_FASTOPEN;
ClearAllBytes(sin6p);
memcpy(&sin6p.sin6_addr, &aSockName.mAddress, sizeof(sin6p.sin6_addr));
sin6p.sin6_port = BigEndian::HostSwap16(aSockName.mPort);
error = BsdErrorToOtError(tcp6_usr_connect(&tp, &sin6p));
@@ -193,6 +194,7 @@ Error Tcp::Endpoint::SendByReference(otLinkedBuffer &aBuffer, uint32_t aFlags)
if (IS_FASTOPEN(tp.t_flags))
{
ClearAllBytes(sin6p);
memcpy(&sin6p.sin6_addr, &tp.faddr, sizeof(sin6p.sin6_addr));
sin6p.sin6_port = tp.fport;
name = &sin6p;
@@ -221,6 +223,7 @@ Error Tcp::Endpoint::SendByExtension(size_t aNumBytes, uint32_t aFlags)
if (IS_FASTOPEN(tp.t_flags))
{
ClearAllBytes(sin6p);
memcpy(&sin6p.sin6_addr, &tp.faddr, sizeof(sin6p.sin6_addr));
sin6p.sin6_port = tp.fport;
name = &sin6p;
src/posix/platform/udp.cpp
+4 -2
View File
@@ -463,7 +463,7 @@ otError otPlatUdpJoinMulticastGroup(otUdpSocket *aUdpSocket,
const otIp6Address *aAddress)
{
otError error = OT_ERROR_NONE;
struct ipv6_mreq mreq;
struct ipv6_mreq mreq = {};
int fd;
VerifyOrExit(aUdpSocket->mHandle != nullptr, error = OT_ERROR_INVALID_ARGS);
@@ -474,6 +474,7 @@ otError otPlatUdpJoinMulticastGroup(otUdpSocket *aUdpSocket,
switch (aNetifIdentifier)
{
case OT_NETIF_UNSPECIFIED:
mreq.ipv6mr_interface = 0; // Explicitly set to 0 to clarify intention.
break;
case OT_NETIF_THREAD_HOST:
mreq.ipv6mr_interface = gNetifIndex;
@@ -506,7 +507,7 @@ otError otPlatUdpLeaveMulticastGroup(otUdpSocket *aUdpSocket,
const otIp6Address *aAddress)
{
otError error = OT_ERROR_NONE;
struct ipv6_mreq mreq;
struct ipv6_mreq mreq = {};
int fd;
VerifyOrExit(aUdpSocket->mHandle != nullptr, error = OT_ERROR_INVALID_ARGS);
@@ -517,6 +518,7 @@ otError otPlatUdpLeaveMulticastGroup(otUdpSocket *aUdpSocket,
switch (aNetifIdentifier)
{
case OT_NETIF_UNSPECIFIED:
mreq.ipv6mr_interface = 0; // Explicitly set to 0 to clarify intention.
break;
case OT_NETIF_THREAD_HOST:
mreq.ipv6mr_interface = gNetifIndex;