espressif/openthread
1
0
Fork 0
mirror of https://github.com/espressif/openthread.git synced 2026-07-30 07:37:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

[spinel-decoder] add extra check to address compiler warnings (#7036)

Browse Source 
This commit updates some of the `SpinelDecoder::Read{Item}()` methods
to initialize their local pointer variables to `nullptr`. Though we
technically do not need this change (since the call to `Read(aPtr)`
will set the pointer value on success), some toolchains cannot infer
this from the code and generate error/warning of "pointer may be
used uninitialized".
This commit is contained in:
Abtin Keshavarzian
2021-09-28 08:19:03 -07:00
committed by GitHub
parent 312e8a630b
commit 1fa7b4dfeb
1 changed files with 15 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/lib/spinel/spinel_decoder.cpp
+15 -10
View File
@@ -231,10 +231,11 @@ exit:
otError Decoder::ReadIp6Address(spinel_ipv6addr_t &aIp6Addr)
{
otError error = OT_ERROR_NONE;
const spinel_ipv6addr_t *ipv6AddrPtr;
otError error = OT_ERROR_NONE;
const spinel_ipv6addr_t *ipv6AddrPtr = nullptr;
SuccessOrExit(error = ReadIp6Address(ipv6AddrPtr));
VerifyOrExit(ipv6AddrPtr != nullptr, error = OT_ERROR_PARSE);
aIp6Addr = *ipv6AddrPtr;
exit:
@@ -243,10 +244,11 @@ exit:
otError Decoder::ReadIp6Address(otIp6Address &aIp6Addr)
{
otError error = OT_ERROR_NONE;
const otIp6Address *ipv6AddrPtr;
otError error = OT_ERROR_NONE;
const otIp6Address *ipv6AddrPtr = nullptr;
SuccessOrExit(error = ReadIp6Address(ipv6AddrPtr));
VerifyOrExit(ipv6AddrPtr != nullptr, error = OT_ERROR_PARSE);
aIp6Addr = *ipv6AddrPtr;
exit:
@@ -255,10 +257,11 @@ exit:
otError Decoder::ReadEui64(spinel_eui64_t &aEui64)
{
otError error = OT_ERROR_NONE;
const spinel_eui64_t *eui64Ptr;
otError error = OT_ERROR_NONE;
const spinel_eui64_t *eui64Ptr = nullptr;
SuccessOrExit(error = ReadEui64(eui64Ptr));
VerifyOrExit(eui64Ptr != nullptr, error = OT_ERROR_PARSE);
aEui64 = *eui64Ptr;
exit:
@@ -267,10 +270,11 @@ exit:
otError Decoder::ReadEui64(otExtAddress &aEui64)
{
otError error = OT_ERROR_NONE;
const otExtAddress *eui64Ptr;
otError error = OT_ERROR_NONE;
const otExtAddress *eui64Ptr = nullptr;
SuccessOrExit(error = ReadEui64(eui64Ptr));
VerifyOrExit(eui64Ptr != nullptr, error = OT_ERROR_PARSE);
aEui64 = *eui64Ptr;
exit:
@@ -279,10 +283,11 @@ exit:
otError Decoder::ReadEui48(spinel_eui48_t &aEui48)
{
otError error = OT_ERROR_NONE;
const spinel_eui48_t *eui48Ptr;
otError error = OT_ERROR_NONE;
const spinel_eui48_t *eui48Ptr = nullptr;
SuccessOrExit(error = ReadEui48(eui48Ptr));
VerifyOrExit(eui48Ptr != nullptr, error = OT_ERROR_PARSE);
aEui48 = *eui48Ptr;
exit: