espressif/openthread
1
0
Fork 0
mirror of https://github.com/espressif/openthread.git synced 2026-08-09 12:17:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

[srp-server] avoid re-accessing committed SRP updates (#6785)

Browse Source 
We should remove the UpdateMetadata before committing the SRP update
to ensure that the same UpdateMetadata (and the Host object) can never
be touched again.
This commit is contained in:
kangping
2021-07-06 11:41:08 -07:00
committed by GitHub
parent 49817fc417
commit 38cb99f0fc
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/core/net/srp_server.cpp
+1 -2
View File
@@ -298,9 +298,8 @@ void Server::HandleServiceUpdateResult(ServiceUpdateId aId, Error aError)
void Server::HandleServiceUpdateResult(UpdateMetadata *aUpdate, Error aError)
{
CommitSrpUpdate(aError, aUpdate->GetDnsHeader(), aUpdate->GetHost(), aUpdate->GetMessageInfo());
IgnoreError(mOutstandingUpdates.Remove(*aUpdate));
CommitSrpUpdate(aError, aUpdate->GetDnsHeader(), aUpdate->GetHost(), aUpdate->GetMessageInfo());
aUpdate->Free();
if (mOutstandingUpdates.IsEmpty())