espressif/openthread
1
0
Fork 0
mirror of https://github.com/espressif/openthread.git synced 2026-08-10 20:57:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

[posix] fix MdnsSocket iteration over message queue (#11599)

Browse Source 
This commit updates how `MdnsSocket::SendQueuedMessages()` iterates
over the message queue. The iteration is changed to get the next
message before processing the current one. This is necessary because
the current message may be dequeued and freed within the loop, which
would invalidate the pointer to the next message.
This commit is contained in:
Abtin Keshavarzian
2025-06-17 13:47:05 +09:00
committed by GitHub
parent aab0c29793
commit 3fd719063f
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/posix/platform/mdns_socket.cpp
+6 -2
View File
@@ -345,6 +345,9 @@ void MdnsSocket::ClearTxQueue(void)
void MdnsSocket::SendQueuedMessages(MsgType aMsgType)
{
otMessage *message;
otMessage *nextMessage;
switch (aMsgType)
{
case kIp6Msg:
@@ -355,8 +358,7 @@ void MdnsSocket::SendQueuedMessages(MsgType aMsgType)
break;
}
for (otMessage *message = otMessageQueueGetHead(&mTxQueue); message != NULL;
message = otMessageQueueGetNext(&mTxQueue, message))
for (message = otMessageQueueGetHead(&mTxQueue); message != NULL; message = nextMessage)
{
bool isTxPending = false;
uint16_t length;
@@ -367,6 +369,8 @@ void MdnsSocket::SendQueuedMessages(MsgType aMsgType)
struct sockaddr_in6 addr6;
struct sockaddr_in addr;
nextMessage = otMessageQueueGetNext(&mTxQueue, message);
length = otMessageGetLength(message);
offset = length - sizeof(Metadata);