espressif/openthread
1
0
Fork 0
mirror of https://github.com/espressif/openthread.git synced 2026-08-22 18:39:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

[coap] avoid div-by-0 error in validating coap params (#4670)

Browse Source
This commit is contained in:
Jonathan Hui
2020-03-11 11:43:28 -07:00
committed by GitHub
parent 653745911f
commit 415c42da57
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/core/coap/coap.cpp
+2 -2
View File
@@ -974,8 +974,8 @@ bool TxParameters::IsValid(void) const
{
bool rval = false;
if (mAckRandomFactorNumerator >= mAckRandomFactorDenominator && mAckTimeout >= OT_COAP_MIN_ACK_TIMEOUT &&
mMaxRetransmit <= OT_COAP_MAX_RETRANSMIT)
if ((mAckRandomFactorDenominator > 0) && (mAckRandomFactorNumerator >= mAckRandomFactorDenominator) &&
(mAckTimeout >= OT_COAP_MIN_ACK_TIMEOUT) && (mMaxRetransmit <= OT_COAP_MAX_RETRANSMIT))
{
// Calulate exchange lifetime step by step and verify no overflow.
uint32_t tmp = Multiply(mAckTimeout, (1U << (mMaxRetransmit + 1)) - 1);