[clang-tidy] google-explicit-constructor (#5734)

script/make-pretty

@@ -116,6 +116,7 @@ readonly OT_CLANG_TIDY_BUILD_OPTS=(
 
 readonly OT_CLANG_TIDY_CHECKS="\
 -*,\
+google-explicit-constructor,\
 google-readability-casting,\
 misc-unused-using-decls,\
 modernize-use-bool-literals,\

src/core/backbone_router/multicast_listeners_table.hpp

@@ -203,7 +203,7 @@ private:
     class IteratorBuilder : InstanceLocator
     {
     public:
-        IteratorBuilder(Instance &aInstance)
+        explicit IteratorBuilder(Instance &aInstance)
             : InstanceLocator(aInstance)
         {
         }

src/core/common/message.hpp

@@ -392,7 +392,7 @@ public:
          *                       security enabled with `kPriorityNormal` priority) would be used.
          *
          */
-        Settings(const otMessageSettings *aSettings);
+        explicit Settings(const otMessageSettings *aSettings);
 
         /**
          * This method gets the message priority.

src/core/common/pool.hpp

@@ -86,7 +86,7 @@ public:
      * @param[in] aInstance   A reference to the OpenThread instance.
      *
      */
-    Pool(Instance &aInstance)
+    explicit Pool(Instance &aInstance)
         : mFreeList()
     {
         for (Type &entry : mPool)

src/core/common/settings.hpp

@@ -1004,7 +1004,7 @@ private:
     class ChildInfoIteratorBuilder : public InstanceLocator
     {
     public:
-        ChildInfoIteratorBuilder(Instance &aInstance)
+        explicit ChildInfoIteratorBuilder(Instance &aInstance)
             : InstanceLocator(aInstance)
         {
         }

src/core/common/time_ticker.hpp

@@ -79,7 +79,7 @@ public:
      * This constructor initializes the `TimeTicker` instance.
      *
      */
-    TimeTicker(Instance &aInstance);
+    explicit TimeTicker(Instance &aInstance);
 
     /**
      * This method registers a receiver with `TimeTicker` to receive periodic ticks.

src/core/common/timer.hpp

@@ -437,7 +437,7 @@ public:
      * @param[in]  aInstance  A reference to the instance object.
      *
      */
-    TimerMicroScheduler(Instance &aInstance)
+    explicit TimerMicroScheduler(Instance &aInstance)
         : TimerScheduler(aInstance)
     {
     }

src/core/net/netif.cpp

@@ -53,7 +53,7 @@ public:
         mIsAnycast    = aInstance.Get<Mle::MleRouter>().IsAnycastLocator(aAddress.GetAddress());
     }
 
-    AddressInfo(const NetifMulticastAddress &aAddress)
+    explicit AddressInfo(const NetifMulticastAddress &aAddress)
     {
         mAddress      = &aAddress.GetAddress();
         mPrefixLength = kMulticastPrefixLength;

src/core/net/netif.hpp

@@ -403,7 +403,7 @@ public:
      * @param[in]  aInstance        A reference to the OpenThread instance.
      *
      */
-    Netif(Instance &aInstance);
+    explicit Netif(Instance &aInstance);
 
     /**
      * This method registers a callback to notify internal IPv6 address changes.

src/core/radio/radio.hpp

@@ -195,7 +195,7 @@ public:
      * @param[in]  aInstance  A reference to the OpenThread instance.
      *
      */
-    Radio(Instance &aInstance)
+    explicit Radio(Instance &aInstance)
         : InstanceLocator(aInstance)
         , mCallbacks(aInstance)
     {

src/core/thread/child_table.hpp

@@ -161,7 +161,7 @@ public:
         bool operator!=(const Iterator &aOther) const { return mChild != aOther.mChild; }
 
     private:
-        Iterator(Instance &aInstance)
+        explicit Iterator(Instance &aInstance)
             : InstanceLocator(aInstance)
             , mFilter(Child::StateFilter::kInStateValid)
             , mChild(nullptr)

src/core/thread/link_metrics.cpp

@@ -313,7 +313,7 @@ otError LinkMetrics::AppendSingleProbeLinkMetricsReport(Message &            aMe
     if (aLinkMetrics.mPduCount)
     {
         metric.Init();
-        metric.SetMetricsTypeId(kTypeIdFlagPdu);
+        metric.SetMetricsTypeId(LinkMetricsTypeIdFlags(kTypeIdFlagPdu));
         metric.SetMetricsValue32(aRequestMessage.GetPsduCount());
         SuccessOrExit(error = aMessage.AppendBytes(&metric, metric.GetSize()));
         aLength += metric.GetSize();
@@ -322,7 +322,7 @@ otError LinkMetrics::AppendSingleProbeLinkMetricsReport(Message &            aMe
     if (aLinkMetrics.mLqi)
     {
         metric.Init();
-        metric.SetMetricsTypeId(kTypeIdFlagLqi);
+        metric.SetMetricsTypeId(LinkMetricsTypeIdFlags(kTypeIdFlagLqi));
         metric.SetMetricsValue8(aRequestMessage.GetAverageLqi()); // IEEE 802.15.4 LQI is in scale 0-255
         SuccessOrExit(error = aMessage.AppendBytes(&metric, metric.GetSize()));
         aLength += metric.GetSize();
@@ -331,7 +331,7 @@ otError LinkMetrics::AppendSingleProbeLinkMetricsReport(Message &            aMe
     if (aLinkMetrics.mLinkMargin)
     {
         metric.Init();
-        metric.SetMetricsTypeId(kTypeIdFlagLinkMargin);
+        metric.SetMetricsTypeId(LinkMetricsTypeIdFlags(kTypeIdFlagLinkMargin));
         metric.SetMetricsValue8(
             LinkQualityInfo::ConvertRssToLinkMargin(Get<Mac::Mac>().GetNoiseFloor(), aRequestMessage.GetAverageRss()) *
             255 / 130); // Linear scale Link Margin from [0, 130] to [0, 255]
@@ -342,7 +342,7 @@ otError LinkMetrics::AppendSingleProbeLinkMetricsReport(Message &            aMe
     if (aLinkMetrics.mRssi)
     {
         metric.Init();
-        metric.SetMetricsTypeId(kTypeIdFlagRssi);
+        metric.SetMetricsTypeId(LinkMetricsTypeIdFlags(kTypeIdFlagRssi));
         metric.SetMetricsValue8((aRequestMessage.GetAverageRss() + 130) * 255 /
                                 130); // Linear scale rss from [-130, 0] to [0, 255]
         SuccessOrExit(error = aMessage.AppendBytes(&metric, metric.GetSize()));

src/core/thread/link_metrics_tlvs.hpp

@@ -88,8 +88,8 @@ public:
      * Constructor for implicit cast from `uint8_t` to `LinkMetricsTypeIdFlags`.
      *
      */
-    LinkMetricsTypeIdFlags(uint8_t typeIdFlags)
-        : mTypeIdFlags(typeIdFlags)
+    explicit LinkMetricsTypeIdFlags(uint8_t aTypeIdFlags)
+        : mTypeIdFlags(aTypeIdFlags)
     {
     }
 

src/core/thread/network_data_notifier.hpp

@@ -61,7 +61,7 @@ public:
      * @param[in] aInstance  The OpenThread instance.
      *
      */
-    Notifier(Instance &aInstance);
+    explicit Notifier(Instance &aInstance);
 
     /**
      * Call this method to inform the notifier that new server data is available.

src/core/thread/router_table.hpp

@@ -417,7 +417,7 @@ private:
     class IteratorBuilder : public InstanceLocator
     {
     public:
-        IteratorBuilder(Instance &aInstance)
+        explicit IteratorBuilder(Instance &aInstance)
             : InstanceLocator(aInstance)
         {
         }

src/core/thread/topology.hpp

@@ -690,7 +690,7 @@ public:
          * @param[in] aFilter   An IPv6 address type filter restricting iterator to certain type of addresses.
          *
          */
-        AddressIterator(const Child &aChild, Ip6::Address::TypeFilter aFilter = Ip6::Address::kTypeAny)
+        explicit AddressIterator(const Child &aChild, Ip6::Address::TypeFilter aFilter = Ip6::Address::kTypeAny)
             : AddressIterator(aChild, 0, aFilter)
         {
         }

src/core/utils/flash.hpp

@@ -53,7 +53,7 @@ public:
      * Constructor.
      *
      */
-    Flash(Instance &aInstance)
+    explicit Flash(Instance &aInstance)
         : InstanceLocator(aInstance)
     {
     }

src/core/utils/lookup_table.hpp

@@ -59,7 +59,7 @@ public:
          * @param[in] aName   The null-terminated name string with which to initialize the entry.
          *
          */
-        constexpr Entry(const char *aName)
+        constexpr explicit Entry(const char *aName)
             : mName(aName)
         {
         }

tests/unit/test_lookup_table.cpp

@@ -41,7 +41,7 @@ typedef ot::Utils::LookupTable::Entry Entry;
 
 struct TableEntryBase
 {
-    constexpr TableEntryBase(uint8_t aValue)
+    constexpr explicit TableEntryBase(uint8_t aValue)
         : mValue(aValue)
     {
     }
@@ -76,8 +76,8 @@ void TestLookupTable(void)
         {"sekiro", 10},     {"tomb raider", 9},   {"uncharted", 9},
     };
 
-    constexpr Entry kUnsortedTable[]       = {{"z"}, {"a"}, {"b"}};
-    constexpr Entry kDuplicateEntryTable[] = {"duplicate", "duplicate"};
+    constexpr Entry kUnsortedTable[]       = {Entry("z"), Entry("a"), Entry("b")};
+    constexpr Entry kDuplicateEntryTable[] = {Entry("duplicate"), Entry("duplicate")};
 
     static_assert(ot::Utils::LookupTable::IsSorted(kTable), "LookupTable::IsSorted() failed");
     static_assert(!ot::Utils::LookupTable::IsSorted(kUnsortedTable),

tests/unit/test_lowpan.hpp

@@ -59,7 +59,7 @@ public:
      * Default constructor for the object.
      *
      */
-    TestIphcVector(const char *aTestName)
+    explicit TestIphcVector(const char *aTestName)
     {
         memset(reinterpret_cast<void *>(this), 0, sizeof(TestIphcVector));
         mTestName              = aTestName;

tests/unit/test_netif.cpp

@@ -44,7 +44,7 @@ namespace ot {
 class TestNetif : public Ip6::Netif
 {
 public:
-    TestNetif(Instance &aInstance)
+    explicit TestNetif(Instance &aInstance)
         : Ip6::Netif(aInstance)
     {
     }

tests/unit/test_timer.cpp

@@ -86,7 +86,7 @@ void InitCounters(void)
 template <typename TimerType> class TestTimer : public TimerType
 {
 public:
-    TestTimer(ot::Instance &aInstance)
+    explicit TestTimer(ot::Instance &aInstance)
         : TimerType(aInstance, TestTimer::HandleTimerFired, nullptr)
         , mFiredCounter(0)
     {