espressif/openthread
1
0
Fork 0
mirror of https://github.com/espressif/openthread.git synced 2026-09-08 02:00:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

[cli] allow executing the factoryreset command when running sync commands (#11106)

Browse Source 
When running the sync command, such as `diag radio receive 10000`, the cli
doesn't allow running other commands before the sync command returns. Which
causes that the sync command may be blocked for a very long time and users
can't do anything to terminate the sync command. This will also cause the
test script to fail to run the second case after running first case fails.

This commit allows the cli to execute the `factoryreset` command when running
the sync command.
This commit is contained in:
Zhanglong Xia
2025-01-13 10:17:38 -08:00
committed by GitHub
parent 7bd3abd67b
commit 4b782d5b77
1 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/cli/cli.cpp
+8 -5
View File
@@ -290,12 +290,15 @@ template <> otError Interpreter::Process<Cmd("reset")>(Arg aArgs[])
void Interpreter::ProcessLine(char *aLine)
{
Arg args[kMaxArgs + 1];
otError error = OT_ERROR_PARSE;
bool shouldOutputResult = true;
static const char kCmdFactoryReset[] = "factoryreset";
Arg args[kMaxArgs + 1];
otError error = OT_ERROR_PARSE;
bool shouldOutputResult = true;
OT_ASSERT(aLine != nullptr);
args[0].Clear();
// Validate and parse the input command line. The `error` is
// checked later after other conditions are handled.
@@ -317,7 +320,7 @@ void Interpreter::ProcessLine(char *aLine)
ExitNow();
}
if (mCommandIsPending)
if (mCommandIsPending && (args[0] != kCmdFactoryReset))
{
// If a previous command is still pending, ignore the new
// command (even if there is a parse error). We do not
@@ -347,7 +350,7 @@ void Interpreter::ProcessLine(char *aLine)
LogInput(args);
#if OPENTHREAD_CONFIG_DIAG_ENABLE
if (otDiagIsEnabled(GetInstancePtr()) && (args[0] != "diag") && (args[0] != "factoryreset"))
if (otDiagIsEnabled(GetInstancePtr()) && (args[0] != "diag") && (args[0] != kCmdFactoryReset))
{
OutputLine("under diagnostics mode, execute 'diag stop' before running any other commands.");
ExitNow(error = OT_ERROR_INVALID_STATE);