espressif/openthread
1
0
Fork 0
mirror of https://github.com/espressif/openthread.git synced 2026-10-10 17:57:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

[posix] fix logging of netlink errors (#9287)

Browse Source 
This commit fixes the netlink ACK error logging by extracting error
messages from the `NLMSGERR_ATTR_MSG` attribute. The key point is that
the error code in the `nlmsgerr` header is not necessary `errno` and
can't be used with `strerror()`.
This commit is contained in:
Kangping
2023-07-17 10:57:43 -07:00
committed by GitHub
parent ce44625357
commit 55cb65de62
1 changed files with 90 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/posix/platform/netif.cpp
+90 -14
View File
@@ -77,6 +77,7 @@
#include <linux/netlink.h>
#include <linux/rtnetlink.h>
#endif // __linux__
#include <math.h>
#include <net/if.h>
#include <net/if_arp.h>
#include <stdio.h>
@@ -1563,6 +1564,82 @@ exit:
#endif
#if defined(__linux__)
#define ERR_RTA(errmsg, requestPayloadLength) \
((struct rtattr *)((char *)(errmsg)) + NLMSG_ALIGN(sizeof(struct nlmsgerr)) + NLMSG_ALIGN(requestPayloadLength))
// The format of NLMSG_ERROR is described below:
//
// ----------------------------------------------
// | struct nlmsghdr - response header |
// ----------------------------------------------------------------
// | int error | |
// ---------------------------------------------| struct nlmsgerr |
// | struct nlmsghdr - original request header | |
// ----------------------------------------------------------------
// | ** optionally (1) payload of the request |
// ----------------------------------------------
// | ** optionally (2) extended ACK attrs |
// ----------------------------------------------
//
static void HandleNetlinkResponse(struct nlmsghdr *msg)
{
const struct nlmsgerr *err;
const char *errorMsg;
size_t rtaLength;
size_t requestPayloadLength = 0;
uint32_t requestSeq = 0;
if (msg->nlmsg_len < NLMSG_LENGTH(sizeof(struct nlmsgerr)))
{
otLogWarnPlat("[netif] Truncated netlink reply of request#%u", requestSeq);
ExitNow();
}
err = reinterpret_cast<const nlmsgerr *>(NLMSG_DATA(msg));
requestSeq = err->msg.nlmsg_seq;
if (err->error == 0)
{
otLogInfoPlat("[netif] Succeeded to process request#%u", requestSeq);
ExitNow();
}
// For rtnetlink, `abs(err->error)` maps to values of `errno`.
// But this is not a requirement in RFC 3549.
errorMsg = strerror(abs(err->error));
// The payload of the request is omitted if NLM_F_CAPPED is set
if (!(msg->nlmsg_flags & NLM_F_CAPPED))
{
requestPayloadLength = NLMSG_PAYLOAD(&err->msg, 0);
}
rtaLength = NLMSG_PAYLOAD(msg, sizeof(struct nlmsgerr)) - requestPayloadLength;
for (struct rtattr *rta = ERR_RTA(err, requestPayloadLength); RTA_OK(rta, rtaLength);
rta = RTA_NEXT(rta, rtaLength))
{
if (rta->rta_type == NLMSGERR_ATTR_MSG)
{
errorMsg = reinterpret_cast<const char *>(RTA_DATA(rta));
break;
}
else
{
otLogDebgPlat("[netif] Ignoring netlink response attribute %d (request#%u)", rta->rta_type, requestSeq);
}
}
otLogWarnPlat("[netif] Failed to process request#%u: %s", requestSeq, errorMsg);
exit:
return;
}
#endif // defined(__linux__)
static void processNetlinkEvent(otInstance *aInstance)
{
const size_t kMaxNetifEvent = 8192;
@@ -1624,20 +1701,8 @@ static void processNetlinkEvent(otInstance *aInstance)
#else
case NLMSG_ERROR:
{
const struct nlmsgerr *err = reinterpret_cast<const nlmsgerr *>(NLMSG_DATA(msg));
if (err->error == 0)
{
otLogInfoPlat("[netif] Succeeded to process request#%u", err->msg.nlmsg_seq);
}
else
{
otLogWarnPlat("[netif] Failed to process request#%u: %s", err->msg.nlmsg_seq, strerror(err->error));
}
HandleNetlinkResponse(msg);
break;
}
#endif
#if defined(ROUTE_FILTER) || defined(RO_MSGFILTER) || defined(__linux__)
@@ -1645,7 +1710,7 @@ static void processNetlinkEvent(otInstance *aInstance)
otLogWarnPlat("[netif] Unhandled/Unexpected netlink/route message (%d).", (int)msg->nlmsg_type);
break;
#else
// this platform doesn't support filtering, so we expect messages of other types...we just ignore them
// this platform doesn't support filtering, so we expect messages of other types...we just ignore them
#endif
}
}
@@ -1935,6 +2000,17 @@ static void platformConfigureNetLink(void)
#endif
VerifyOrDie(sNetlinkFd >= 0, OT_EXIT_ERROR_ERRNO);
#if defined(SOL_NETLINK)
{
int enable = 1;
VerifyOrDie(setsockopt(sNetlinkFd, SOL_NETLINK, NETLINK_EXT_ACK, &enable, sizeof(enable)) == 0,
OT_EXIT_ERROR_ERRNO);
VerifyOrDie(setsockopt(sNetlinkFd, SOL_NETLINK, NETLINK_CAP_ACK, &enable, sizeof(enable)) == 0,
OT_EXIT_ERROR_ERRNO);
}
#endif
#if defined(__linux__)
{
struct sockaddr_nl sa;