espressif/openthread
1
0
Fork 0
mirror of https://github.com/espressif/openthread.git synced 2026-08-22 10:29:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

[cli] update service add command to allow empty server data (#10377)

Browse Source
This commit is contained in:
Abtin Keshavarzian
2024-06-14 09:58:22 -07:00
committed by GitHub
parent 6bc3b4de8a
commit 69924eaa78
2 changed files with 15 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/cli/README.md
+2 -2
View File
@@ -3533,13 +3533,13 @@ Done
Module for controlling service registration in Network Data. Each change in service registration must be sent to leader by `netdata register` command before taking effect.
### service add \<enterpriseNumber\> \<serviceData\> \<serverData\>
### service add \<enterpriseNumber\> \<serviceData\> [\<serverData\>]
Add service to the Network Data.
- enterpriseNumber: IANA enterprise number
- serviceData: hex-encoded binary service data
- serverData: hex-encoded binary server data
- serverData: hex-encoded binary server data (empty if not provided)
```bash
> service add 44970 112233 aabbcc
src/cli/cli.cpp
+13 -6
View File
@@ -4596,13 +4596,13 @@ template <> otError Interpreter::Process<Cmd("service")>(Arg aArgs[])
* netdata register
* Done
* @endcode
* @cparam service add @ca{enterpriseNumber} @ca{serviceData} @ca{serverData}
* @cparam service add @ca{enterpriseNumber} @ca{serviceData} [@ca{serverData}]
* @par
* Adds service to the network data.
* @par
* - enterpriseNumber: IANA enterprise number
* - serviceData: Hex-encoded binary service data
* - serverData: Hex-encoded binary server data
* - serverData: Hex-encoded binary server data (empty if not provided)
* @par
* Note: For each change in service registration to take effect, run
* the `netdata register` command after running the `service add` command to notify the leader.
@@ -4611,10 +4611,17 @@ template <> otError Interpreter::Process<Cmd("service")>(Arg aArgs[])
*/
if (aArgs[0] == "add")
{
length = sizeof(cfg.mServerConfig.mServerData);
SuccessOrExit(error = aArgs[3].ParseAsHexString(length, cfg.mServerConfig.mServerData));
VerifyOrExit(length > 0, error = OT_ERROR_INVALID_ARGS);
cfg.mServerConfig.mServerDataLength = static_cast<uint8_t>(length);
if (!aArgs[3].IsEmpty())
{
length = sizeof(cfg.mServerConfig.mServerData);
SuccessOrExit(error = aArgs[3].ParseAsHexString(length, cfg.mServerConfig.mServerData));
VerifyOrExit(length > 0, error = OT_ERROR_INVALID_ARGS);
cfg.mServerConfig.mServerDataLength = static_cast<uint8_t>(length);
}
else
{
cfg.mServerConfig.mServerDataLength = 0;
}
cfg.mServerConfig.mStable = true;