espressif/openthread
1
0
Fork 0
mirror of https://github.com/espressif/openthread.git synced 2026-11-13 18:01:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

[mle] clear child IPv6 addresses when child reattaches as FTD (#13867)

Browse Source 
When an MTD child detaches and reattaches to the same parent as an FTD
while retaining its extended address, the parent reuses the existing
`Child` entry in `mChildTable`. Previously, `HandleChildIdRequest()`
only called `ProcessAddressRegistrationTlv()` (which clears previous
IPv6 addresses) when `!mode.IsFullThreadDevice()`, leaving the stale
MTD-registered IPv6 addresses and mesh-local IID on the now-FTD
`Child` entry.

This commit clears the child's registered IPv6 addresses when it
attaches or updates its mode as an FTD, and guards
`ProcessAddressRegistrationTlv()` in Child Update handlers to only
process address registrations for MTD children. It also adds a Nexus
test covering an MED child reattaching as an FED while another router
claims its former on-mesh address.
This commit is contained in:
Jonathan Hui
2026-11-04 10:21:52 -08:00
committed by GitHub
parent 7a273834ff
commit 79bff58132
4 changed files with 172 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/core/thread/child.cpp
+5
View File
@@ -103,6 +103,11 @@ void Child::SetDeviceMode(Mle::DeviceMode aMode)
}
#endif
if (IsFullThreadDevice())
{
ClearIp6Addresses();
}
VerifyOrExit(IsStateValid());
Get<NeighborTable>().Signal(NeighborTable::kChildModeChanged, *this);
src/core/thread/mle_ftd.cpp
+20 -14
View File
@@ -2268,15 +2268,18 @@ void Mle::HandleChildUpdateRequestOnParent(RxInfo &aRxInfo)
info.mTlvList.Add(Tlv::kLinkFrameCounter);
}
switch (ProcessAddressRegistrationTlv(aRxInfo, *child))
if (!mode.IsFullThreadDevice())
{
case kErrorNone:
info.mTlvList.Add(Tlv::kAddressRegistration);
break;
case kErrorNotFound:
break;
default:
ExitNow(error = kErrorParse);
switch (ProcessAddressRegistrationTlv(aRxInfo, *child))
{
case kErrorNone:
info.mTlvList.Add(Tlv::kAddressRegistration);
break;
case kErrorNotFound:
break;
default:
ExitNow(error = kErrorParse);
}
}
switch (aRxInfo.mMessage.ReadLeaderDataTlv(leaderData))
@@ -2525,13 +2528,16 @@ void Mle::HandleChildUpdateResponseOnParent(RxInfo &aRxInfo)
}
}
switch (ProcessAddressRegistrationTlv(aRxInfo, *child))
if (!child->IsFullThreadDevice())
{
case kErrorNone:
case kErrorNotFound:
break;
default:
ExitNow(error = kErrorParse);
switch (ProcessAddressRegistrationTlv(aRxInfo, *child))
{
case kErrorNone:
case kErrorNotFound:
break;
default:
ExitNow(error = kErrorParse);
}
}
switch (aRxInfo.mMessage.ReadLeaderDataTlv(leaderData))
tests/nexus/CMakeLists.txt
+1
View File
@@ -404,6 +404,7 @@ ot_nexus_test(br_upgrade_router_role "core;nexus")
ot_nexus_test(border_admitter "core;nexus")
ot_nexus_test(border_agent "core;nexus")
ot_nexus_test(border_agent_tracker "core;nexus")
ot_nexus_test(child_reattach_as_ftd "core;nexus")
ot_nexus_test(child_supervision "core;nexus")
ot_nexus_test(coap_block "core;nexus")
ot_nexus_test(coap_observe "core;nexus")
tests/nexus/test_child_reattach_as_ftd.cpp
+146
View File
@@ -0,0 +1,146 @@
/*
* Copyright (c) 2026, The OpenThread Authors.
* All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions are met:
* 1. Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* 2. Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in the
* documentation and/or other materials provided with the distribution.
* 3. Neither the name of the copyright holder nor the
* names of its contributors may be used to endorse or promote products
* derived from this software without specific prior written permission.
*
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
* AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
* ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE
* LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
* CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
* SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
* INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
* CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
* ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
* POSSIBILITY OF SUCH DAMAGE.
*/
#include <stdio.h>
#include "platform/nexus_core.hpp"
#include "platform/nexus_node.hpp"
namespace ot {
namespace Nexus {
static constexpr uint32_t kFormNetworkTime = 13 * 1000;
static constexpr uint32_t kAttachToRouterTime = 200 * 1000;
static constexpr uint32_t kAttachAsChildTime = 10 * 1000;
static constexpr uint32_t kStabilizationTime = 10 * 1000;
static const Mle::DeviceMode kFedDeviceMode(Mle::DeviceMode::kModeRxOnWhenIdle |
Mle::DeviceMode::kModeFullThreadDevice |
Mle::DeviceMode::kModeFullNetworkData);
void TestChildReattachAsFtd(void)
{
Core nexus;
Node &leader = nexus.CreateNode();
Node &router = nexus.CreateNode();
Node &child = nexus.CreateNode();
Ip6::Netif::UnicastAddress unicastAddr;
Ip6::Address childMlEid;
Ip6::Address meshLocalAddr;
Child *childEntry;
leader.SetName("LEADER");
router.SetName("ROUTER");
child.SetName("CHILD");
AllowLinkBetween(leader, router);
AllowLinkBetween(leader, child);
nexus.AdvanceTime(0);
SuccessOrQuit(Instance::SetGlobalLogLevel(kLogLevelNote));
Log("Step 1: Form network with LEADER and ROUTER, and publish on-mesh prefix");
leader.Form();
nexus.AdvanceTime(kFormNetworkTime);
VerifyOrQuit(leader.Get<Mle::Mle>().IsLeader());
{
NetworkData::OnMeshPrefixConfig config;
config.Clear();
SuccessOrQuit(config.GetPrefix().FromString("fd00:db8:1::/64"));
config.mPreferred = true;
config.mOnMesh = true;
config.mStable = true;
SuccessOrQuit(leader.Get<NetworkData::Local>().AddOnMeshPrefix(config));
leader.Get<NetworkData::Notifier>().HandleServerDataUpdated();
}
router.Join(leader, Node::kAsFtd);
nexus.AdvanceTime(kAttachToRouterTime);
VerifyOrQuit(router.Get<Mle::Mle>().IsRouter());
Log("Step 2: CHILD adds on-mesh address and attaches to LEADER as MED");
unicastAddr.InitAsSlaacOrigin(/* aPrefixLength */ 64, /* aPreferred */ true);
SuccessOrQuit(unicastAddr.GetAddress().FromString("fd00:db8:1::1234"));
SuccessOrQuit(child.Get<ThreadNetif>().AddExternalUnicastAddress(unicastAddr));
child.Join(leader, Node::kAsMed);
nexus.AdvanceTime(kAttachAsChildTime);
VerifyOrQuit(child.Get<Mle::Mle>().IsChild());
VerifyOrQuit(!child.Get<Mle::Mle>().IsFullThreadDevice());
childMlEid = child.Get<Mle::Mle>().GetMeshLocalEid();
childEntry = leader.Get<ChildTable>().FindChild(child.Get<Mac::Mac>().GetExtAddress(), Child::kInStateValid);
VerifyOrQuit(childEntry != nullptr);
VerifyOrQuit(!childEntry->IsFullThreadDevice());
VerifyOrQuit(childEntry->HasIp6Address(unicastAddr.GetAddress()));
VerifyOrQuit(childEntry->HasIp6Address(childMlEid));
nexus.SendAndVerifyEchoRequest(leader, unicastAddr.GetAddress());
Log("Step 3: CHILD detaches, removes on-mesh address, and reattaches to LEADER as FED");
SuccessOrQuit(child.Get<Mle::Mle>().BecomeDetached());
SuccessOrQuit(child.Get<ThreadNetif>().RemoveExternalUnicastAddress(unicastAddr.GetAddress()));
SuccessOrQuit(child.Get<Mle::Mle>().SetDeviceMode(kFedDeviceMode));
SuccessOrQuit(child.Get<Mle::Mle>().SetRouterEligible(false));
nexus.AdvanceTime(kAttachAsChildTime);
VerifyOrQuit(child.Get<Mle::Mle>().IsChild());
VerifyOrQuit(child.Get<Mle::Mle>().IsFullThreadDevice());
childEntry = leader.Get<ChildTable>().FindChild(child.Get<Mac::Mac>().GetExtAddress(), Child::kInStateValid);
VerifyOrQuit(childEntry != nullptr);
VerifyOrQuit(childEntry->IsFullThreadDevice());
VerifyOrQuit(!childEntry->HasIp6Address(unicastAddr.GetAddress()));
VerifyOrQuit(!childEntry->HasIp6Address(childMlEid));
VerifyOrQuit(childEntry->GetIp6Addresses().IsEmpty());
VerifyOrQuit(childEntry->GetMeshLocalIp6Address(meshLocalAddr) == kErrorNotFound);
Log("Step 4: ROUTER adds the on-mesh address and LEADER sends traffic to it");
SuccessOrQuit(router.Get<ThreadNetif>().AddExternalUnicastAddress(unicastAddr));
nexus.AdvanceTime(kStabilizationTime);
nexus.SendAndVerifyEchoRequest(leader, unicastAddr.GetAddress());
}
} // namespace Nexus
} // namespace ot
int main(void)
{
ot::Nexus::TestChildReattachAsFtd();
printf("All tests passed\n");
return 0;
}