espressif/openthread
1
0
Fork 0
mirror of https://github.com/espressif/openthread.git synced 2026-09-05 00:30:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

[network-data] resolve uninitialized output from RlocLookup (#4562)

Browse Source
This commit is contained in:
Jonathan Hui
2020-02-18 09:50:57 -08:00
parent 1f2bed8e7d
commit 8079570ccf
1 changed files with 10 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/core/thread/network_data_leader_ftd.cpp
+10 -7
View File
@@ -119,8 +119,8 @@ void Leader::SetContextIdReuseDelay(uint32_t aDelay)
void Leader::RemoveBorderRouter(uint16_t aRloc16, MatchMode aMatchMode)
{
bool rlocIn = false;
bool rlocStable = false;
bool rlocIn;
bool rlocStable;
RlocLookup(aRloc16, rlocIn, rlocStable, mTlvs, mLength, aMatchMode);
VerifyOrExit(rlocIn);
@@ -434,6 +434,9 @@ otError Leader::RlocLookup(uint16_t aRloc16,
ServiceTlv * service;
ServerTlv * server;
aIn = false;
aStable = false;
while (cur < end)
{
VerifyOrExit((cur + 1) <= end && cur->GetNext() <= end, error = OT_ERROR_PARSE);
@@ -720,9 +723,9 @@ exit:
otError Leader::RegisterNetworkData(uint16_t aRloc16, uint8_t *aTlvs, uint8_t aTlvsLength)
{
otError error = OT_ERROR_NONE;
bool rlocIn = false;
bool rlocStable = false;
bool stableUpdated = false;
bool rlocIn;
bool rlocStable;
bool unused;
uint8_t oldTlvs[NetworkData::kMaxSize];
uint8_t oldTlvsLength = NetworkData::kMaxSize;
@@ -1187,9 +1190,9 @@ void Leader::StopContextReuseTimer(uint8_t aContextId)
otError Leader::SendServerDataNotification(uint16_t aRloc16)
{
otError error = OT_ERROR_NONE;
bool rlocIn = false;
bool rlocStable = false;
otError error = OT_ERROR_NONE;
bool rlocIn;
bool rlocStable;
RlocLookup(aRloc16, rlocIn, rlocStable, mTlvs, mLength, kMatchModeRloc16);