espressif/openthread
1
0
Fork 0
mirror of https://github.com/espressif/openthread.git synced 2026-08-22 10:29:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

[posix] logging when infra/backbone interface is not provided (#7228)

Browse Source 
The Backbone Router and Border Routing feature will be silently
disabled when the infra/backbone interface is not provided. We should
at least print a warning log in this case since it may not be
intentional.
This commit is contained in:
Kangping
2021-12-13 23:42:37 -08:00
committed by GitHub
parent 13870f5e57
commit 847e9ce4ad
2 changed files with 14 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/posix/platform/backbone.cpp
+5 -1
View File
@@ -48,7 +48,11 @@ static ot::Posix::MulticastRoutingManager sMulticastRoutingManager;
void platformBackboneInit(const char *aInterfaceName)
{
VerifyOrExit(aInterfaceName != nullptr && aInterfaceName[0] != '\0');
if (aInterfaceName == nullptr || aInterfaceName[0] == '\0')
{
otLogWarnPlat("Backbone Router feature is disabled: infra/backbone interface is missing");
ExitNow();
}
VerifyOrDie(strnlen(aInterfaceName, sizeof(gBackboneNetifName)) < sizeof(gBackboneNetifName),
OT_EXIT_INVALID_ARGUMENTS);
src/posix/platform/infra_if.cpp
+9 -5
View File
@@ -304,7 +304,11 @@ void InfraNetif::Init(const char *aIfName)
ssize_t rval;
uint32_t ifIndex = 0;
VerifyOrExit(aIfName != nullptr && aIfName[0] != '\0');
if (aIfName == nullptr || aIfName[0] == '\0')
{
otLogWarnPlat("Border Routing feature is disabled: infra/backbone interface is missing");
ExitNow();
}
VerifyOrDie(strnlen(aIfName, sizeof(mInfraIfName)) <= sizeof(mInfraIfName) - 1, OT_EXIT_INVALID_ARGUMENTS);
strcpy(mInfraIfName, aIfName);
@@ -313,7 +317,7 @@ void InfraNetif::Init(const char *aIfName)
ifIndex = if_nametoindex(aIfName);
if (ifIndex == 0)
{
otLogCritPlat("failed to get the index for infra interface %s", aIfName);
otLogCritPlat("Failed to get the index for infra interface %s", aIfName);
DieNow(OT_EXIT_INVALID_ARGUMENTS);
}
mInfraIfIndex = ifIndex;
@@ -399,7 +403,7 @@ void InfraNetif::ReceiveNetLinkMessage(void)
len = recv(mNetLinkSocket, msgBuffer.mBuffer, sizeof(msgBuffer.mBuffer), 0);
if (len < 0)
{
otLogCritPlat("failed to receive netlink message: %s", strerror(errno));
otLogCritPlat("Failed to receive netlink message: %s", strerror(errno));
ExitNow();
}
@@ -466,7 +470,7 @@ void InfraNetif::ReceiveIcmp6Message(void)
rval = recvmsg(mInfraIfIcmp6Socket, &msg, 0);
if (rval < 0)
{
otLogWarnPlat("failed to receive ICMPv6 message: %s", strerror(errno));
otLogWarnPlat("Failed to receive ICMPv6 message: %s", strerror(errno));
ExitNow(error = OT_ERROR_DROP);
}
@@ -502,7 +506,7 @@ void InfraNetif::ReceiveIcmp6Message(void)
exit:
if (error != OT_ERROR_NONE)
{
otLogDebgPlat("failed to handle ICMPv6 message: %s", otThreadErrorToString(error));
otLogDebgPlat("Failed to handle ICMPv6 message: %s", otThreadErrorToString(error));
}
}