espressif/openthread
1
0
Fork 0
mirror of https://github.com/espressif/openthread.git synced 2026-07-27 14:27:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

[posix] initialize pointers to avoid potential using uninitialized pointers (#8942)

Browse Source
This commit is contained in:
Song GUO
2023-04-10 18:48:08 -07:00
committed by GitHub
parent 0f94f26a20
commit 91e1be0b34
1 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/posix/platform/resolver.cpp
+9 -3
View File
@@ -108,7 +108,7 @@ void Resolver::Query(otPlatDnsUpstreamQuery *aTxn, const otMessage *aQuery)
uint16_t length = otMessageGetLength(aQuery);
sockaddr_in serverAddr;
Transaction *txn;
Transaction *txn = nullptr;
VerifyOrExit(length <= kMaxDnsMessageSize, error = OT_ERROR_NO_BUFS);
VerifyOrExit(otMessageRead(aQuery, 0, &packet, sizeof(packet)) == length, error = OT_ERROR_NO_BUFS);
@@ -176,12 +176,14 @@ void Resolver::ForwardResponse(Transaction *aTxn)
{
char response[kMaxDnsMessageSize];
ssize_t readSize;
otMessage *message;
otError error = OT_ERROR_NONE;
otMessage *message = nullptr;
VerifyOrExit((readSize = read(aTxn->mUdpFd, response, sizeof(response))) > 0);
message = otUdpNewMessage(gInstance, nullptr);
SuccessOrExit(otMessageAppend(message, response, readSize));
VerifyOrExit(message != nullptr, error = OT_ERROR_NO_BUFS);
SuccessOrExit(error = otMessageAppend(message, response, readSize));
otPlatDnsUpstreamQueryDone(gInstance, aTxn->mThreadTxn, message);
message = nullptr;
@@ -191,6 +193,10 @@ exit:
{
otLogInfoPlat("Failed to read response from upstream resolver socket: %d", errno);
}
if (error != OT_ERROR_NONE)
{
otLogInfoPlat("Failed to forward upstream DNS response: %s", otThreadErrorToString(error));
}
if (message != nullptr)
{
otMessageFree(message);