espressif/openthread
1
0
Fork 0
mirror of https://github.com/espressif/openthread.git synced 2026-08-07 03:07:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

[platform] evaluate aError only once in SuccessOrDie (#13356)

Browse Source 
Previously, `SuccessOrDie(aError)` evaluated the `aError` argument
twice inside `VerifyOrDie` (once to compare against `OT_ERROR_NONE`
and once to compare against `OT_ERROR_INVALID_ARGS`). If `aError` was
an expression with side effects or a function call, it would be
executed multiple times.

This commit updates `SuccessOrDie` to assign `aError` to a temporary
local variable within a `do { ... } while (false)` block, ensuring
`aError` is evaluated exactly once.
This commit is contained in:
Yakun Xu
2026-07-16 09:43:47 -07:00
committed by GitHub
parent 27e86ae0f0
commit 95fc632715
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/lib/platform/exit_code.h
+7 -3
View File
@@ -132,9 +132,13 @@ const char *otExitCodeToString(uint8_t aExitCode);
*
* @param[in] aError An error code to be evaluated against OT_ERROR_NONE.
*/
#define SuccessOrDie(aError) \
VerifyOrDie(aError == OT_ERROR_NONE, \
(aError == OT_ERROR_INVALID_ARGS ? OT_EXIT_INVALID_ARGUMENTS : OT_EXIT_FAILURE))
#define SuccessOrDie(aError) \
do \
{ \
otError _successOrDieError = (aError); \
VerifyOrDie(_successOrDieError == OT_ERROR_NONE, \
(_successOrDieError == OT_ERROR_INVALID_ARGS ? OT_EXIT_INVALID_ARGUMENTS : OT_EXIT_FAILURE)); \
} while (false)
/**
* Unconditionally both records exit status and terminates the program.