[core] optimize #include directives in core cpp files (#10717)

This commit removes unnecessary `#include` directives in core `cpp`
files that already include `instance.hpp`. The `instance.hpp` header
itself includes all necessary OT core headers and definitions as they
are contained within an `ot::Instance`.

src/core/api/border_router_api.cpp

@@ -37,8 +37,6 @@
 
 #include <openthread/border_router.h>
 
-#include "border_router/routing_manager.hpp"
-#include "common/debug.hpp"
 #include "instance/instance.hpp"
 
 using namespace ot;

src/core/api/border_routing_api.cpp

@@ -35,10 +35,6 @@
 
 #if OPENTHREAD_CONFIG_BORDER_ROUTING_ENABLE
 
-#include <openthread/border_routing.h>
-#include <openthread/platform/border_routing.h>
-
-#include "border_router/routing_manager.hpp"
 #include "instance/instance.hpp"
 
 using namespace ot;

src/core/api/channel_manager_api.cpp

@@ -36,11 +36,7 @@
 #if OPENTHREAD_CONFIG_CHANNEL_MANAGER_ENABLE && \
     (OPENTHREAD_FTD || OPENTHREAD_CONFIG_CHANNEL_MANAGER_CSL_CHANNEL_SELECT_ENABLE)
 
-#include <openthread/channel_manager.h>
-
-#include "common/as_core_type.hpp"
 #include "instance/instance.hpp"
-#include "utils/channel_manager.hpp"
 
 using namespace ot;
 

src/core/api/child_supervision_api.cpp

@@ -33,9 +33,6 @@
 
 #include "openthread-core-config.h"
 
-#include <openthread/child_supervision.h>
-
-#include "common/as_core_type.hpp"
 #include "instance/instance.hpp"
 
 using namespace ot;

src/core/api/coap_api.cpp

@@ -35,10 +35,6 @@
 
 #if OPENTHREAD_CONFIG_COAP_API_ENABLE
 
-#include <openthread/coap.h>
-
-#include "coap/coap_message.hpp"
-#include "common/as_core_type.hpp"
 #include "instance/instance.hpp"
 
 using namespace ot;

src/core/api/coap_secure_api.cpp

@@ -35,12 +35,6 @@
 
 #if OPENTHREAD_CONFIG_COAP_SECURE_API_ENABLE
 
-#include <openthread/coap_secure.h>
-#include <openthread/ip6.h>
-
-#include "coap/coap_message.hpp"
-#include "coap/coap_secure.hpp"
-#include "common/as_core_type.hpp"
 #include "instance/instance.hpp"
 
 using namespace ot;

src/core/api/commissioner_api.cpp

@@ -35,9 +35,6 @@
 
 #if OPENTHREAD_FTD && OPENTHREAD_CONFIG_COMMISSIONER_ENABLE
 
-#include <openthread/commissioner.h>
-
-#include "common/as_core_type.hpp"
 #include "instance/instance.hpp"
 
 using namespace ot;

src/core/api/crypto_api.cpp

@@ -33,12 +33,6 @@
 
 #include "openthread-core-config.h"
 
-#include <openthread/crypto.h>
-#include <openthread/error.h>
-
-#include "common/as_core_type.hpp"
-#include "common/code_utils.hpp"
-#include "common/debug.hpp"
 #include "crypto/aes_ccm.hpp"
 #include "crypto/ecdsa.hpp"
 #include "crypto/hmac_sha256.hpp"

src/core/api/dataset_api.cpp

@@ -33,12 +33,7 @@
 
 #include "openthread-core-config.h"
 
-#include <openthread/dataset.h>
-
-#include "common/as_core_type.hpp"
 #include "instance/instance.hpp"
-#include "meshcop/dataset_manager.hpp"
-#include "meshcop/meshcop.hpp"
 
 using namespace ot;
 

src/core/api/dataset_ftd_api.cpp

@@ -37,7 +37,6 @@
 
 #include <openthread/dataset_ftd.h>
 
-#include "common/as_core_type.hpp"
 #include "instance/instance.hpp"
 
 using namespace ot;

src/core/api/dataset_updater_api.cpp

@@ -35,11 +35,7 @@
 
 #if OPENTHREAD_CONFIG_DATASET_UPDATER_ENABLE && OPENTHREAD_FTD
 
-#include <openthread/dataset_updater.h>
-
-#include "common/as_core_type.hpp"
 #include "instance/instance.hpp"
-#include "meshcop/dataset_updater.hpp"
 
 using namespace ot;
 

src/core/api/diags_api.cpp

@@ -35,9 +35,6 @@
 
 #if OPENTHREAD_CONFIG_DIAG_ENABLE
 
-#include <openthread/diag.h>
-
-#include "common/as_core_type.hpp"
 #include "instance/instance.hpp"
 
 using namespace ot;

src/core/api/dns_api.cpp

@@ -33,8 +33,6 @@
 
 #include "openthread-core-config.h"
 
-#include <openthread/dns_client.h>
-
 #include "instance/instance.hpp"
 #include "net/dns_types.hpp"
 

src/core/api/dns_server_api.cpp

@@ -34,8 +34,6 @@
 #include "openthread-core-config.h"
 
 #include "instance/instance.hpp"
-#include "net/dns_types.hpp"
-#include "net/dnssd_server.hpp"
 
 using namespace ot;
 

src/core/api/history_tracker_api.cpp

@@ -35,11 +35,7 @@
 
 #if OPENTHREAD_CONFIG_HISTORY_TRACKER_ENABLE
 
-#include <openthread/history_tracker.h>
-
-#include "common/as_core_type.hpp"
 #include "instance/instance.hpp"
-#include "utils/history_tracker.hpp"
 
 using namespace ot;
 

src/core/api/icmp6_api.cpp

@@ -33,9 +33,6 @@
 
 #include "openthread-core-config.h"
 
-#include <openthread/icmp6.h>
-
-#include "common/as_core_type.hpp"
 #include "instance/instance.hpp"
 
 using namespace ot;

src/core/api/instance_api.cpp

@@ -36,10 +36,8 @@
 #include <openthread/instance.h>
 #include <openthread/platform/misc.h>
 
-#include "common/as_core_type.hpp"
 #include "common/new.hpp"
 #include "instance/instance.hpp"
-#include "radio/radio.hpp"
 
 #if !defined(OPENTHREAD_BUILD_DATETIME)
 #ifdef __ANDROID__

src/core/api/ip6_api.cpp

@@ -33,14 +33,7 @@
 
 #include "openthread-core-config.h"
 
-#include <openthread/ip6.h>
-
-#include "common/as_core_type.hpp"
 #include "instance/instance.hpp"
-#include "net/ip4_types.hpp"
-#include "net/ip6_headers.hpp"
-#include "thread/network_data_leader.hpp"
-#include "utils/slaac_address.hpp"
 
 using namespace ot;
 

src/core/api/jam_detection_api.cpp

@@ -37,7 +37,6 @@
 
 #include <openthread/jam_detection.h>
 
-#include "common/as_core_type.hpp"
 #include "instance/instance.hpp"
 
 using namespace ot;

src/core/api/joiner_api.cpp

@@ -35,10 +35,6 @@
 
 #if OPENTHREAD_CONFIG_JOINER_ENABLE
 
-#include <openthread/joiner.h>
-
-#include "common/as_core_type.hpp"
-#include "common/debug.hpp"
 #include "instance/instance.hpp"
 
 using namespace ot;

src/core/api/link_api.cpp

@@ -33,12 +33,7 @@
 
 #include "openthread-core-config.h"
 
-#include <openthread/link.h>
-
-#include "common/as_core_type.hpp"
 #include "instance/instance.hpp"
-#include "mac/mac.hpp"
-#include "radio/radio.hpp"
 
 using namespace ot;
 

src/core/api/link_metrics_api.cpp

@@ -34,9 +34,7 @@
 #include "openthread-core-config.h"
 
 #if OPENTHREAD_CONFIG_MLE_LINK_METRICS_INITIATOR_ENABLE
-#include <openthread/link_metrics.h>
 
-#include "common/as_core_type.hpp"
 #include "instance/instance.hpp"
 
 using namespace ot;

src/core/api/link_raw_api.cpp

@@ -35,17 +35,9 @@
 
 #if OPENTHREAD_RADIO || OPENTHREAD_CONFIG_LINK_RAW_ENABLE
 
-#include <string.h>
-#include <openthread/diag.h>
-#include <openthread/thread.h>
-#include <openthread/platform/diag.h>
 #include <openthread/platform/time.h>
 
-#include "common/as_core_type.hpp"
-#include "common/debug.hpp"
-#include "common/random.hpp"
 #include "instance/instance.hpp"
-#include "mac/mac_frame.hpp"
 
 using namespace ot;
 

src/core/api/logging_api.cpp

@@ -33,10 +33,6 @@
 
 #include "openthread-core-config.h"
 
-#include "common/code_utils.hpp"
-#include "common/debug.hpp"
-#include "common/log.hpp"
-#include "common/string.hpp"
 #include "instance/instance.hpp"
 
 using namespace ot;

src/core/api/mdns_api.cpp

@@ -33,15 +33,12 @@
 
 #include "openthread-core-config.h"
 
-#include <openthread/mdns.h>
+#if OPENTHREAD_CONFIG_MULTICAST_DNS_ENABLE && OPENTHREAD_CONFIG_MULTICAST_DNS_PUBLIC_API_ENABLE
 
 #include "instance/instance.hpp"
-#include "net/mdns.hpp"
 
 using namespace ot;
 
-#if OPENTHREAD_CONFIG_MULTICAST_DNS_ENABLE && OPENTHREAD_CONFIG_MULTICAST_DNS_PUBLIC_API_ENABLE
-
 otError otMdnsSetEnabled(otInstance *aInstance, bool aEnable, uint32_t aInfraIfIndex)
 {
     return AsCoreType(aInstance).Get<Dns::Multicast::Core>().SetEnabled(aEnable, aInfraIfIndex);

src/core/api/mesh_diag_api.cpp

@@ -35,11 +35,7 @@
 
 #if OPENTHREAD_CONFIG_MESH_DIAG_ENABLE && OPENTHREAD_FTD
 
-#include <openthread/mesh_diag.h>
-
-#include "common/as_core_type.hpp"
 #include "instance/instance.hpp"
-#include "utils/mesh_diag.hpp"
 
 using namespace ot;
 

src/core/api/message_api.cpp

@@ -33,9 +33,6 @@
 
 #include "openthread-core-config.h"
 
-#include <openthread/message.h>
-
-#include "common/as_core_type.hpp"
 #include "instance/instance.hpp"
 
 using namespace ot;

src/core/api/multi_radio_api.cpp

@@ -37,10 +37,7 @@
 
 #include <openthread/multi_radio.h>
 
-#include "common/as_core_type.hpp"
-#include "common/code_utils.hpp"
 #include "instance/instance.hpp"
-#include "thread/radio_selector.hpp"
 
 using namespace ot;
 

src/core/api/nat64_api.cpp

@@ -33,16 +33,7 @@
 
 #include "openthread-core-config.h"
 
-#include <openthread/border_router.h>
-#include <openthread/ip6.h>
-#include <openthread/nat64.h>
-
-#include "border_router/routing_manager.hpp"
-#include "common/debug.hpp"
 #include "instance/instance.hpp"
-#include "net/ip4_types.hpp"
-#include "net/ip6_headers.hpp"
-#include "net/nat64_translator.hpp"
 
 using namespace ot;
 

src/core/api/netdata_api.cpp

@@ -33,9 +33,6 @@
 
 #include "openthread-core-config.h"
 
-#include <openthread/netdata.h>
-
-#include "common/as_core_type.hpp"
 #include "instance/instance.hpp"
 
 using namespace ot;

src/core/api/netdata_publisher_api.cpp

@@ -35,9 +35,6 @@
 
 #if OPENTHREAD_CONFIG_NETDATA_PUBLISHER_ENABLE
 
-#include <openthread/netdata_publisher.h>
-
-#include "common/as_core_type.hpp"
 #include "instance/instance.hpp"
 
 using namespace ot;

src/core/api/netdiag_api.cpp

@@ -33,9 +33,6 @@
 
 #include "openthread-core-config.h"
 
-#include <openthread/netdiag.h>
-
-#include "common/as_core_type.hpp"
 #include "instance/instance.hpp"
 
 using namespace ot;

src/core/api/network_time_api.cpp

@@ -37,7 +37,6 @@
 
 #include <openthread/network_time.h>
 
-#include "common/as_core_type.hpp"
 #include "instance/instance.hpp"
 
 using namespace ot;

src/core/api/ping_sender_api.cpp

@@ -33,9 +33,6 @@
 
 #include "openthread-core-config.h"
 
-#include <openthread/ping_sender.h>
-
-#include "common/as_core_type.hpp"
 #include "instance/instance.hpp"
 
 using namespace ot;

src/core/api/radio_stats_api.cpp

@@ -33,9 +33,6 @@
 
 #include "openthread-core-config.h"
 
-#include <openthread/radio_stats.h>
-
-#include "common/as_core_type.hpp"
 #include "instance/instance.hpp"
 
 using namespace ot;

src/core/api/server_api.cpp

@@ -35,9 +35,6 @@
 
 #if OPENTHREAD_CONFIG_TMF_NETDATA_SERVICE_ENABLE
 
-#include <openthread/server.h>
-
-#include "common/as_core_type.hpp"
 #include "instance/instance.hpp"
 
 using namespace ot;

src/core/api/sntp_api.cpp

@@ -37,7 +37,6 @@
 
 #include <openthread/sntp.h>
 
-#include "common/as_core_type.hpp"
 #include "instance/instance.hpp"
 
 using namespace ot;

src/core/api/srp_client_api.cpp

@@ -35,9 +35,6 @@
 
 #if OPENTHREAD_CONFIG_SRP_CLIENT_ENABLE
 
-#include <openthread/srp_client.h>
-
-#include "common/as_core_type.hpp"
 #include "instance/instance.hpp"
 
 using namespace ot;

src/core/api/srp_client_buffers_api.cpp

@@ -35,7 +35,6 @@
 
 #include <openthread/srp_client_buffers.h>
 
-#include "common/as_core_type.hpp"
 #include "instance/instance.hpp"
 
 using namespace ot;

src/core/api/srp_server_api.cpp

@@ -35,9 +35,6 @@
 
 #if OPENTHREAD_CONFIG_SRP_SERVER_ENABLE
 
-#include <openthread/srp_server.h>
-
-#include "common/as_core_type.hpp"
 #include "instance/instance.hpp"
 
 using namespace ot;

src/core/api/tasklet_api.cpp

@@ -33,10 +33,6 @@
 
 #include "openthread-core-config.h"
 
-#include <openthread/tasklet.h>
-
-#include "common/as_core_type.hpp"
-#include "common/code_utils.hpp"
 #include "instance/instance.hpp"
 
 using namespace ot;

src/core/api/tcp_api.cpp

@@ -35,9 +35,6 @@
 
 #if OPENTHREAD_CONFIG_TCP_ENABLE
 
-#include <openthread/tcp.h>
-
-#include "common/as_core_type.hpp"
 #include "instance/instance.hpp"
 
 using namespace ot;

src/core/api/tcp_ext_api.cpp

@@ -37,7 +37,6 @@
 
 #include <openthread/tcp_ext.h>
 
-#include "common/as_core_type.hpp"
 #include "instance/instance.hpp"
 #include "net/tcp6_ext.hpp"
 

src/core/api/thread_api.cpp

@@ -35,13 +35,7 @@
 
 #if OPENTHREAD_FTD || OPENTHREAD_MTD
 
-#include <openthread/thread.h>
-
-#include "common/as_core_type.hpp"
-#include "common/debug.hpp"
-#include "common/uptime.hpp"
 #include "instance/instance.hpp"
-#include "thread/version.hpp"
 
 using namespace ot;
 

src/core/api/thread_ftd_api.cpp

@@ -35,9 +35,6 @@
 
 #if OPENTHREAD_FTD
 
-#include <openthread/thread_ftd.h>
-
-#include "common/as_core_type.hpp"
 #include "instance/instance.hpp"
 
 using namespace ot;

src/core/api/trel_api.cpp

@@ -37,8 +37,6 @@
 
 #include <openthread/trel.h>
 
-#include "common/as_core_type.hpp"
-#include "common/code_utils.hpp"
 #include "instance/instance.hpp"
 
 using namespace ot;

src/core/api/udp_api.cpp

@@ -33,9 +33,6 @@
 
 #include "openthread-core-config.h"
 
-#include <openthread/udp.h>
-
-#include "common/as_core_type.hpp"
 #include "instance/instance.hpp"
 
 using namespace ot;

src/core/backbone_router/bbr_local.cpp

@@ -35,12 +35,7 @@
 
 #if OPENTHREAD_FTD && OPENTHREAD_CONFIG_BACKBONE_ROUTER_ENABLE
 
-#include "common/code_utils.hpp"
-#include "common/log.hpp"
-#include "common/random.hpp"
 #include "instance/instance.hpp"
-#include "thread/mle_types.hpp"
-#include "thread/thread_netif.hpp"
 
 namespace ot {
 

src/core/backbone_router/bbr_manager.cpp

@@ -35,17 +35,7 @@
 
 #if OPENTHREAD_FTD && OPENTHREAD_CONFIG_BACKBONE_ROUTER_ENABLE
 
-#include "common/as_core_type.hpp"
-#include "common/code_utils.hpp"
-#include "common/log.hpp"
-#include "common/num_utils.hpp"
-#include "common/numeric_limits.hpp"
-#include "common/random.hpp"
 #include "instance/instance.hpp"
-#include "thread/mle_types.hpp"
-#include "thread/thread_netif.hpp"
-#include "thread/thread_tlvs.hpp"
-#include "thread/uri_paths.hpp"
 
 namespace ot {
 

src/core/backbone_router/multicast_listeners_table.cpp

@@ -35,14 +35,7 @@
 
 #if OPENTHREAD_FTD && OPENTHREAD_CONFIG_BACKBONE_ROUTER_MULTICAST_ROUTING_ENABLE
 
-#include "common/array.hpp"
-#include "common/code_utils.hpp"
-#include "common/log.hpp"
-#include "common/random.hpp"
 #include "instance/instance.hpp"
-#include "thread/mle_types.hpp"
-#include "thread/thread_netif.hpp"
-#include "thread/uri_paths.hpp"
 
 namespace ot {
 

src/core/border_router/infra_if.cpp

@@ -35,11 +35,7 @@
 
 #if OPENTHREAD_CONFIG_BORDER_ROUTING_ENABLE
 
-#include "border_router/routing_manager.hpp"
-#include "common/as_core_type.hpp"
-#include "common/logging.hpp"
 #include "instance/instance.hpp"
-#include "net/icmp6.hpp"
 
 namespace ot {
 namespace BorderRouter {

src/core/border_router/routing_manager.cpp

@@ -42,23 +42,7 @@
 #include <openthread/platform/border_routing.h>
 #include <openthread/platform/infra_if.h>
 
-#include "common/code_utils.hpp"
-#include "common/debug.hpp"
-#include "common/log.hpp"
-#include "common/num_utils.hpp"
-#include "common/numeric_limits.hpp"
-#include "common/random.hpp"
-#include "common/settings.hpp"
-#include "common/type_traits.hpp"
 #include "instance/instance.hpp"
-#include "meshcop/extended_panid.hpp"
-#include "net/ip6.hpp"
-#include "net/nat64_translator.hpp"
-#include "net/nd6.hpp"
-#include "thread/mle_router.hpp"
-#include "thread/network_data_leader.hpp"
-#include "thread/network_data_local.hpp"
-#include "thread/network_data_notifier.hpp"
 
 namespace ot {
 

src/core/coap/coap.cpp

@@ -28,17 +28,7 @@
 
 #include "coap.hpp"
 
-#include "common/array.hpp"
-#include "common/as_core_type.hpp"
-#include "common/code_utils.hpp"
-#include "common/debug.hpp"
-#include "common/log.hpp"
-#include "common/random.hpp"
-#include "common/string.hpp"
 #include "instance/instance.hpp"
-#include "net/ip6.hpp"
-#include "net/udp6.hpp"
-#include "thread/thread_netif.hpp"
 
 /**
  * @file

src/core/coap/coap_message.cpp

@@ -33,13 +33,6 @@
 
 #include "coap_message.hpp"
 
-#include "coap/coap.hpp"
-#include "common/array.hpp"
-#include "common/code_utils.hpp"
-#include "common/debug.hpp"
-#include "common/encoding.hpp"
-#include "common/random.hpp"
-#include "common/string.hpp"
 #include "instance/instance.hpp"
 
 namespace ot {

src/core/coap/coap_secure.cpp

@@ -30,12 +30,7 @@
 
 #if OPENTHREAD_CONFIG_SECURE_TRANSPORT_ENABLE
 
-#include "common/log.hpp"
-#include "common/new.hpp"
 #include "instance/instance.hpp"
-#include "meshcop/secure_transport.hpp"
-
-#include "thread/thread_netif.hpp"
 
 /**
  * @file

src/core/common/message.cpp

@@ -33,16 +33,7 @@
 
 #include "message.hpp"
 
-#include "common/as_core_type.hpp"
-#include "common/code_utils.hpp"
-#include "common/debug.hpp"
-#include "common/heap.hpp"
-#include "common/log.hpp"
-#include "common/num_utils.hpp"
-#include "common/numeric_limits.hpp"
 #include "instance/instance.hpp"
-#include "net/checksum.hpp"
-#include "net/ip6.hpp"
 
 #if OPENTHREAD_MTD || OPENTHREAD_FTD
 

src/core/common/notifier.cpp

@@ -33,11 +33,6 @@
 
 #include "notifier.hpp"
 
-#include "border_router/routing_manager.hpp"
-#include "common/array.hpp"
-#include "common/code_utils.hpp"
-#include "common/debug.hpp"
-#include "common/log.hpp"
 #include "instance/instance.hpp"
 
 namespace ot {

src/core/common/settings.cpp

@@ -33,13 +33,7 @@
 
 #include "settings.hpp"
 
-#include "common/array.hpp"
-#include "common/code_utils.hpp"
-#include "common/debug.hpp"
-#include "common/num_utils.hpp"
 #include "instance/instance.hpp"
-#include "meshcop/dataset.hpp"
-#include "thread/mle.hpp"
 
 namespace ot {
 

src/core/common/time_ticker.cpp

@@ -33,11 +33,7 @@
 
 #include "time_ticker.hpp"
 
-#include "common/code_utils.hpp"
-#include "common/debug.hpp"
-#include "common/random.hpp"
 #include "instance/instance.hpp"
-#include "thread/mle_router.hpp"
 
 namespace ot {
 

src/core/common/timer.cpp

@@ -33,9 +33,6 @@
 
 #include "timer.hpp"
 
-#include "common/as_core_type.hpp"
-#include "common/code_utils.hpp"
-#include "common/debug.hpp"
 #include "instance/instance.hpp"
 
 namespace ot {

src/core/common/uptime.cpp

@@ -35,8 +35,6 @@
 
 #if OPENTHREAD_CONFIG_UPTIME_ENABLE
 
-#include "common/code_utils.hpp"
-#include "common/debug.hpp"
 #include "instance/instance.hpp"
 
 namespace ot {

src/core/diags/factory_diags.cpp

@@ -42,12 +42,7 @@
 #include <openthread/platform/diag.h>
 #include <openthread/platform/radio.h>
 
-#include "common/as_core_type.hpp"
-#include "common/code_utils.hpp"
-#include "common/error.hpp"
-#include "common/string.hpp"
 #include "instance/instance.hpp"
-#include "radio/radio.hpp"
 #include "utils/parse_cmdline.hpp"
 
 OT_TOOL_WEAK

src/core/instance/instance.cpp

@@ -36,7 +36,6 @@
 #include <openthread/platform/misc.h>
 
 #include "common/new.hpp"
-#include "radio/trel_link.hpp"
 #include "utils/heap.hpp"
 
 namespace ot {

src/core/instance/instance.hpp

@@ -46,15 +46,19 @@
 
 #include "common/array.hpp"
 #include "common/as_core_type.hpp"
+#include "common/debug.hpp"
 #include "common/error.hpp"
+#include "common/heap.hpp"
 #include "common/locator.hpp"
 #include "common/log.hpp"
 #include "common/message.hpp"
 #include "common/non_copyable.hpp"
 #include "common/random.hpp"
+#include "common/serial_number.hpp"
 #include "common/tasklet.hpp"
 #include "common/time_ticker.hpp"
 #include "common/timer.hpp"
+#include "common/type_traits.hpp"
 #include "common/uptime.hpp"
 #include "diags/factory_diags.hpp"
 #include "instance/extension.hpp"

src/core/mac/data_poll_handler.cpp

@@ -35,8 +35,6 @@
 
 #if OPENTHREAD_FTD
 
-#include "common/code_utils.hpp"
-#include "common/log.hpp"
 #include "instance/instance.hpp"
 
 namespace ot {

src/core/mac/data_poll_sender.cpp

@@ -33,16 +33,7 @@
 
 #include "data_poll_sender.hpp"
 
-#include "common/code_utils.hpp"
-#include "common/log.hpp"
-#include "common/message.hpp"
-#include "common/num_utils.hpp"
 #include "instance/instance.hpp"
-#include "net/ip6.hpp"
-#include "net/netif.hpp"
-#include "thread/mesh_forwarder.hpp"
-#include "thread/mle.hpp"
-#include "thread/thread_netif.hpp"
 
 namespace ot {
 

src/core/mac/link_raw.cpp

@@ -35,15 +35,10 @@
 
 #if OPENTHREAD_RADIO || OPENTHREAD_CONFIG_LINK_RAW_ENABLE
 
-#include <string.h>
 #include <openthread/diag.h>
 #include <openthread/platform/diag.h>
 
-#include "common/debug.hpp"
-#include "common/log.hpp"
-#include "common/random.hpp"
 #include "instance/instance.hpp"
-#include "mac/mac_frame.hpp"
 
 namespace ot {
 namespace Mac {

src/core/mac/mac.cpp

@@ -35,24 +35,9 @@
 
 #include <stdio.h>
 
-#include "common/array.hpp"
-#include "common/as_core_type.hpp"
-#include "common/code_utils.hpp"
-#include "common/debug.hpp"
-#include "common/encoding.hpp"
-#include "common/random.hpp"
-#include "common/string.hpp"
 #include "crypto/aes_ccm.hpp"
 #include "crypto/sha256.hpp"
 #include "instance/instance.hpp"
-#include "mac/mac_frame.hpp"
-#include "radio/radio.hpp"
-#include "thread/child.hpp"
-#include "thread/child_table.hpp"
-#include "thread/link_quality.hpp"
-#include "thread/mle_router.hpp"
-#include "thread/neighbor.hpp"
-#include "thread/thread_netif.hpp"
 
 namespace ot {
 namespace Mac {

src/core/mac/mac_filter.cpp

@@ -35,10 +35,7 @@
 
 #if OPENTHREAD_CONFIG_MAC_FILTER_ENABLE
 
-#include "common/array.hpp"
-#include "common/as_core_type.hpp"
-#include "common/code_utils.hpp"
-#include "thread/neighbor.hpp"
+#include "instance/instance.hpp"
 
 namespace ot {
 namespace Mac {

src/core/mac/mac_links.cpp

@@ -33,7 +33,6 @@
 
 #include "mac_links.hpp"
 
-#include "common/code_utils.hpp"
 #include "instance/instance.hpp"
 
 namespace ot {

src/core/mac/sub_mac.cpp

@@ -37,14 +37,7 @@
 
 #include <openthread/platform/time.h>
 
-#include "common/code_utils.hpp"
-#include "common/debug.hpp"
-#include "common/log.hpp"
-#include "common/num_utils.hpp"
-#include "common/random.hpp"
-#include "common/time.hpp"
 #include "instance/instance.hpp"
-#include "mac/mac_frame.hpp"
 
 namespace ot {
 namespace Mac {

src/core/mac/sub_mac_callbacks.cpp

@@ -33,13 +33,8 @@
 
 #include "sub_mac.hpp"
 
-#include "common/code_utils.hpp"
 #include "instance/instance.hpp"
 
-#if OPENTHREAD_FTD || OPENTHREAD_MTD
-#include "mac/mac.hpp"
-#endif
-
 namespace ot {
 namespace Mac {
 

src/core/mac/sub_mac_csl_receiver.cpp

@@ -35,8 +35,6 @@
 
 #if OPENTHREAD_CONFIG_MAC_CSL_RECEIVER_ENABLE
 
-#include "common/code_utils.hpp"
-#include "common/log.hpp"
 #include "instance/instance.hpp"
 
 namespace ot {

src/core/meshcop/announce_begin_client.cpp

@@ -35,15 +35,7 @@
 
 #if OPENTHREAD_CONFIG_COMMISSIONER_ENABLE && OPENTHREAD_FTD
 
-#include "coap/coap_message.hpp"
-#include "common/code_utils.hpp"
-#include "common/debug.hpp"
-#include "common/log.hpp"
 #include "instance/instance.hpp"
-#include "meshcop/meshcop.hpp"
-#include "meshcop/meshcop_tlvs.hpp"
-#include "thread/thread_netif.hpp"
-#include "thread/uri_paths.hpp"
 
 namespace ot {
 

src/core/meshcop/border_agent.cpp

@@ -35,18 +35,7 @@
 
 #if OPENTHREAD_CONFIG_BORDER_AGENT_ENABLE
 
-#include "coap/coap_message.hpp"
-#include "common/as_core_type.hpp"
-#include "common/heap.hpp"
-#include "common/log.hpp"
-#include "common/owned_ptr.hpp"
-#include "common/settings.hpp"
 #include "instance/instance.hpp"
-#include "meshcop/meshcop.hpp"
-#include "meshcop/meshcop_tlvs.hpp"
-#include "thread/thread_netif.hpp"
-#include "thread/thread_tlvs.hpp"
-#include "thread/uri_paths.hpp"
 
 namespace ot {
 namespace MeshCoP {

src/core/meshcop/commissioner.cpp

@@ -35,21 +35,7 @@
 
 #if OPENTHREAD_FTD && OPENTHREAD_CONFIG_COMMISSIONER_ENABLE
 
-#include <stdio.h>
-
-#include "coap/coap_message.hpp"
-#include "common/array.hpp"
-#include "common/as_core_type.hpp"
-#include "common/encoding.hpp"
-#include "common/string.hpp"
 #include "instance/instance.hpp"
-#include "meshcop/joiner.hpp"
-#include "meshcop/joiner_router.hpp"
-#include "meshcop/meshcop.hpp"
-#include "meshcop/meshcop_tlvs.hpp"
-#include "thread/thread_netif.hpp"
-#include "thread/thread_tlvs.hpp"
-#include "thread/uri_paths.hpp"
 
 namespace ot {
 namespace MeshCoP {

src/core/meshcop/dataset.cpp

@@ -34,16 +34,7 @@
 
 #include "dataset.hpp"
 
-#include <stdio.h>
-
-#include "common/code_utils.hpp"
-#include "common/encoding.hpp"
-#include "common/log.hpp"
 #include "instance/instance.hpp"
-#include "mac/mac_types.hpp"
-#include "meshcop/meshcop_tlvs.hpp"
-#include "meshcop/timestamp.hpp"
-#include "thread/mle_tlvs.hpp"
 
 namespace ot {
 namespace MeshCoP {

src/core/meshcop/dataset_manager.cpp

@@ -34,18 +34,7 @@
 
 #include "dataset_manager.hpp"
 
-#include <stdio.h>
-
-#include "common/as_core_type.hpp"
-#include "common/log.hpp"
-#include "common/notifier.hpp"
 #include "instance/instance.hpp"
-#include "meshcop/meshcop.hpp"
-#include "meshcop/meshcop_tlvs.hpp"
-#include "radio/radio.hpp"
-#include "thread/thread_netif.hpp"
-#include "thread/thread_tlvs.hpp"
-#include "thread/uri_paths.hpp"
 
 namespace ot {
 namespace MeshCoP {

src/core/meshcop/dataset_manager_ftd.cpp

@@ -36,25 +36,7 @@
 
 #if OPENTHREAD_FTD
 
-#include <stdio.h>
-
-#include <openthread/platform/radio.h>
-
-#include "coap/coap_message.hpp"
-#include "common/as_core_type.hpp"
-#include "common/code_utils.hpp"
-#include "common/debug.hpp"
-#include "common/log.hpp"
-#include "common/random.hpp"
-#include "common/timer.hpp"
 #include "instance/instance.hpp"
-#include "meshcop/dataset.hpp"
-#include "meshcop/meshcop.hpp"
-#include "meshcop/meshcop_leader.hpp"
-#include "meshcop/meshcop_tlvs.hpp"
-#include "thread/thread_netif.hpp"
-#include "thread/thread_tlvs.hpp"
-#include "thread/uri_paths.hpp"
 
 namespace ot {
 namespace MeshCoP {

src/core/meshcop/dataset_updater.cpp

@@ -36,11 +36,7 @@
 
 #if (OPENTHREAD_CONFIG_DATASET_UPDATER_ENABLE || OPENTHREAD_CONFIG_CHANNEL_MANAGER_ENABLE) && OPENTHREAD_FTD
 
-#include "common/code_utils.hpp"
-#include "common/log.hpp"
-#include "common/random.hpp"
 #include "instance/instance.hpp"
-#include "meshcop/timestamp.hpp"
 
 namespace ot {
 namespace MeshCoP {

src/core/meshcop/energy_scan_client.cpp

@@ -35,18 +35,7 @@
 
 #if OPENTHREAD_CONFIG_COMMISSIONER_ENABLE && OPENTHREAD_FTD
 
-#include "coap/coap_message.hpp"
-#include "common/as_core_type.hpp"
-#include "common/code_utils.hpp"
-#include "common/debug.hpp"
-#include "common/encoding.hpp"
-#include "common/log.hpp"
-#include "common/num_utils.hpp"
 #include "instance/instance.hpp"
-#include "meshcop/meshcop.hpp"
-#include "meshcop/meshcop_tlvs.hpp"
-#include "thread/thread_netif.hpp"
-#include "thread/uri_paths.hpp"
 
 namespace ot {
 

src/core/meshcop/extended_panid.cpp

@@ -34,7 +34,6 @@
 
 #include "extended_panid.hpp"
 
-#include "common/notifier.hpp"
 #include "instance/instance.hpp"
 
 namespace ot {

src/core/meshcop/joiner.cpp

@@ -35,21 +35,7 @@
 
 #if OPENTHREAD_CONFIG_JOINER_ENABLE
 
-#include <stdio.h>
-
-#include "common/array.hpp"
-#include "common/as_core_type.hpp"
-#include "common/code_utils.hpp"
-#include "common/debug.hpp"
-#include "common/encoding.hpp"
-#include "common/log.hpp"
-#include "common/string.hpp"
 #include "instance/instance.hpp"
-#include "meshcop/meshcop.hpp"
-#include "radio/radio.hpp"
-#include "thread/thread_netif.hpp"
-#include "thread/uri_paths.hpp"
-#include "utils/otns.hpp"
 
 namespace ot {
 namespace MeshCoP {

src/core/meshcop/joiner_router.cpp

@@ -35,18 +35,7 @@
 
 #if OPENTHREAD_FTD
 
-#include <stdio.h>
-
-#include "common/as_core_type.hpp"
-#include "common/code_utils.hpp"
-#include "common/encoding.hpp"
-#include "common/log.hpp"
 #include "instance/instance.hpp"
-#include "meshcop/meshcop.hpp"
-#include "meshcop/meshcop_tlvs.hpp"
-#include "thread/mle.hpp"
-#include "thread/thread_netif.hpp"
-#include "thread/uri_paths.hpp"
 
 namespace ot {
 namespace MeshCoP {

src/core/meshcop/meshcop.cpp

@@ -33,16 +33,9 @@
  */
 
 #include "meshcop.hpp"
-#include <openthread/platform/toolchain.h>
 
-#include "common/clearable.hpp"
 #include "common/crc16.hpp"
-#include "common/debug.hpp"
-#include "common/string.hpp"
-#include "crypto/sha256.hpp"
 #include "instance/instance.hpp"
-#include "mac/mac_types.hpp"
-#include "thread/thread_netif.hpp"
 
 namespace ot {
 

src/core/meshcop/meshcop_leader.cpp

@@ -35,19 +35,7 @@
 
 #if OPENTHREAD_FTD
 
-#include <stdio.h>
-
-#include "coap/coap_message.hpp"
-#include "common/as_core_type.hpp"
-#include "common/code_utils.hpp"
-#include "common/log.hpp"
-#include "common/random.hpp"
 #include "instance/instance.hpp"
-#include "meshcop/meshcop.hpp"
-#include "meshcop/meshcop_tlvs.hpp"
-#include "thread/thread_netif.hpp"
-#include "thread/thread_tlvs.hpp"
-#include "thread/uri_paths.hpp"
 
 namespace ot {
 namespace MeshCoP {

src/core/meshcop/meshcop_tlvs.cpp

@@ -33,12 +33,7 @@
 
 #include "meshcop_tlvs.hpp"
 
-#include "common/const_cast.hpp"
-#include "common/debug.hpp"
-#include "common/num_utils.hpp"
-#include "common/numeric_limits.hpp"
-#include "common/string.hpp"
-#include "meshcop/meshcop.hpp"
+#include "instance/instance.hpp"
 
 namespace ot {
 namespace MeshCoP {

src/core/meshcop/network_name.cpp

@@ -34,7 +34,6 @@
 
 #include "network_name.hpp"
 
-#include "common/notifier.hpp"
 #include "instance/instance.hpp"
 
 namespace ot {

src/core/meshcop/panid_query_client.cpp

@@ -35,16 +35,7 @@
 
 #if OPENTHREAD_CONFIG_COMMISSIONER_ENABLE && OPENTHREAD_FTD
 
-#include "coap/coap_message.hpp"
-#include "common/as_core_type.hpp"
-#include "common/code_utils.hpp"
-#include "common/debug.hpp"
-#include "common/log.hpp"
 #include "instance/instance.hpp"
-#include "meshcop/meshcop.hpp"
-#include "meshcop/meshcop_tlvs.hpp"
-#include "thread/thread_netif.hpp"
-#include "thread/uri_paths.hpp"
 
 namespace ot {
 

src/core/meshcop/secure_transport.cpp

@@ -38,19 +38,7 @@
 #include <mbedtls/pem.h>
 #endif
 
-#include <openthread/platform/radio.h>
-
-#include "common/as_core_type.hpp"
-#include "common/clearable.hpp"
-#include "common/code_utils.hpp"
-#include "common/debug.hpp"
-#include "common/encoding.hpp"
-#include "common/log.hpp"
-#include "common/timer.hpp"
-#include "crypto/mbedtls.hpp"
-#include "crypto/sha256.hpp"
 #include "instance/instance.hpp"
-#include "thread/thread_netif.hpp"
 
 #if OPENTHREAD_CONFIG_SECURE_TRANSPORT_ENABLE
 

src/core/meshcop/tcat_agent.cpp

@@ -32,21 +32,10 @@
  */
 
 #include "tcat_agent.hpp"
-#include <openthread/tcat.h>
-#include "meshcop/network_name.hpp"
 
 #if OPENTHREAD_CONFIG_BLE_TCAT_ENABLE
 
-#include "common/array.hpp"
-#include "common/code_utils.hpp"
-#include "common/debug.hpp"
-#include "common/encoding.hpp"
-#include "common/string.hpp"
 #include "instance/instance.hpp"
-#include "radio/radio.hpp"
-#include "thread/thread_netif.hpp"
-#include "thread/uri_paths.hpp"
-#include "utils/otns.hpp"
 
 namespace ot {
 namespace MeshCoP {

src/core/net/dhcp6_client.cpp

@@ -35,14 +35,7 @@
 
 #if OPENTHREAD_CONFIG_DHCP6_CLIENT_ENABLE
 
-#include "common/as_core_type.hpp"
-#include "common/code_utils.hpp"
-#include "common/encoding.hpp"
-#include "common/log.hpp"
 #include "instance/instance.hpp"
-#include "mac/mac.hpp"
-#include "net/dhcp6.hpp"
-#include "thread/thread_netif.hpp"
 
 namespace ot {
 namespace Dhcp6 {

src/core/net/dhcp6_server.cpp

@@ -35,14 +35,7 @@
 
 #if OPENTHREAD_CONFIG_DHCP6_SERVER_ENABLE
 
-#include "common/array.hpp"
-#include "common/as_core_type.hpp"
-#include "common/code_utils.hpp"
-#include "common/encoding.hpp"
-#include "common/log.hpp"
 #include "instance/instance.hpp"
-#include "thread/mle.hpp"
-#include "thread/thread_netif.hpp"
 
 namespace ot {
 namespace Dhcp6 {

src/core/net/dns_client.cpp

@@ -30,15 +30,7 @@
 
 #if OPENTHREAD_CONFIG_DNS_CLIENT_ENABLE
 
-#include "common/array.hpp"
-#include "common/as_core_type.hpp"
-#include "common/code_utils.hpp"
-#include "common/debug.hpp"
-#include "common/log.hpp"
 #include "instance/instance.hpp"
-#include "net/udp6.hpp"
-#include "thread/network_data_types.hpp"
-#include "thread/thread_netif.hpp"
 
 /**
  * @file

src/core/net/dns_dso.cpp

@@ -30,13 +30,6 @@
 
 #if OPENTHREAD_CONFIG_DNS_DSO_ENABLE
 
-#include "common/array.hpp"
-#include "common/as_core_type.hpp"
-#include "common/code_utils.hpp"
-#include "common/debug.hpp"
-#include "common/log.hpp"
-#include "common/num_utils.hpp"
-#include "common/random.hpp"
 #include "instance/instance.hpp"
 
 /**

src/core/net/dns_platform.cpp

@@ -33,11 +33,6 @@
 
 #include "openthread-core-config.h"
 
-#include <openthread/instance.h>
-#include <openthread/platform/dns.h>
-
-#include "common/code_utils.hpp"
-#include "common/message.hpp"
 #include "instance/instance.hpp"
 
 #if OPENTHREAD_CONFIG_DNS_UPSTREAM_QUERY_ENABLE

src/core/net/dns_types.cpp

@@ -33,12 +33,6 @@
 
 #include "dns_types.hpp"
 
-#include "common/code_utils.hpp"
-#include "common/debug.hpp"
-#include "common/num_utils.hpp"
-#include "common/numeric_limits.hpp"
-#include "common/random.hpp"
-#include "common/string.hpp"
 #include "instance/instance.hpp"
 
 namespace ot {

src/core/net/dnssd.cpp

@@ -35,7 +35,6 @@
 
 #if OPENTHREAD_CONFIG_PLATFORM_DNSSD_ENABLE || OPENTHREAD_CONFIG_MULTICAST_DNS_ENABLE
 
-#include "common/code_utils.hpp"
 #include "instance/instance.hpp"
 
 namespace ot {

src/core/net/dnssd_server.cpp

@@ -35,17 +35,7 @@
 
 #if OPENTHREAD_CONFIG_DNSSD_SERVER_ENABLE
 
-#include <openthread/platform/dns.h>
-
-#include "common/array.hpp"
-#include "common/as_core_type.hpp"
-#include "common/code_utils.hpp"
-#include "common/debug.hpp"
-#include "common/log.hpp"
-#include "common/string.hpp"
 #include "instance/instance.hpp"
-#include "net/srp_server.hpp"
-#include "net/udp6.hpp"
 
 namespace ot {
 namespace Dns {

src/core/net/dnssd_server.hpp

@@ -45,6 +45,7 @@
 #endif // OPENTHREAD_CONFIG_DNSSD_DISCOVERY_PROXY_ENABLE
 
 #include <openthread/dnssd_server.h>
+#include <openthread/platform/dns.h>
 
 #include "border_router/infra_if.hpp"
 #include "common/as_core_type.hpp"