espressif/openthread
1
0
Fork 0
mirror of https://github.com/espressif/openthread.git synced 2026-08-08 11:47:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

[test] relax mDNS query checks in border-router tests (#11698)

Browse Source 
This commit relaxes the `border_router` test scripts that check mDNS
query results. The test will no longer fail if an expected record
does not appear in the additional section.

This change aligns with RFC 6763 section 12, which specifies that
additional records are recommended but not required. Particularly, a
TXT record is not recommended for an SRV query (section 12.2), and a
TXT query has no recommended additional records (section 12.3).

The test will now validate the additional record if it is present but
will not fail if it is absent.
This commit is contained in:
Abtin Keshavarzian
2025-07-10 08:49:06 -07:00
committed by GitHub
parent d2d644d470
commit a01c9191c6
3 changed files with 12 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/scripts/thread-cert/border_router/test_dnssd_instance_name_with_space.py
+4 -2
View File
@@ -178,6 +178,10 @@ class TestDnssdInstanceNameWithSpace(thread_cert.TestCase):
print('not match: ', dig_answer, record,
list(a == b or (callable(b) and b(a)) for a, b in zip(dig_answer, record)))
# Additional records are optional. Ignore if missing.
if additional:
return
self.fail((record, dig_result))
def _match_record(self, record, match):
@@ -205,8 +209,6 @@ class TestDnssdInstanceNameWithSpace(thread_cert.TestCase):
self._assert_have_answer(dig_result, record, additional=False)
if 'ADDITIONAL' in expected_result:
self.assertGreaterEqual(len(dig_result['ADDITIONAL']), len(expected_result['ADDITIONAL']), dig_result)
for record in expected_result['ADDITIONAL']:
self._assert_have_answer(dig_result, record, additional=True)
tests/scripts/thread-cert/border_router/test_dnssd_server.py
+4 -2
View File
@@ -302,6 +302,10 @@ class TestDnssdServerOnBr(thread_cert.TestCase):
print('not match: ', dig_answer, record,
list(a == b or (callable(b) and b(a)) for a, b in zip(dig_answer, record)))
# Additional records are optional. Ignore if missing.
if additional:
return
self.fail((record, dig_result))
def _match_record(self, record, match):
@@ -332,8 +336,6 @@ class TestDnssdServerOnBr(thread_cert.TestCase):
self._assert_have_answer(dig_result, record, additional=False)
if 'ADDITIONAL' in expected_result:
self.assertGreaterEqual(len(dig_result['ADDITIONAL']), len(expected_result['ADDITIONAL']), dig_result)
for record in expected_result['ADDITIONAL']:
self._assert_have_answer(dig_result, record, additional=True)
tests/scripts/thread-cert/border_router/test_dnssd_server_multi_border_routers.py
+4 -2
View File
@@ -382,6 +382,10 @@ class TestDnssdServerOnMultiBr(thread_cert.TestCase):
print('not match: ', dig_answer, record,
list(a == b or (callable(b) and b(a)) for a, b in zip(dig_answer, record)))
# Additional records are optional. Ignore if missing.
if additional:
return
self.fail((record, dig_result))
def _match_record(self, record, match):
@@ -412,8 +416,6 @@ class TestDnssdServerOnMultiBr(thread_cert.TestCase):
self._assert_have_answer(dig_result, record, additional=False)
if 'ADDITIONAL' in expected_result:
self.assertGreaterEqual(len(dig_result['ADDITIONAL']), len(expected_result['ADDITIONAL']), dig_result)
for record in expected_result['ADDITIONAL']:
self._assert_have_answer(dig_result, record, additional=True)