espressif/openthread
1
0
Fork 0
mirror of https://github.com/espressif/openthread.git synced 2026-08-13 06:07:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

[test] replace sprintf with snprintf in otPlatDiagProcess() (#8549)

Browse Source 
It also removes stale comments in `ncp_hdlc.cp` about use of
`sprintf`.
This commit is contained in:
Abtin Keshavarzian
2022-12-19 12:12:45 -08:00
committed by GitHub
parent b366867de2
commit a09e8813f9
2 changed files with 2 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ncp/ncp_hdlc.cpp
-5
View File
@@ -274,8 +274,6 @@ void NcpHdlc::HandleError(otError aError, uint8_t *aBuf, uint16_t aBufLength)
super_t::IncrementFrameErrorCounter();
// We can get away with sprintf because we know
// `hexbuf` is large enough.
snprintf(hexbuf, sizeof(hexbuf), "Framing error %d: [", aError);
// Write out the first part of our log message.
@@ -285,9 +283,6 @@ void NcpHdlc::HandleError(otError aError, uint8_t *aBuf, uint16_t aBufLength)
// The second '3' comes from the length of two hex digits and a space.
for (i = 0; (i < aBufLength) && (i < (sizeof(hexbuf) - 3) / 3); i++)
{
// We can get away with sprintf because we know
// `hexbuf` is large enough, based on our calculations
// above.
snprintf(&hexbuf[i * 3], sizeof(hexbuf) - i * 3, " %02X", static_cast<uint8_t>(aBuf[i]));
}
tests/unit/test_platform.cpp
+2 -2
View File
@@ -193,9 +193,9 @@ exit:
return error;
}
OT_TOOL_WEAK void otPlatDiagProcess(otInstance *, uint8_t, char *aArgs[], char *aOutput, size_t)
OT_TOOL_WEAK void otPlatDiagProcess(otInstance *, uint8_t, char *aArgs[], char *aOutput, size_t aOutputMaxLen)
{
sprintf(aOutput, "diag feature '%s' is not supported\r\n", aArgs[0]);
snprintf(aOutput, aOutputMaxLen, "diag feature '%s' is not supported\r\n", aArgs[0]);
}
OT_TOOL_WEAK void otPlatDiagModeSet(bool aMode) { sDiagMode = aMode; }