espressif/openthread
1
0
Fork 0
mirror of https://github.com/espressif/openthread.git synced 2026-09-05 08:40:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

[posix] remove the polling mode from spi interface (#11303)

Browse Source 
The RCP should assert the interrupt pin to notify the SPI interface of
an impending data frame transfer to the host. This commit removes the
polling mode from the spi interface.
This commit is contained in:
Zhanglong Xia
2025-02-26 19:53:37 -08:00
committed by GitHub
parent 560940af20
commit b5164cf836
3 changed files with 19 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/posix/platform/radio_url.cpp
+1 -4
View File
@@ -49,12 +49,9 @@ const char *otSysGetRadioUrlHelpString(void)
"Parameters:\n" \
" gpio-int-device[=gpio-device-path]\n" \
" Specify a path to the Linux sysfs-exported GPIO device for the\n" \
" `I̅N̅T̅` pin. If not specified, `SPI` interface will fall back to\n" \
" polling, which is inefficient.\n" \
" `I̅N̅T̅` pin.\n" \
" gpio-int-line[=line-offset]\n" \
" The offset index of `I̅N̅T̅` pin for the associated GPIO device.\n" \
" If not specified, `SPI` interface will fall back to polling,\n" \
" which is inefficient.\n" \
" gpio-reset-dev[=gpio-device-path]\n" \
" Specify a path to the Linux sysfs-exported GPIO device for the\n" \
" `R̅E̅S̅` pin.\n" \
src/posix/platform/spi_interface.cpp
+18 -39
View File
@@ -150,16 +150,7 @@ otError SpiInterface::Init(ReceiveFrameCallback aCallback, void *aCallbackContex
mSpiSmallPacketSize = spiSmallPacketSize;
mSpiAlignAllowance = spiAlignAllowance;
if (spiGpioIntDevice != nullptr)
{
// If the interrupt pin is not set, SPI interface will use polling mode.
InitIntPin(spiGpioIntDevice, spiGpioIntLine);
}
else
{
LogNote("SPI interface enters polling mode.");
}
InitIntPin(spiGpioIntDevice, spiGpioIntLine);
InitResetPin(spiGpioResetDevice, spiGpioResetLine);
InitSpiDev(mRadioUrl.GetPath(), spiMode, spiSpeed);
@@ -606,16 +597,12 @@ exit:
return error;
}
bool SpiInterface::CheckInterrupt(void)
{
return (mIntGpioValueFd >= 0) ? (GetGpioValue(mIntGpioValueFd) == kGpioIntAssertState) : true;
}
bool SpiInterface::CheckInterrupt(void) { return (GetGpioValue(mIntGpioValueFd) == kGpioIntAssertState); }
void SpiInterface::UpdateFdSet(void *aMainloopContext)
{
struct timeval timeout = {kSecPerDay, 0};
struct timeval pollingTimeout = {0, kSpiPollPeriodUs};
otSysMainloopContext *context = reinterpret_cast<otSysMainloopContext *>(aMainloopContext);
struct timeval timeout = {kSecPerDay, 0};
otSysMainloopContext *context = reinterpret_cast<otSysMainloopContext *>(aMainloopContext);
assert(context != nullptr);
@@ -626,31 +613,23 @@ void SpiInterface::UpdateFdSet(void *aMainloopContext)
timeout.tv_usec = 0;
}
if (mIntGpioValueFd >= 0)
if (context->mMaxFd < mIntGpioValueFd)
{
if (context->mMaxFd < mIntGpioValueFd)
{
context->mMaxFd = mIntGpioValueFd;
}
if (CheckInterrupt())
{
// Interrupt pin is asserted, set the timeout to be 0.
timeout.tv_sec = 0;
timeout.tv_usec = 0;
LogDebg("UpdateFdSet(): Interrupt.");
}
else
{
// The interrupt pin was not asserted, so we wait for the interrupt pin to be asserted by adding it to the
// read set.
FD_SET(mIntGpioValueFd, &context->mReadFdSet);
}
context->mMaxFd = mIntGpioValueFd;
}
else if (timercmp(&pollingTimeout, &timeout, <))
if (CheckInterrupt())
{
// In this case we don't have an interrupt, so we revert to SPI polling.
timeout = pollingTimeout;
// Interrupt pin is asserted, set the timeout to be 0.
timeout.tv_sec = 0;
timeout.tv_usec = 0;
LogDebg("UpdateFdSet(): Interrupt.");
}
else
{
// The interrupt pin was not asserted, so we wait for the interrupt pin to be asserted by adding it to the
// read set.
FD_SET(mIntGpioValueFd, &context->mReadFdSet);
}
if (mSpiTxRefusedCount)
src/posix/platform/spi_interface.hpp
-1
View File
@@ -201,7 +201,6 @@ private:
{
kMsecPerSec = 1000,
kUsecPerMsec = 1000,
kSpiPollPeriodUs = kMsecPerSec * kUsecPerMsec / 30,
kSecPerDay = 60 * 60 * 24,
kResetHoldOnUsec = 10 * kUsecPerMsec,
kImmediateRetryTimeoutUs = 1 * kUsecPerMsec,