espressif/openthread
1
0
Fork 0
mirror of https://github.com/espressif/openthread.git synced 2026-08-21 09:59:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

[netdata] remove unallocated router ID entries on recovery after reset (#9421)

Browse Source 
This commit updates `HandleNetworkDataRestoredAfterReset()` which is
called when a leader device is reset and recovers the Network Data
from other routers. With the new code, leader will now check and
remove entries in the restored Network Data that are from any
currently unallocated router ID.

This change acts as a safeguard against an edge case where the leader
is reset at an inopportune time, such as right after it removed an
allocated router ID and sent MLE advertisement but before it got the
chance to send the updated Network Data to other routers.
This commit is contained in:
Abtin Keshavarzian
2023-09-14 16:41:31 -07:00
committed by GitHub
parent 8ed949e6fd
commit b5b93423d8
1 changed files with 25 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/core/thread/network_data_leader_ftd.cpp
+25
View File
@@ -1319,9 +1319,34 @@ void Leader::HandleNetworkDataRestoredAfterReset(void)
{
const PrefixTlv *prefix;
TlvIterator tlvIterator(GetTlvsStart(), GetTlvsEnd());
Iterator iterator = kIteratorInit;
ChangedFlags flags;
uint16_t rloc16;
mWaitingForNetDataSync = false;
// Remove entries in Network Data from any un-allocated Router ID.
// This acts as a safeguard against an edge case where the leader
// is reset at an inopportune time, such as right after it removed
// an allocated router ID and sent MLE advertisement but before it
// got the chance to send the updated Network Data to other
// routers.
while (GetNextServer(iterator, rloc16) == kErrorNone)
{
if (!Get<RouterTable>().IsAllocated(Mle::RouterIdFromRloc16(rloc16)))
{
// After we `RemoveRloc()` the Network Data gets changed
// and the `iterator` will not be valid anymore. So we set
// it to `kIteratorInit` to restart the loop.
RemoveRloc(rloc16, kMatchModeRouterId, flags);
iterator = kIteratorInit;
}
}
IncrementVersions(flags);
// Synchronize internal 6LoWPAN Context ID Set with the
// recently obtained Network Data.