espressif/openthread
1
0
Fork 0
mirror of https://github.com/espressif/openthread.git synced 2026-08-01 08:37:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

[clang-tidy] readability-else-after-return (#5808)

Browse Source
This commit is contained in:
Jonathan Hui
2020-11-16 08:52:10 -08:00
committed by GitHub
parent b7728d4ba7
commit b9c956174e
3 changed files with 27 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files
script/make-pretty
+1
View File
@@ -124,6 +124,7 @@ modernize-use-equals-default,\
modernize-use-equals-delete,\
modernize-use-nullptr,\
readability-avoid-const-params-in-decls,\
readability-else-after-return,\
readability-inconsistent-declaration-parameter-name,\
readability-make-member-function-const,\
readability-redundant-member-init,\
src/core/thread/mle_router.cpp
+2 -4
View File
@@ -4230,10 +4230,8 @@ bool MleRouter::HasOneNeighborWithComparableConnectivity(const RouteTlv &aRoute,
routerCount++;
continue;
}
else
{
ExitNow(rval = false);
}
ExitNow(rval = false);
}
}
tests/unit/test_platform.cpp
+24 -36
View File
@@ -140,16 +140,16 @@ void otPlatAlarmMilliStartAt(otInstance *aInstance, uint32_t aT0, uint32_t aDt)
uint32_t otPlatAlarmMilliGetNow(void)
{
struct timeval tv;
if (g_testPlatAlarmGetNow)
{
return g_testPlatAlarmGetNow();
}
else
{
struct timeval tv;
gettimeofday(&tv, nullptr);
return (uint32_t)((tv.tv_sec * 1000) + (tv.tv_usec / 1000) + 123456);
}
gettimeofday(&tv, nullptr);
return (uint32_t)((tv.tv_sec * 1000) + (tv.tv_usec / 1000) + 123456);
}
void otPlatAlarmMicroStop(otInstance *aInstance)
@@ -179,16 +179,16 @@ void otPlatAlarmMicroStartAt(otInstance *aInstance, uint32_t aT0, uint32_t aDt)
uint32_t otPlatAlarmMicroGetNow(void)
{
struct timeval tv;
if (g_testPlatAlarmGetNow)
{
return g_testPlatAlarmGetNow();
}
else
{
struct timeval tv;
gettimeofday(&tv, nullptr);
return (uint32_t)((tv.tv_sec * 1000000) + tv.tv_usec + 123456);
}
gettimeofday(&tv, nullptr);
return (uint32_t)((tv.tv_sec * 1000000) + tv.tv_usec + 123456);
}
//
@@ -233,10 +233,8 @@ bool otPlatRadioIsEnabled(otInstance *aInstance)
{
return g_testPlatRadioIsEnabled(aInstance);
}
else
{
return true;
}
return true;
}
otError otPlatRadioEnable(otInstance *aInstance)
@@ -245,10 +243,8 @@ otError otPlatRadioEnable(otInstance *aInstance)
{
return g_testPlatRadioEnable(aInstance);
}
else
{
return OT_ERROR_NONE;
}
return OT_ERROR_NONE;
}
otError otPlatRadioDisable(otInstance *aInstance)
@@ -257,10 +253,8 @@ otError otPlatRadioDisable(otInstance *aInstance)
{
return g_testPlatRadioDisable(aInstance);
}
else
{
return OT_ERROR_NONE;
}
return OT_ERROR_NONE;
}
otError otPlatRadioSleep(otInstance *)
@@ -274,10 +268,8 @@ otError otPlatRadioReceive(otInstance *aInstance, uint8_t aChannel)
{
return g_testPlatRadioReceive(aInstance, aChannel);
}
else
{
return OT_ERROR_NONE;
}
return OT_ERROR_NONE;
}
otError otPlatRadioTransmit(otInstance *aInstance, otRadioFrame *aFrame)
@@ -288,10 +280,8 @@ otError otPlatRadioTransmit(otInstance *aInstance, otRadioFrame *aFrame)
{
return g_testPlatRadioTransmit(aInstance);
}
else
{
return OT_ERROR_NONE;
}
return OT_ERROR_NONE;
}
otRadioFrame *otPlatRadioGetTransmitBuffer(otInstance *aInstance)
@@ -300,10 +290,8 @@ otRadioFrame *otPlatRadioGetTransmitBuffer(otInstance *aInstance)
{
return g_testPlatRadioGetTransmitBuffer(aInstance);
}
else
{
return nullptr;
}
return nullptr;
}
int8_t otPlatRadioGetRssi(otInstance *)