espressif/openthread
1
0
Fork 0
mirror of https://github.com/espressif/openthread.git synced 2026-06-06 05:24:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

[trel] defer channel check in Link::ProcessReceivedPacket() (#13011)

Browse Source 
This commit updates `Trel::Link::ProcessReceivedPacket()` to move
channel mismatch validation until after the acknowledgment logic.

TREL ACKs serve as a mechanism to monitor link status between peers.
By deferring the channel check, we ensure that TREL packets requiring
an acknowledgment are correctly acknowledged at the TREL layer even
if they are not further processed.

A primary use case is the MLE Announce message, which is sent on a
different channel as a broadcast. At the TREL layer, this broadcast
is converted to unicast TREL packet transmissions to each peer on the
same PAN, with packets marked to request a TREL ACK. This change
ensures the receiving TREL peer sends an ACK for such packets,
maintaining link monitoring, while still dropping the packet at the
TREL link layer due to the channel mismatch.
This commit is contained in:
Abtin Keshavarzian
2026-05-04 10:02:55 -07:00
committed by GitHub
parent 73cc8a5c05
commit bdea2ae98c
1 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/core/radio/trel_link.cpp
+10 -4
View File
@@ -326,12 +326,10 @@ void Link::ProcessReceivedPacket(Packet &aPacket, const Ip6::SockAddr &aSockAddr
if (type != Header::kTypeAck)
{
// No need to check state or channel for a TREL ack packet.
// Note that TREL ack may be received much later than the tx
// and device can be on a different rx channel.
// We do not check the radio state for a TREL ACK packet, as it
// can be received much later than the transmission.
VerifyOrExit((mState == kStateReceive) || (mState == kStateTransmit));
VerifyOrExit(aPacket.GetHeader().GetChannel() == mRxChannel);
}
if (mPanId != Mac::kPanIdBroadcast)
@@ -370,6 +368,14 @@ void Link::ProcessReceivedPacket(Packet &aPacket, const Ip6::SockAddr &aSockAddr
SendAck(aPacket);
}
// Drop the packet if there is a channel mismatch. We perform this
// check after all other validations to ensure we still `SendAck()`.
// TREL ACKs are used to monitor the TREL link status between peers
// and should be sent even if the packet is sent on a different
// channel (e.g., an MLE Announce message).
VerifyOrExit(aPacket.GetHeader().GetChannel() == mRxChannel);
mRxFrame.mPsdu = aPacket.GetPayload();
mRxFrame.mLength = aPacket.GetPayloadLength();
mRxFrame.mChannel = aPacket.GetHeader().GetChannel();