espressif/openthread
1
0
Fork 0
mirror of https://github.com/espressif/openthread.git synced 2026-08-01 00:27:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

[nexus] fix flakiness in test 9.2.4 (#12531)

Browse Source 
Test 9.2.4 could occasionally fail due to the random selection of
the initial channel by the Leader. If the randomly selected channel
matched the 'Secondary' channel (12) used in MGMT_ACTIVE_SET.req in
step 6, the request would be accepted instead of rejected, causing
a verification failure.

This commit fixes the issue by explicitly configuring the Leader's
initial Operational Dataset with a fixed set of parameters (Channel
11, PAN ID 0xABCD, etc.) that are guaranteed to be different from
the parameters tested in the MGMT_ACTIVE_SET.req steps.

The fix was verified by running the test 20 times in a loop without
any failures.
This commit is contained in:
Jonathan Hui
2026-02-23 16:45:38 -06:00
committed by GitHub
parent 7f5aab9717
commit c7bbcb823e
1 changed files with 48 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/nexus/test_9_2_4.cpp
+48 -1
View File
@@ -30,8 +30,11 @@
#include <string.h>
#include "meshcop/commissioner.hpp"
#include "meshcop/dataset.hpp"
#include "platform/nexus_core.hpp"
#include "platform/nexus_node.hpp"
#include "thread/mle.hpp"
#include "thread/thread_netif.hpp"
namespace ot {
namespace Nexus {
@@ -194,6 +197,27 @@ static const uint8_t kSteeringDataStep18[] = {0x11, 0x33, 0x20, 0x44, 0x00, 0x00
*/
static constexpr uint8_t kFutureTlvType = 130;
/**
* Initial Channel.
*/
static constexpr uint16_t kInitialChannel = 11;
/**
* Initial PAN ID.
*/
static constexpr uint16_t kInitialPanId = 0xabcd;
/**
* Initial Network Key.
*/
static const uint8_t kInitialNetworkKey[] = {0xee, 0xee, 0xee, 0xee, 0xee, 0xee, 0xee, 0xee,
0xee, 0xee, 0xee, 0xee, 0xee, 0xee, 0xee, 0xee};
/**
* Initial Mesh-Local Prefix.
*/
static const uint8_t kInitialMeshLocalPrefix[] = {0xfd, 0x00, 0xab, 0xba, 0x00, 0x00, 0x00, 0x00};
/**
* Future TLV Value.
*/
@@ -251,7 +275,30 @@ void RunTest9_2_4(Topology aTopology, const char *aJsonFile)
leader.AllowList(commissioner);
commissioner.AllowList(leader);
leader.Form();
{
MeshCoP::Dataset::Info datasetInfo;
SuccessOrQuit(datasetInfo.GenerateRandom(leader.GetInstance()));
datasetInfo.Set<MeshCoP::Dataset::kChannel>(kInitialChannel);
datasetInfo.Set<MeshCoP::Dataset::kPanId>(kInitialPanId);
{
NetworkKey &networkKey = datasetInfo.Update<MeshCoP::Dataset::kNetworkKey>();
memcpy(networkKey.m8, kInitialNetworkKey, sizeof(networkKey));
}
{
Ip6::NetworkPrefix &prefix = datasetInfo.Update<MeshCoP::Dataset::kMeshLocalPrefix>();
memcpy(prefix.m8, kInitialMeshLocalPrefix, sizeof(prefix.m8));
}
leader.Get<MeshCoP::ActiveDatasetManager>().SaveLocal(datasetInfo);
leader.Get<ThreadNetif>().Up();
SuccessOrQuit(leader.Get<Mle::Mle>().Start());
}
nexus.AdvanceTime(kFormNetworkTime);
VerifyOrQuit(leader.Get<Mle::Mle>().IsLeader());