espressif/openthread
1
0
Fork 0
mirror of https://github.com/espressif/openthread.git synced 2026-08-20 09:29:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

[nrf528xx] fix IAR undefined order of volatile accesses error (#4702)

Browse Source 
Fixes IAR compiler warning: "warning[Pa082]: undefined behavior: the
order of volatile accesses is undefined in this statement"
This commit is contained in:
Piotr Koziar
2020-03-18 19:03:50 -07:00
committed by GitHub
parent 7456be9e80
commit ccf4eb9a51
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
examples/platforms/nrf528xx/src/transport/uart.c
+7 -3
View File
@@ -87,7 +87,8 @@ static __INLINE bool isRxBufferFull()
*/
static __INLINE bool isRxBufferEmpty()
{
return (sReceiveHead == sReceiveTail);
uint16_t head = sReceiveHead;
return (head == sReceiveTail);
}
/**
@@ -97,6 +98,7 @@ static void processReceive(void)
{
// Set head position to not be changed during read procedure.
uint16_t head = sReceiveHead;
uint8_t *position;
otEXPECT(isRxBufferEmpty() == false);
@@ -104,14 +106,16 @@ static void processReceive(void)
// bytes from the end of the buffer.
if (head < sReceiveTail)
{
otPlatUartReceived(&sReceiveBuffer[sReceiveTail], (UART_RX_BUFFER_SIZE - sReceiveTail));
position = &sReceiveBuffer[sReceiveTail];
otPlatUartReceived(position, (UART_RX_BUFFER_SIZE - sReceiveTail));
sReceiveTail = 0;
}
// Notify about received bytes.
if (head > sReceiveTail)
{
otPlatUartReceived(&sReceiveBuffer[sReceiveTail], (head - sReceiveTail));
position = &sReceiveBuffer[sReceiveTail];
otPlatUartReceived(position, (head - sReceiveTail));
sReceiveTail = head;
}