espressif/openthread
1
0
Fork 0
mirror of https://github.com/espressif/openthread.git synced 2026-09-03 15:50:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

[url] fix returning empty value (#6142)

Browse Source 
This commit fixing returning empty value. The address of `""` is fixed
and cannot be used as aLastValue of Url::GetValue().
This commit is contained in:
Yakun Xu
2021-02-06 12:33:45 -08:00
committed by GitHub
parent 31746000e8
commit d8b89223b4
1 changed files with 20 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/lib/url/url.cpp
+20 -1
View File
@@ -98,7 +98,7 @@ const char *Url::GetValue(const char *aName, const char *aLastValue) const
}
else if (start[len] == '\0')
{
ExitNow(rval = "");
ExitNow(rval = &start[len]);
}
}
last = start;
@@ -153,6 +153,24 @@ void TestSimpleNoQueryString(void)
printf("PASS %s\r\n", __func__);
}
void TestEmptyValue(void)
{
char url[] = "spinel:///dev/ttyUSB0?rtscts&baudrate=115200&verbose&verbose&verbose";
ot::Url::Url args;
const char * arg = nullptr;
assert(!args.Init(url));
assert(!strcmp(args.GetPath(), "/dev/ttyUSB0"));
assert((arg = args.GetValue("rtscts")) != nullptr);
assert(args.GetValue("rtscts", arg) == nullptr);
assert((arg = args.GetValue("verbose", arg)) != nullptr);
assert((arg = args.GetValue("verbose", arg)) != nullptr);
assert((arg = args.GetValue("verbose", arg)) != nullptr);
assert((arg = args.GetValue("verbose", arg)) == nullptr);
printf("PASS %s\r\n", __func__);
}
void TestMultipleProtocols(void)
{
char url[] = "spinel+spi:///dev/ttyUSB0?baudrate=115200";
@@ -196,6 +214,7 @@ int main(void)
{
TestSimple();
TestSimpleNoQueryString();
TestEmptyValue();
TestMultipleProtocols();
TestMultipleProtocolsAndDuplicateParameters();