[cli] add helper method to output "Enabled/Disabled" status (#6158)

This commit is contained in:
Abtin Keshavarzian
2021-02-09 22:14:48 -08:00
committed by GitHub
parent 89aacf5dd7
commit db117e27b2
4 changed files with 19 additions and 27 deletions
+9 -25
View File
@@ -189,6 +189,11 @@ void Interpreter::OutputBytes(const uint8_t *aBytes, uint16_t aLength)
}
}
void Interpreter::OutputEnabledDisabledStatus(bool aEnabled)
{
OutputLine(aEnabled ? "Enabled" : "Disabled");
}
int Interpreter::OutputIp6Address(const otIp6Address &aAddress)
{
return OutputFormat(
@@ -1083,7 +1088,7 @@ otError Interpreter::ProcessCoexMetrics(uint8_t aArgsLength, char *aArgs[])
if (aArgsLength == 0)
{
OutputLine(otPlatRadioIsCoexEnabled(mInstance) ? "Enabled" : "Disabled");
OutputEnabledDisabledStatus(otPlatRadioIsCoexEnabled(mInstance));
}
else if (strcmp(aArgs[0], "enable") == 0)
{
@@ -1792,14 +1797,7 @@ otError Interpreter::ProcessMulticastPromiscuous(uint8_t aArgsLength, char *aArg
if (aArgsLength == 0)
{
if (otIp6IsMulticastPromiscuousEnabled(mInstance))
{
OutputLine("Enabled");
}
else
{
OutputLine("Disabled");
}
OutputEnabledDisabledStatus(otIp6IsMulticastPromiscuousEnabled(mInstance));
}
else
{
@@ -3062,14 +3060,7 @@ otError Interpreter::ProcessPromiscuous(uint8_t aArgsLength, char *aArgs[])
if (aArgsLength == 0)
{
if (otLinkIsPromiscuous(mInstance) && otPlatRadioGetPromiscuous(mInstance))
{
OutputLine("Enabled");
}
else
{
OutputLine("Disabled");
}
OutputEnabledDisabledStatus(otLinkIsPromiscuous(mInstance) && otPlatRadioGetPromiscuous(mInstance));
}
else
{
@@ -3616,14 +3607,7 @@ otError Interpreter::ProcessRouterEligible(uint8_t aArgsLength, char *aArgs[])
if (aArgsLength == 0)
{
if (otThreadIsRouterEligible(mInstance))
{
OutputLine("Enabled");
}
else
{
OutputLine("Disabled");
}
OutputEnabledDisabledStatus(otThreadIsRouterEligible(mInstance));
}
else if (strcmp(aArgs[0], "enable") == 0)
{
+8
View File
@@ -258,6 +258,14 @@ public:
*/
void OutputResult(otError aError);
/**
* This method delivers "Enabled" or "Disabled" status to the CLI client (it also appends newline `\r\n`).
*
* @param[in] aEnabled A boolean indicating the status. TRUE outputs "Enabled", FALSE outputs "Disabled".
*
*/
void OutputEnabledDisabledStatus(bool aEnabled);
/**
* This method sets the user command table.
*
+1 -1
View File
@@ -102,7 +102,7 @@ otError SrpClient::ProcessCallback(uint8_t aArgsLength, char *aArgs[])
if (aArgsLength == 0)
{
mInterpreter.OutputLine(mCallbackEnabled ? "Enabled" : "Disabled");
mInterpreter.OutputEnabledDisabledStatus(mCallbackEnabled);
ExitNow();
}
+1 -1
View File
@@ -214,7 +214,7 @@ otError UdpExample::ProcessLinkSecurity(uint8_t aArgsLength, char *aArgs[])
if (aArgsLength == 0)
{
mInterpreter.OutputLine(mLinkSecurityEnabled ? "Enabled" : "Disabled");
mInterpreter.OutputEnabledDisabledStatus(mLinkSecurityEnabled);
}
else if (strcmp(aArgs[0], "enable") == 0)
{