espressif/openthread
1
0
Fork 0
mirror of https://github.com/espressif/openthread.git synced 2026-07-28 14:47:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

[dns-client] add const to address pointer (#4399)

Browse Source 
- Also change CLI implementation to avoid reference binding to null pointer.
This commit is contained in:
Jonathan Hui
2019-12-13 17:19:34 -08:00
committed by GitHub
parent 1ea4ed3eab
commit dff1694fe1
5 changed files with 25 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files
include/openthread/dns.h
+5 -5
View File
@@ -85,11 +85,11 @@ typedef struct otDnsQuery
* @retval OT_ERROR_FAILED A response was received but status code is different than success.
*
*/
typedef void (*otDnsResponseHandler)(void * aContext,
const char * aHostname,
otIp6Address *aAddress,
uint32_t aTtl,
otError aResult);
typedef void (*otDnsResponseHandler)(void * aContext,
const char * aHostname,
const otIp6Address *aAddress,
uint32_t aTtl,
otError aResult);
/**
* This function sends a DNS query for AAAA (IPv6) record.
src/cli/cli.cpp
+12 -9
View File
@@ -1078,23 +1078,26 @@ exit:
}
}
void Interpreter::HandleDnsResponse(void * aContext,
const char * aHostname,
otIp6Address *aAddress,
uint32_t aTtl,
otError aResult)
void Interpreter::HandleDnsResponse(void * aContext,
const char * aHostname,
const otIp6Address *aAddress,
uint32_t aTtl,
otError aResult)
{
static_cast<Interpreter *>(aContext)->HandleDnsResponse(aHostname, *static_cast<Ip6::Address *>(aAddress), aTtl,
aResult);
static_cast<Interpreter *>(aContext)->HandleDnsResponse(aHostname, static_cast<const Ip6::Address *>(aAddress),
aTtl, aResult);
}
void Interpreter::HandleDnsResponse(const char *aHostname, Ip6::Address &aAddress, uint32_t aTtl, otError aResult)
void Interpreter::HandleDnsResponse(const char *aHostname, const Ip6::Address *aAddress, uint32_t aTtl, otError aResult)
{
mServer->OutputFormat("DNS response for %s - ", aHostname);
if (aResult == OT_ERROR_NONE)
{
OutputIp6Address(aAddress);
if (aAddress != NULL)
{
OutputIp6Address(*aAddress);
}
mServer->OutputFormat(" TTL: %d\r\n", aTtl);
}
else
src/cli/cli.hpp
+6 -6
View File
@@ -350,11 +350,11 @@ private:
static void HandleDiagnosticGetResponse(otMessage *aMessage, const otMessageInfo *aMessageInfo, void *aContext);
#if OPENTHREAD_CONFIG_DNS_CLIENT_ENABLE
static void HandleDnsResponse(void * aContext,
const char * aHostname,
otIp6Address *aAddress,
uint32_t aTtl,
otError aResult);
static void HandleDnsResponse(void * aContext,
const char * aHostname,
const otIp6Address *aAddress,
uint32_t aTtl,
otError aResult);
#endif
#if OPENTHREAD_CONFIG_SNTP_CLIENT_ENABLE
@@ -368,7 +368,7 @@ private:
void HandleLinkPcapReceive(const otRadioFrame *aFrame, bool aIsTx);
void HandleDiagnosticGetResponse(Message &aMessage, const Ip6::MessageInfo &aMessageInfo);
#if OPENTHREAD_CONFIG_DNS_CLIENT_ENABLE
void HandleDnsResponse(const char *aHostname, Ip6::Address &aAddress, uint32_t aTtl, otError aResult);
void HandleDnsResponse(const char *aHostname, const Ip6::Address *aAddress, uint32_t aTtl, otError aResult);
#endif
#if OPENTHREAD_CONFIG_SNTP_CLIENT_ENABLE
void HandleSntpResponse(uint64_t aTime, otError aResult);
src/core/net/dns_client.cpp
+1 -1
View File
@@ -382,7 +382,7 @@ exit:
void Client::FinalizeDnsTransaction(Message & aQuery,
const QueryMetadata &aQueryMetadata,
otIp6Address * aAddress,
const otIp6Address * aAddress,
uint32_t aTtl,
otError aResult)
{
src/core/net/dns_client.hpp
+1 -1
View File
@@ -206,7 +206,7 @@ private:
Message *FindRelatedQuery(const Header &aResponseHeader, QueryMetadata &aQueryMetadata);
void FinalizeDnsTransaction(Message & aQuery,
const QueryMetadata &aQueryMetadata,
otIp6Address * aAddress,
const otIp6Address * aAddress,
uint32_t aTtl,
otError aResult);